Re: kernel32: Implement GetVolumePathName.

2011-10-04 Thread Erich Hoover
On Tue, Oct 4, 2011 at 9:46 AM, Dan Kegel wrote: > Fails test here? > ... 3 RtlDosPathNameToNtPathName_U+0x35c(dos_path="C:\windows\system32", > ntpath=0x32fbb4, file_part=(nil), cd=(nil)) [dlls/ntdll/path.c:394] > 4 GetVolumePathNameW+0x107(filename="C:\windows\system32", > volumepathname="?Ir

Re: ws2_32: Patch to selectively bind to interfaces while still allowing broadcast packets (try 2)

2011-10-04 Thread Erich Hoover
On Tue, Oct 4, 2011 at 3:30 PM, Marcus Meissner wrote: > On Tue, Oct 04, 2011 at 10:51:26AM -0600, Erich Hoover wrote: > > ... While this feature normally requires root > > privileges, it can also be enabled by giving wine-preloader the > > CAP_NET_RAW capability.  ... > Frankly, no sane distribut

Re: ws2_32: Patch to selectively bind to interfaces while still allowing broadcast packets (try 2)

2011-10-04 Thread Marcus Meissner
On Tue, Oct 04, 2011 at 10:51:26AM -0600, Erich Hoover wrote: > Real Name: >     Erich Hoover > > Description: >     I know it's been quite a while, but I'm back with another solution > for Bug #7929. This patch uses SO_BINDTODEVICE in order to bind a > socket to a specific interface while still

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile

2011-10-04 Thread Eric Pouech
I don't quite understand what you mean. WCMD_ReadFile is called directly/indirectly in a lot of places, mostly around line-by-line reads. The question is not whether the compiler will inline this function (you can't know that for sure, think -O0, different compilers, etc.), but whether you want

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile

2011-10-04 Thread Frédéric Delanoy
2011/10/4 Juan Lang : >> OK but the purpose is to avoid checking the handle type for every line >> read. Granted, one could use '((DWORD_PTR)h) & 3 == 3' instead of >> GetConsoleMode or similar function. >> (there's currently code like "BOOL is_console = GetConsoleMode(...); >> ...; while WCMD_fget

Re: kernel32: Implement GetVolumePathName.

2011-10-04 Thread Charles Davis
On Oct 4, 2011, at 11:56 AM, Erich Hoover wrote: > On Tue, Oct 4, 2011 at 11:36 AM, Charles Davis > wrote: >> On Oct 4, 2011, at 9:32 AM, Erich Hoover wrote: >>> This patch implements GetVolumePathName by using the full folder >>> path and working backward until stat() returns a different devic

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile

2011-10-04 Thread Juan Lang
> OK but the purpose is to avoid checking the handle type for every line > read. Granted, one could use '((DWORD_PTR)h) & 3 == 3' instead of > GetConsoleMode or similar function. > (there's currently code like "BOOL is_console = GetConsoleMode(...); > ...; while WCMD_fgets(..., is_console)" and the

Re: kernel32: Implement GetVolumePathName.

2011-10-04 Thread Erich Hoover
On Tue, Oct 4, 2011 at 11:36 AM, Charles Davis wrote: > On Oct 4, 2011, at 9:32 AM, Erich Hoover wrote: > > This patch implements GetVolumePathName by using the full folder > > path and working backward until stat() returns a different device. > Surely there's a better way. Can't you do a statfs(2

Re: [2/2] gdi32/tests: fix MSVC build in bitmap.c

2011-10-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14695 Your paranoid android

Re: kernel32: Implement GetVolumePathName.

2011-10-04 Thread Charles Davis
On Oct 4, 2011, at 9:32 AM, Erich Hoover wrote: > This patch implements GetVolumePathName by using the full folder > path and working backward until stat() returns a different device. Surely there's a better way. Can't you do a statfs(2)/statvfs(2) (for example) to find out the FS root? (I know

Re: kernel32: Implement GetVolumePathName.

2011-10-04 Thread Dan Kegel
On Tue, Oct 4, 2011 at 8:58 AM, Erich Hoover wrote: >> Fails test here? >> ... >> >> 3 RtlDosPathNameToNtPathName_U+0x35c(dos_path="C:\windows\system32", >> ntpath=0x32fbb4, file_part=(nil), cd=(nil)) [dlls/ntdll/path.c:394] >>  4 GetVolumePathNameW+0x107(filename="C:\windows\system32", >> volumep

re: kernel32: Implement GetVolumePathName.

2011-10-04 Thread Dan Kegel
Fails test here? ../../../tools/runtest -q -P wine -M ntdll.dll -T ../../.. -p ntdll_test.exe.so file.c && touch file.ok Unhandled exception: page fault on read access to 0x00212b18 in 32-bit code (0x7bc47995). Backtrace: =>0 HEAP_CreateFreeBlock+0xbb(subheap=0x110014, ptr=0x122b48, size=0xeffd0)

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile

2011-10-04 Thread Frédéric Delanoy
2011/10/4 Eric Pouech : > > > Le 4 octobre 2011 13:40, Frédéric Delanoy a > écrit : >> >> 2011/10/4 Dan Kegel : >> > + * handle_type: type of hIn handle >> > + *              0 if file, 1 if console, anything else if unknown >> > (autodetect) >> > >> > I suspect you want an enum for that. >> >> We

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile

2011-10-04 Thread Eric Pouech
Le 4 octobre 2011 13:40, Frédéric Delanoy a écrit : > 2011/10/4 Dan Kegel : > > + * handle_type: type of hIn handle > > + * 0 if file, 1 if console, anything else if unknown > (autodetect) > > > > I suspect you want an enum for that. > > Well I thought about that, but found it a bit

Re: Vista/w2k8/w7 users, please test mmdevapi base render test

2011-10-04 Thread Henri Verbeet
On 4 October 2011 14:11, Paul Chitescu wrote: > On Tuesday 04 October 2011 02:40:49 pm joerg-cyril.hoe...@t-systems.com wrote: >> [...] >>  - sound card without capture (does "capture only" exist?) >> [...] > > Yes, there are at least some webcams with built-in USB microphone. > There are also e.g

Re: Regression by author list?

2011-10-04 Thread Reece Dunn
On 4 October 2011 13:29, Damjan Jovanovic wrote: > Hi > > Where do we find that list of regressions by author, that was in > Alexandre's keynote at Wineconf? http://source.winehq.org/regressions - Reece

Regression by author list?

2011-10-04 Thread Damjan Jovanovic
Hi Where do we find that list of regressions by author, that was in Alexandre's keynote at Wineconf? Thank you Damjan Jovanovic

Re: Vista/w2k8/w7 users, please test mmdevapi base render test

2011-10-04 Thread Paul Chitescu
On Tuesday 04 October 2011 02:40:49 pm joerg-cyril.hoe...@t-systems.com wrote: > [...] > - sound card without capture (does "capture only" exist?) > [...] Yes, there are at least some webcams with built-in USB microphone. Paul

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile

2011-10-04 Thread Dan Kegel
2011/10/4 Frédéric Delanoy : > Well I thought about that, but found it a bit overkill for such a > limited set of possible values. > Also, if I used sthg like > > enum CMD_HANDLE_TYPE { >   CMD_HT_FILE = 0, >   CMD_HT_CONSOLE = 1, >   CMD_HT_UNKNOWN = 2 > } > > , I'd have to add error checking for

Vista/w2k8/w7 users, please test mmdevapi base render test

2011-10-04 Thread Joerg-Cyril . Hoehle
Hi, please run on native machines my newest mmdevapi tests at http://testbot.winehq.org/JobDetails.pl?Key=14691 You'll find both patch and .exe there. I've split my former test in two. This is part one, without the GetPosition tests. WINETEST_DEBUG does not matter in part 1. wine mmdevapi_test.

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile

2011-10-04 Thread Frédéric Delanoy
2011/10/4 Dan Kegel : > + * handle_type: type of hIn handle > + *              0 if file, 1 if console, anything else if unknown > (autodetect) > > I suspect you want an enum for that. Well I thought about that, but found it a bit overkill for such a limited set of possible values. Also, if I use

Re: unable to compile wine from latest git

2011-10-04 Thread Vijay Kiran Kamuju
On Tue, Oct 4, 2011 at 3:52 AM, Austin English wrote: > On Mon, Oct 3, 2011 at 12:24, Vijay Kiran Kamuju wrote: >> Hi, >> >> This is on fedora 15. I have just downloaded the fresh git, and >> attempting the my first build on this system. > > Please bottom-post on wine mailing lists. > >> The sour