re: [PATCH 2/2] cmd: Handle truncation for console reads

2011-09-30 Thread Dan Kegel
What's motivating this change? Are you quite sure you know how ReadConsole behaves? I bet one could write a test for this that used SendInput to send keystrokes to be read by ReadConsole, and verify the end of line and end of buffer behavior...

re: [PATCH 1/2] cmd: Improve WCMD_fgets documentation

2011-09-30 Thread Dan Kegel
+ * We can't use the native f* functions because of the filename syntax differences + * between DOS and Unix. That doesn't belong in a function comment; it's an implementation detail that belongs, at most, inside the function.

Re: Favorite bug: deadlock preventing backtraces?

2011-09-30 Thread Dan Kegel
On Fri, Sep 30, 2011 at 1:29 AM, Maarten Lankhorst wrote: > On 09/29/2011 06:00 AM, Dan Kegel wrote: >> On one of my boxes, if I run winmm/midi.ok in a loop, it will >> eventually deadlock/crash >> ( http://bugs.winehq.org/show_bug.cgi?id=28388 ): > > I'm wondering if it's because of the lock in v

Re: Using ApiTrace to improve D3D/OpenGL performance

2011-09-30 Thread Emanuele Oriani
I guess if you can reproduce the same exact frames, then probably you can get real FPS your videocard might crunch, duplicated operation and maybe improve/exclude paths of code which slow down the 'real' rendering? Cheers On 30/09/11 21:15, Henri Verbeet wrote: On 30 September 2011 22:07, Ema

Re: Using ApiTrace to improve D3D/OpenGL performance

2011-09-30 Thread Henri Verbeet
On 30 September 2011 22:07, Emanuele Oriani wrote: > This might be useful to understand where some bottlenecks of wined3d might > be? > What do you think? > Yeah, I'm aware of apitrace, through Mesa. I haven't used it for debugging wined3d so far, but I probably will at some point. I'm not sure it

Using ApiTrace to improve D3D/OpenGL performance

2011-09-30 Thread Emanuele Oriani
Dear all, Just wanted to bring to your attention ApiTrace 2.0, http://zrusin.blogspot.com/2011/09/apitrace-20.html . Apparently this tool is quite fast and should allow to play back GL commands, to analyse performance and replay commands. This might be useful to understand where some bottleneck

design comments in code or in tests?

2011-09-30 Thread Joerg-Cyril . Hoehle
Hi, here's another one you WineConf folks may want to discuss. I've already expressed that there are not enough comments in mmdevapi's code. I thought about adding some, but wondered whether there's any value in using the header format that old code in Wine uses/used for automated doc. Generatio

Subject: [PATCH 1/2 (try2)] mmdevapi: Don't fail if dwChannelMask is not set correctly

2011-09-30 Thread Joerg-Cyril . Hoehle
Hi, Andrew Eikum writes: >(try2): Remove the test found by testbot. My Win7 Home VM passed that >test, so it seems we can expect any behavior. I object to the removal of the test like that. It should be replaced with a comment to explain that the behaviour of IsFormatSupported is very surprising

Re: winscard

2011-09-30 Thread Mounir IDRASSI
On 9/30/2011 4:47 PM, Marcus Meissner wrote: +State = pStates[i].dwEventState& (~SCARD_STATE_CHANGED); > +rgReaderStates[i].cbAtr = pStates[i].cbAtr; > +memcpy(rgReaderStates[i].rgbAtr, pStates[i].rgbAtr, MAX_ATR_SIZE); The "MAX_ATR

Re: user32: Prioritize focus for dialog owner on EndDialog.

2011-09-30 Thread Erich Hoover
On Fri, Sep 30, 2011 at 8:36 AM, Marvin wrote: > ... > === W7PROX64 (64 bit msg) === > Timeout > > === TEST64_W7SP1 (64 bit msg) === > Timeout It seems that these 64-bit tests have been failing for a while (it's clearly not related to my patch). Is anyone already looking into this issue? If not

Re: winscard

2011-09-30 Thread Marcus Meissner
On Fri, Sep 30, 2011 at 11:42:26AM +0200, Vincent Hardy wrote: > Hi all, > > Here are four patches that are a partial but functional > implementation of winscard. > > I installed "Belgian Electronic Identity Card MiddleWare" > (http://eid-mw.googlecode.com/files/BeidMW35-6995.msi) > > I tested w

Re: user32: Prioritize focus for dialog owner on EndDialog.

2011-09-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14644 Your paranoid android

Re: winscard

2011-09-30 Thread Jeff Latimer
On 30/09/11 19:42, Vincent Hardy wrote: > > Are these 4 patches good enough to be sent to wine-patch ? Vincent, normally you would start by adding tests that can confirm the same behaviour in Windows. If you can do that and get the test accepted then you are a long closer to get your patches accep

Re: winscard

2011-09-30 Thread Bruno Jesus
On Fri, Sep 30, 2011 at 06:42, Vincent Hardy wrote: > Hi all, > > Here are four patches that are a partial but functional implementation of > winscard. Congratulations =) > I installed "Belgian Electronic Identity Card MiddleWare" > (http://eid-mw.googlecode.com/files/BeidMW35-6995.msi) > > I te

Re: Buildbot status

2011-09-30 Thread Frédéric Delanoy
On Fri, Sep 30, 2011 at 00:33, Jerome Leclanche wrote: > On Thu, Sep 29, 2011 at 8:59 PM, Dan Kegel wrote: >> Do you object to Greg's existing testbot emails, too > > Kinda, yeah. I read wine-devel for developer comments, insights, > development about wine, etc. Bot emails feel kind of wrong here

winscard

2011-09-30 Thread Vincent Hardy
Hi all, Here are four patches that are a partial but functional implementation of winscard. I installed "Belgian Electronic Identity Card MiddleWare" (http://eid-mw.googlecode.com/files/BeidMW35-6995.msi) I tested winscard by starting beid35gui.exe and I can see my identity card data. Mo

Re: Favorite bug: deadlock preventing backtraces?

2011-09-30 Thread Maarten Lankhorst
Hey Dan, On 09/29/2011 06:00 AM, Dan Kegel wrote: > On one of my boxes, if I run winmm/midi.ok in a loop, it will > eventually deadlock/crash > ( http://bugs.winehq.org/show_bug.cgi?id=28388 ): > err:ntdll:RtlpWaitForCriticalSection section 0x110060 "heap.c: main > process heap section" wait timed