Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=14640
Your paranoid android
On Fri, 30 Sep 2011, Francois Gouget wrote:
> This is necessary because LastError may already be set to
> ERROR_INSUFFICIENT_BUFFER which would mislead the caller.
And of course the older versions of Windows (up to XP SP3!) don't reset
lasterror so the test bit of the patch cannot go in. I'd st
Contrary to what I said before, here is another attempt
for my CMD patch series.
Thanks to Frederic for reviewing this again, I made the
suggested changes.
Martin Wilck (5):
cmd/tests: add tests for command line parsing
cmd: use GetCommandline() rather than argv
cmd: improve parsing of quote
>> This will also be my last attempt to get this merged.
>
> Saying this is the best way to ensure that they won't be merged. Why
> would people spend time reviewing your code if you've already decided
> that you are not going to address the issues they find?
I also said that I'd address issues
On Thu, Sep 29, 2011 at 8:59 PM, Dan Kegel wrote:
> Do you object to Greg's existing testbot emails, too
Kinda, yeah. I read wine-devel for developer comments, insights,
development about wine, etc. Bot emails feel kind of wrong here; I
especially dislike WTB's because a lot of them are timeout-s
Don't commit this. Seems I forgot about top-down vs. bottom-up dibs.
On Thu, Sep 29, 2011 at 12:03 PM, Vincent Povirk wrote:
> For bug 55549.
>
On Thu, Sep 29, 2011 at 1:25 PM, Octavian Voicu
wrote:
> On Thu, Sep 29, 2011 at 12:59 PM, Dan Kegel wrote:
>> Do you object to Greg's existing testbot emails, too?
>
> They're annoying when they are spurious...
Yes. That's why I've been focusing on reducing the spurious email
rate, and won't t
Do you object to Greg's existing testbot emails, too?
Well before I flip the switch to turn on email to wine-devel,
I will have a nice history of those emails for viewing, so people
can judge the actual added noise level for themselves.
On Thu, Sep 29, 2011 at 12:20 PM, Jerome Leclanche wrote:
>
Hi,
I'd like to say a word for the effect interface in d3dx9_xx.dll, what's
already done and what's on the todo list.
The parser for binary effects works pretty much. It should nearly parse
the effect files completely, but it should fail on effect files which
contain functions (if anyone has
On Thu, Sep 29, 2011 at 12:59 PM, Dan Kegel wrote:
> Do you object to Greg's existing testbot emails, too?
They're annoying when they are spurious...
Octavian
How about just sending error emails to the wine-bots list, AJ and the
patch author? To be really honest I hate reading all the testbot
emails on wine-devel.
J
On Thu, Sep 29, 2011 at 7:43 PM, Dan Kegel wrote:
> The buildbot is alive and well and has been finding real
> problems of various sorts
The buildbot is alive and well and has been finding real
problems of various sorts roughly once a day for some time.
I'm not spending much time on it anymore, just watching
and tweaking occasionally.
The number of spurious failures is tapering off as I
slowly expand the blacklist and polish up the
2011/9/29 David Kiefer :
> A possible solution is to have MapColor call GetNearestIndex as a last
> resort instead. This both fixes the problem and results in acceptable
> performance.
Thanks for the tip. I've submitted a new patch which uses this
solution instead, and it works better.
2011/9/29
On Thu, Sep 29, 2011 at 12:57 PM, David Kiefer wrote:
> While this patch indeed fixes bug 2666, it also kills performance, at
> least with Age of Empires II.
> The frame rate in the menu for me is about one frame every three seconds
> and about 1 fps in-game.
>
> With the patch, the work previousl
A: 64b14c0ecdd13530a92ff636c451523a99253a0b (quartz: Start DirectSound
renderer as soon as possible.)
B: e786998daff4ad49521a4c9c39c172ddcdcad82a (dsound: Reimplement
rendering devices on mmdevapi.)
I've been working with the audio in Fallout 3 and Fallout New Vegas
for some time and I noticed a r
On 29 September 2011 15:03, Vitaliy Margolen wrote:
> I can think of few things can be implemented right away and see how it goes:
A lot of these seem like a great way to slow wine development down.
Honestly I think better investment in automated application testing
would be more helpful to the p
On 09/29/2011 02:11 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
The part you forgot is Linux (referring to kernel here) being the most
successful FOSS project, used on super computers, stock exchanges,
banks, etc. While Wine still in it's perpetual alpha-beta state,
limited user bas
2011/9/29 Frédéric Delanoy :
> Apparently a preliminary "make clean" seems to fix that issue. Sorry
> for the noise.
> Dan, did buildbot had those issues or does it do a 'make clean'?
The buildbot always starts with a clean directory, so it won't catch
problems like that :-(
While this patch indeed fixes bug 2666, it also kills performance, at
least with Age of Empires II.
The frame rate in the menu for me is about one frame every three seconds
and about 1 fps in-game.
With the patch, the work previously done by X11DRV_DIB_MapColor is now
done by X11DRV_DIB_GetNeares
Martin Wilck writes:
> This will also be my last attempt to get this merged.
Saying this is the best way to ensure that they won't be merged. Why
would people spend time reviewing your code if you've already decided
that you are not going to address the issues they find?
--
Alexandre Julliard
Dan Kegel wrote:
>Sadly, no backtrace follows
I've not had midi.ok crash on me, but now that you mention it, I've had
occasional crashes
of random reasons in various apps yet got no backtrace. I seem to remember
that there
have been times where backtraces would be produced more reliably.
So pe
2011/9/29 Frédéric Delanoy :
> I've also had some weird test failures running "make testclean && make
> test" for patch 2
> batch.c:302: Test succeeded inside todo block: unexpected char 0x0
> position -1 in line 18 (got '0 ', wanted '0@space@')
> batch.c:302: Test failed: unexpected char 0x65 posi
Michael Stefaniuc wrote:
>- We can directly motivate Andrew to fix those regressions "Oh,
>regressions still open? No dinner for you tonight!".
I still think Andrew deserves kudos for the vast amount of work he did.
mmdevapi, winmm, DSound, ALSA, OSS and CoreAudio are a lot for one person to
tack
Hi Martin,
I reviewed your patches and have found some (minor) issues:
* Your patches email line subjects should have '(try N') appended. I
*believe* this is needed for the project leader patches handling
scripts
You can just sed the "git format-patch" generated patches for instance
* PATCH 1/5
2011/9/29 Rico Schüller :
> 4. Implement each version on it's own, so each dll would get it's own code
> base. This way all differences could be handled correctly.
>
> Thus the only version which would really work 100% is #4, but due to not
> knowing the small differences and the huge amount of wor
Am 29.09.2011 00:13, schrieb Erich Hoover:
On Wed, Sep 28, 2011 at 2:45 PM, Alexandre Julliard wrote:
...
In general it's better to have the individual dlls handle their own
differences, instead of requiring d3dx9_36 to handle all the quirks of
20 different versions.
It sounded like we were on
Vitaliy Margolen writes:
> The part you forgot is Linux (referring to kernel here) being the most
> successful FOSS project, used on super computers, stock exchanges,
> banks, etc. While Wine still in it's perpetual alpha-beta state,
> limited user base, and not recommended for production use.
>
27 matches
Mail list logo
