Re: dpnet: fill the DPN_SP_CAPS structure in IDirectPlay8Peer_GetSPCaps with some sane values + tests

2011-09-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14486 Your paranoid android

Before you leave for wineconf...

2011-09-23 Thread Dan Kegel
... could you run http://kegel.com/wine/loop-fail.sh.txt overnight on the hardware you plan to bring, and email me the results? It creates a log file loop-fails.log which lists each test failure and how many loops it took to get there. Thanks!

Re: [PATCH] comdlg32: Initialize 2 RECT to 0 (Coverity)

2011-09-23 Thread Andrew Talbot
Marcus Meissner wrote: > Hi, > > If the filename and toolbar field are not present, we will be using > uninitialized RECTs, so initialize them. > > CID 5033, 5034 > > Ciao, Marcus > --- > dlls/comdlg32/itemdlg.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dl

Re: hhctrl.ocx: Don't show unimplemented buttons.

2011-09-23 Thread Owen Rudge
Could you point me to a link on this behavior? I'm pretty sure that many of these buttons send a signal that applications can hook into and override the default (do-nothing) behavior. The documentation for those specific values appears to be non-existent - the latest (as far as I'm aware) HTML

Re: hhctrl.ocx: Don't show unimplemented buttons.

2011-09-23 Thread Erich Hoover
> +    case IDTB_NOTES: > +    case IDTB_CONTENTS: > +    case IDTB_INDEX: > +    case IDTB_SEARCH: > +    case IDTB_HISTORY: > +    case IDTB_FAVORITES: > +    /* These are officially unimplemented as of the Windows 7 SDK */ > +    break; Could you point me

Re: [PATCH] comdlg32: Initialize 2 RECT to 0 (Coverity)

2011-09-23 Thread Alexandre Julliard
Marcus Meissner writes: > Hi, > > If the filename and toolbar field are not present, we will be using > uninitialized RECTs, so initialize them. It's not clear that 0 is much better. If there's really a possibility for these things to be missing the layout should take that into account. -- Ale

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3, resend)

2011-09-23 Thread Bruno Jesus
On Fri, Sep 23, 2011 at 07:50, Louis Lenders wrote: > Note: the 2 failing tests on test-bot that this patch will produce, are not > real failures as winnt and win2000 will not run the test because of missing > dpnet > > try 3: rewrote patch in a more straightforward  way > > this makes previousl

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3, resend)

2011-09-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14466 Your paranoid android

Re: mshtml: Add IHTMLCurrentStyle2/3/4 support

2011-09-23 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > diff --git a/dlls/mshtml/Makefile.in b/dlls/mshtml/Makefile.in > index 3933645..62a2d6f 100644 > --- a/dlls/mshtml/Makefile.in > +++ b/dlls/mshtml/Makefile.in > @@ -14,6 +14,7 @@ C_SRCS = \ > htmlbody.c \ > htmlcomment.c \ > htmlcurstyle.c \ > +

Re: RFC: Highlighting Fall-throughs

2011-09-23 Thread Michael Stefaniuc
Andrew Talbot wrote: > Andrew Talbot wrote: > >> Alex Bradbury wrote: >> >>> Marking fall through cases sounds reasonable on the face of it to me. >>> I question the necessity of adding 'unaudited' comments though. I'd >>> imagine lint or one of the more sophisticated static analysis tools >>> cou

Re: RFC: Highlighting Fall-throughs

2011-09-23 Thread Andrew Talbot
Andrew Talbot wrote: > Alex Bradbury wrote: > >> Marking fall through cases sounds reasonable on the face of it to me. >> I question the necessity of adding 'unaudited' comments though. I'd >> imagine lint or one of the more sophisticated static analysis tools >> could pretty easily give you a li