Fwd: 79194: [PATCH 10/13] vbscript: Added CreateObject implementation

2011-09-22 Thread Dan Kegel
Didn't build here, did you forget to add dependency on ole32? ccache gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogi

Re: IPv6 issue on TestBot?

2011-09-22 Thread Ben Peddell
On 22/09/2011 9:43 PM, Per Johansson wrote: > > 22 sep 2011 kl. 12:14 skrev Michael Stefaniuc: > >> Wow! /66? And that works? While the standard allows for that you "should >> use /64" which everybody and his dog read it as that is the only thing >> that needs to work and the only thing that get

Re: Tests failing on OSX

2011-09-22 Thread Per Johansson
22 sep 2011 kl. 11:49 skrev Francois Gouget: > On Wed, 21 Sep 2011, Charles Davis wrote: > [...] >>> I also wondered if Xquartz brings it's own X11 headers and libraries. I >>> haven't found any, so I'm still using /usr/X11/include and /usr/X11/bin. >> Xquartz puts its include and lib files in /

Re: RFC: Highlighting Fall-throughs

2011-09-22 Thread Andrew Talbot
Alex Bradbury wrote: > Marking fall through cases sounds reasonable on the face of it to me. > I question the necessity of adding 'unaudited' comments though. I'd > imagine lint or one of the more sophisticated static analysis tools > could pretty easily give you a list of cases with fall-through

Re: RFC: Highlighting Fall-throughs

2011-09-22 Thread Alex Bradbury
On 22 September 2011 22:20, Andrew Talbot wrote: > I therefore propose to mark each new point with two comments (maybe > separate, maybe combined): one to state that fall-through occurs and the > other to point out that the validity of this particular fall-through has not > yet been checked, maybe

RFC: Highlighting Fall-throughs

2011-09-22 Thread Andrew Talbot
Hi All, I am thinking of marking any unmarked places in switch statements where fall-through occurs. However, simply to do so would be to ignore the question of whether each fall-through is intentional or an oversight. I therefore propose to mark each new point with two comments (maybe separate,

Re: comctl32: Fix going to today with multiple calenders

2011-09-22 Thread Nikolay Sivov
On 9/23/2011 00:22, André Hentschel wrote: Am 22.09.2011 22:17, schrieb Nikolay Sivov: On 9/23/2011 00:03, André Hentschel wrote: --- dlls/comctl32/monthcal.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c ind

Re: comctl32: Fix going to today with multiple calenders

2011-09-22 Thread André Hentschel
Am 22.09.2011 22:17, schrieb Nikolay Sivov: > On 9/23/2011 00:03, André Hentschel wrote: >> --- >> dlls/comctl32/monthcal.c |4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) >> >> diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c >> index 5f8a36c..b330871 100644 >>

Re: comctl32: Fix going to today with multiple calenders

2011-09-22 Thread Nikolay Sivov
On 9/23/2011 00:03, André Hentschel wrote: --- dlls/comctl32/monthcal.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c index 5f8a36c..b330871 100644 --- a/dlls/comctl32/monthcal.c +++ b/dlls/comctl32/monthcal.c @@

Re: Fwd: 79194: [PATCH 10/13] vbscript: Added CreateObject implementation

2011-09-22 Thread Jacek Caban
On 9/22/11 6:47 PM, Dan Kegel wrote: Didn't build here, did you forget to add dependency on ole32? Yes, I did. Sorry about that and thanks for the report. Jacek

Re: IPv6 issue on TestBot?

2011-09-22 Thread Maarten Lankhorst
Hey, On 09/22/2011 04:54 PM, Michael Stefaniuc wrote: > Per Johansson wrote: >> 22 sep 2011 kl. 12:14 skrev Michael Stefaniuc: >> >>> Wow! /66? And that works? While the standard allows for that you "should >>> use /64" which everybody and his dog read it as that is the only thing >>> that needs t

Re: [PATCH 12/13] vbscript: Added CreateObject tests (based on jscript ActiveXObject tests)

2011-09-22 Thread Jacek Caban
=== WNT4WSSP6 (32 bit createobj) === createobj.c:734: Test failed: CoCreateInstance failed: 80040154 createobj: unhandled exception c005 at 00402A21 These tests fail because testbot runs them regardless that vbscript.dll is not present on the machine. Jacek

Re: IPv6 issue on TestBot?

2011-09-22 Thread Michael Stefaniuc
Per Johansson wrote: > 22 sep 2011 kl. 12:14 skrev Michael Stefaniuc: > >> Wow! /66? And that works? While the standard allows for that you "should >> use /64" which everybody and his dog read it as that is the only thing >> that needs to work and the only thing that get tested. IPv6 brings back >

Re: Tests failing on OSX

2011-09-22 Thread Ken Thomases
On Sep 22, 2011, at 4:49 AM, Francois Gouget wrote: > On Wed, 21 Sep 2011, Charles Davis wrote: > [...] >>> I also wondered if Xquartz brings it's own X11 headers and libraries. I >>> haven't found any, so I'm still using /usr/X11/include and /usr/X11/bin. >> Xquartz puts its include and lib file

Re: [PATCH 12/13] vbscript: Added CreateObject tests (based on jscript ActiveXObject tests)

2011-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14455 Your paranoid android

Re: [PATCH 07/13] vbscript: Added exit for statement support

2011-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14454 Your paranoid android

Re: [PATCH 06/13] vbscript: Added for..in statement tests

2011-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14453 Your paranoid android

crypt32(1/2): Test CertCreateCertificateContext, and fix an error code in a failure case

2011-09-22 Thread Juan Lang
--Juan From 544fb76b6da191c8e5c665be11357706acae9be0 Mon Sep 17 00:00:00 2001 From: Juan Lang Date: Thu, 22 Sep 2011 05:20:50 -0700 Subject: [PATCH 17/18] Test CertCreateCertificateContext, and fix an error code in a failure case --- dlls/crypt32/cert.c |6 + dlls/crypt32/tests/cer

Re: IPv6 issue on TestBot?

2011-09-22 Thread Per Johansson
22 sep 2011 kl. 12:14 skrev Michael Stefaniuc: > Wow! /66? And that works? While the standard allows for that you "should > use /64" which everybody and his dog read it as that is the only thing > that needs to work and the only thing that get tested. IPv6 brings back > the class-full thinking wh

Re: Remove the legalese from start.exe?

2011-09-22 Thread Henri Verbeet
On 22 September 2011 13:00, Francois Gouget wrote: > I don't see cp, ls, gcc or any other standard and especially GNU command > line tools show a copyright notice in their usage message or have a > command line option to show one. So I don't think that's a GPL/LGPL --version shows a short copyrigh

Re: IPv6 issue on TestBot?

2011-09-22 Thread Ben Peddell
On 22/09/2011 7:56 PM, Maarten Lankhorst wrote: > Hey, > > Testbot has 2 ips assigned to it: > > inet6 addr: 2001:888:2000:38:1000::1/66 Scope:Global > inet6 addr: 2001:888:2000:38:1000::2/66 Scope:Global > > Does the ::1 work? > > ~Maarten > Nope. # traceroute -6 -f 11 -

Re: [PATCH 3/5] winealsa.drv: Use the plughw instead of the hw interface for openening devices.

2011-09-22 Thread Henri Verbeet
On 22 September 2011 11:40, wrote: > How does your alsa_try_open interact with devices that clang onto the > underlying HW resource for several seconds?  (PA does this) > That's patch 2/5, but that aside. It should behave pretty much the same as the existing code for opening devices. It just test

Re: Remove the legalese from start.exe?

2011-09-22 Thread Francois Gouget
On Wed, 21 Sep 2011, Dan Kegel wrote: > When I wrote that bit, I was simply trying to follow the letter > of the LGPL. I'm ok with any solution that does that. I don't see cp, ls, gcc or any other standard and especially GNU command line tools show a copyright notice in their usage message or h

Re: winetest: Missing test.avi and msrle.avi files

2011-09-22 Thread Francois Gouget
On Wed, 21 Sep 2011, Austin English wrote: [...] > http://www.winehq.org/pipermail/wine-devel/2008-October/070098.html Thanks. I have sent a patch to make the status of msrle.avi clearer (hopefully). > >  * quartz:avisplitter needs a test.avi file: > >   > > http://source.winehq.org/git/wine.g

Re: Tests failing on OSX

2011-09-22 Thread Francois Gouget
On Wed, 21 Sep 2011, Francois Gouget wrote: [...] > A related question is whether it is actually known to have an impact on > the test results or not. Again, looking at the ws_32:sock results I saw > no difference, even over multiple runs. Looking at the full results of a > pair of runs on winet

Re: IPv6 issue on TestBot?

2011-09-22 Thread Michael Stefaniuc
Maarten Lankhorst wrote: > Hey, > > On 09/22/2011 11:25 AM, Ben Peddell wrote: >> On 22/09/2011 6:24 PM, Maarten Lankhorst wrote: >>> Hey, >>> >>> On 09/14/2011 12:47 PM, Francois Gouget wrote: Connecting to https://testbot.winehq.org/ over IPv6 hangs for ages :-( This makes accessing it

Re: IPv6 issue on TestBot?

2011-09-22 Thread Maarten Lankhorst
Hey, On 09/22/2011 11:25 AM, Ben Peddell wrote: > On 22/09/2011 6:24 PM, Maarten Lankhorst wrote: >> Hey, >> >> On 09/14/2011 12:47 PM, Francois Gouget wrote: >>> Connecting to https://testbot.winehq.org/ over IPv6 hangs for ages :-( >>> This makes accessing it from my desktop very annoying. >>> >

Re: Tests failing on OSX

2011-09-22 Thread Francois Gouget
On Wed, 21 Sep 2011, Charles Davis wrote: [...] > > I also wondered if Xquartz brings it's own X11 headers and libraries. I > > haven't found any, so I'm still using /usr/X11/include and /usr/X11/bin. > Xquartz puts its include and lib files in /opt/X11/include and /opt/X11/lib, > respectively.

[PATCH 3/5] winealsa.drv: Use the plughw instead of the hw interface for openening devices.

2011-09-22 Thread Joerg-Cyril . Hoehle
Henri Verbeet [becoming an audio expert now?] wrote: >The default device may for example be a set of USB speakers or an USB >microphone, in which case you'd have just an output or just an input >respectively. My testcase has been to hack mmdevdrv.c and replace "default" with "plug:dmix" or "dmix"

Re: IPv6 issue on TestBot?

2011-09-22 Thread Ben Peddell
On 22/09/2011 6:24 PM, Maarten Lankhorst wrote: > Hey, > > On 09/14/2011 12:47 PM, Francois Gouget wrote: >> Connecting to https://testbot.winehq.org/ over IPv6 hangs for ages :-( >> This makes accessing it from my desktop very annoying. >> >> $ time wget -4 --quiet http://testbot.winehq.org/ >>

Re: IPv6 issue on TestBot?

2011-09-22 Thread Francois Gouget
On Thu, 22 Sep 2011, Maarten Lankhorst wrote: [...] > > Could this be a firewall problem? (testbot exposing an IPv6 address but > > the firewall dropping any IPv6 packets) > > > > > > In the mean time I'm going to use my laptop which is still IPv4 only > > :-/ > That ipv6 address is set on testbo

Re: IPv6 issue on TestBot?

2011-09-22 Thread Maarten Lankhorst
Hey, On 09/14/2011 12:47 PM, Francois Gouget wrote: > Connecting to https://testbot.winehq.org/ over IPv6 hangs for ages :-( > This makes accessing it from my desktop very annoying. > > $ time wget -4 --quiet http://testbot.winehq.org/ > real 0m2.150s > user 0m0.000s > sys 0m0.000s > > $ time