Re: po: Update Russian translation

2011-09-20 Thread Alexander Lakhin
Hello, Nikolay. 20.09.2011 23:00, Nikolay Sivov пишет: On 9/20/2011 22:33, Alexander Lakhin wrote: English strings removed, partial translation fixed too. #: crypt32.rc:53 cryptdlg.rc:31 -#, fuzzy msgctxt "Certification Practice Statement" msgid "CPS" -msgstr "CPS" +msgstr "РУЦ" What does t

Re: [PATCH 2/9] cmd: use GetCommandline() rather than argv

2011-09-20 Thread Martin Wilck
On 09/20/2011 09:52 PM, Dan Kegel wrote: > This happened even if I applied your whole series. But the log you posted can't be from the full series (tests are marked as @todo_wine@ which are solved after applying all patches). Could you please send me the output of wine cmd /c test_cmdline.cmd, w

Re: [PATCH 1/9] cmd/tests: add tests for command line parsing

2011-09-20 Thread Martin Wilck
On 09/20/2011 01:24 AM, Frédéric Delanoy wrote: > You might want to do a single "@echo off" at the start of the .cmd file. > Echoing every command in the .exp isn't very helpful: you don't want > to replicate the .cmd contents in the .exp file. I did that on purpose. It makes figuring out problem

Re: Tests failing on OSX

2011-09-20 Thread Charles Davis
On Sep 20, 2011, at 3:11 PM, Stefan Dösinger wrote: >> gdi32/dc >> user32/monitor > No Xvidmode support, so Get/SetDeviceGammaRamp fail. There's a win_skip for > that already. Should we change it to skip(), or ignore it until we have a > quartz driver? > User32/monitor also fails because it can'

Tests failing on OSX

2011-09-20 Thread Stefan Dösinger
Hi, I'm attempting to set up a OSX testbot and I'm currently trying to get as many tests to work as possible. The following is a list of tests that fail currently. I'm hoping for comments if anybody knows more about them: (This is a 2006-era iMac, OSX 10.6, using the stock X server) > dinput8/

Re: [PATCH 1/2] include: add a generic class factory template

2011-09-20 Thread Octavian Voicu
On Tue, Sep 20, 2011 at 4:05 PM, Bernhard Loos wrote: > +#define __WINE_GENERIC_CF_DLL_MAIN_CONTENT \ > +return __WINE_PS_ENTRY(DllMain(hInstDll, fdwReason, lpv)); I think __WINE_PS_ENTRY needs only be applied to DllMain, not its argument, so second line should read: +

Re: [PATCH 2/9] cmd: use GetCommandline() rather than argv

2011-09-20 Thread Dan Kegel
On Tue, Sep 20, 2011 at 1:17 PM, Martin Wilck wrote: >> on my i7 machine, your patch series fails every time for me when run >> normally.  Here's the log: > > Did you apply only this one, or also 3/9 which is supposed to fix the > test results? Frédéric already told me that I should have submitted

Re: [PATCH 2/9] cmd: use GetCommandline() rather than argv

2011-09-20 Thread Martin Wilck
Hi Dan, > on my i7 machine, your patch series fails every time for me when run > normally. Here's the log: Did you apply only this one, or also 3/9 which is supposed to fix the test results? Frédéric already told me that I should have submitted the patches in one. Martin > > ]] ../../../tool

Re: Daily builds of latest Git now available as Ubuntu packages

2011-09-20 Thread Qian Hong
On Wed, Sep 21, 2011 at 2:48 AM, Octavian Voicu wrote: > > I'm guessing daily builds are done after daily commits, so you could > use the build id (which is just a prefix of the last commit id) from > here [1]. > > In your case, it's probably 9b729bb1b348 - 12-Sep-2011 15:45. > > Octavian > > [1]

Re: po: Update Russian translation

2011-09-20 Thread Nikolay Sivov
On 9/20/2011 22:33, Alexander Lakhin wrote: English strings removed, partial translation fixed too. #: crypt32.rc:53 cryptdlg.rc:31 -#, fuzzy msgctxt "Certification Practice Statement" msgid "CPS" -msgstr "CPS" +msgstr "РУЦ" What does that mean exactly? I didn't find such abbreviation anywher

Re: Daily builds of latest Git now available as Ubuntu packages

2011-09-20 Thread Austin English
On Tue, Sep 20, 2011 at 11:48, Octavian Voicu wrote: > On Tue, Sep 20, 2011 at 9:27 PM, Qian Hong wrote: >> Is there any good ways to get the git-describe-like version number >> from the daily build ppa version number? >> That's useful while running a regression test. For example, I'd like >> to

Re: Daily builds of latest Git now available as Ubuntu packages

2011-09-20 Thread Octavian Voicu
On Tue, Sep 20, 2011 at 9:27 PM, Qian Hong wrote: > Is there any good ways to get the git-describe-like version number > from the daily build ppa version number? > That's useful while running a regression test. For example, I'd like > to know exactly what is wine1.3_1.3.28+daily-20110912 > in http

Re: Daily builds of latest Git now available as Ubuntu packages

2011-09-20 Thread Qian Hong
On Thu, Sep 1, 2011 at 8:43 PM, Scott Ritchie wrote: > Unfortunately I have to use Launchpad Recipe's supported substitution > variables here, and while they do have one for the latest git-tag if I > build locally this doesn't work on launchpad itself.  The reason for > this is that the launchpad

Re: [PATCH 1/3] shell32: Don't call SendMessage inside critical section

2011-09-20 Thread Alexandre Julliard
Piotr Caban writes: > @@ -355,24 +351,34 @@ void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, > LPCVOID dwItem1, LPCVOID > if( !notify ) > continue; > > -ptr->pidlSignaled = ILClone(Pidls[0]); > +item = SHAlloc(sizeof(struct notification_recipients));

re: [PATCH 2/9] cmd: use GetCommandline() rather than argv

2011-09-20 Thread Dan Kegel
Hi Martin, on my i7 machine, your patch series fails every time for me when run normally. Here's the log: ]] ../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p cmd.exe_test.exe.so batch.c && touch batch.ok ]] ... ]] wine: cannot find L"C:\\windows\\system32\\tell;1;;2.exe" ]] batch.c:301

Re: [2/2] shell32: Be safe against removal of entries in SHChangeNotify

2011-09-20 Thread Piotr Caban
Hi, On 09/19/11 20:52, André Hentschel wrote: @@ -325,7 +325,7 @@ void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID dwItem1, LPCVOID EnterCriticalSection(&SHELL32_ChangenotifyCS); /* loop through the list */ -LIST_FOR_EACH_ENTRY( ptr,¬ifications, NOTIFICATIONLIST,

Re: [PATCH 4/5] vbscript: Added more tests

2011-09-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14413 Your paranoid android

Re: [PATCH 3/5] vbscript: Added support for short if statements

2011-09-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14412 Your paranoid android

Re: [PATCH 2/5] vbscript: Added support for rem statement-like comments

2011-09-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14411 Your paranoid android

Re: [PATCH 1/5] vbscript: Added support for ':' as statement separator

2011-09-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14410 Your paranoid android

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests

2011-09-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests

2011-09-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests

2011-09-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android

Re: [PATCH 1/3 try2] wshom.ocx: Added WshShell class factory implementation

2011-09-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14406 Your paranoid android

Re: [PATCH 1/3] wshom.ocx: Added WshShell class factory implementation

2011-09-20 Thread Jacek Caban
On 09/19/11 20:13, Dan Kegel wrote: build failed here? ../../tools/makedep -C. -S../.. -T../.. shell.c wshom_main.c wshom.rc wshom.idl wshom.idl wshom.tlb wshom_private.h: No such file or directory wshom_private.h was first included from shell.c:19 make[1]: *** [depend] Error 1 ma

Re: msi: Print the string and not the pointer in a TRACE.

2011-09-20 Thread Hans Leidekker
On Tue, 2011-09-20 at 10:51 +0200, Michael Stefaniuc wrote: > Hans Leidekker wrote: > > On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote: > >> @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, > >> LPCSTR szFolder, > >> awstring str; > >> UINT r; > >> > >

Re: msi: Print the string and not the pointer in a TRACE.

2011-09-20 Thread Michael Stefaniuc
Hans Leidekker wrote: > On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote: >> @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, >> LPCSTR szFolder, >> awstring str; >> UINT r; >> >> -TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), >>

Re: [1/2] d3dx9: Implemented D3DXWeldVertices.

2011-09-20 Thread Michael Mc Donnell
Hi Alexandre My D3DXWeldVertices patch set (see [1] and [2]) scrolled of the patches list . It has been reviewed by Stefan and others on wine-devel, so it should be ok. Do you see anything wrong with it? Should I resend it? Thanks, Michael Mc Donnell [1] http://www.winehq.org/pipermail/wine-patc