Re: [PATCH 1/9] cmd/tests: add tests for command line parsing

2011-09-19 Thread Frédéric Delanoy
2011/9/20 Frédéric Delanoy : > On Tue, Sep 20, 2011 at 01:51, Martin Wilck wrote: >> This patch adds some tests for command line parsing and treatment >> of quotes and special characters in the command line and in program >> names and parameters. The .exp file was created using Win XP. >> --- >>  

Re: [PATCH 1/9] cmd/tests: add tests for command line parsing

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14396 Your paranoid android

Re: [PATCH 3/9] cmd/tests: fix TODOs in test output (GetCommandline())

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14397 Your paranoid android

Re: [PATCH 5/9] cmd/tests: fix TODOs in test output (quotes)

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14398 Your paranoid android

Re: [PATCH 7/9] cmd/tests: adapt TODOs in test output (special characters)

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14399 Your paranoid android

Re: [PATCH 9/9] cmd/tests: adapt TODOs in test output (parameter passing)

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14400 Your paranoid android

Re: [PATCH 3/9] cmd/tests: fix TODOs in test output (GetCommandline())

2011-09-19 Thread Frédéric Delanoy
On Tue, Sep 20, 2011 at 01:51, Martin Wilck wrote: > Fix output after "cmd: use GetCommandline() rather than argv" patch. > This also fixes the test case where Wine would hang. Having path P1 fixing issue and P2 changing .cmd/.exp is wrong. Testsuite has to pass after every patch committed. The

Re: [PATCH 1/9] cmd/tests: add tests for command line parsing

2011-09-19 Thread Frédéric Delanoy
On Tue, Sep 20, 2011 at 01:51, Martin Wilck wrote: > This patch adds some tests for command line parsing and treatment > of quotes and special characters in the command line and in program > names and parameters. The .exp file was created using Win XP. > --- >  programs/cmd/tests/rsrc.rc          

Re: msi: Print the string and not the pointer in a TRACE.

2011-09-19 Thread Hans Leidekker
On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote: > @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, LPCSTR > szFolder, > awstring str; > UINT r; > > -TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), > pcchPathBuf); > +TRACE("%s

re: [PATCH 1/3] wshom.ocx: Added WshShell class factory implementation

2011-09-19 Thread Dan Kegel
build failed here? ../../tools/makedep -C. -S../.. -T../.. shell.c wshom_main.c wshom.rc wshom.idl wshom.idl wshom.tlb wshom_private.h: No such file or directory wshom_private.h was first included from shell.c:19 make[1]: *** [depend] Error 1 make[1]: Leaving directory `/home/bob/win

Re: Something's rotten in git today...

2011-09-19 Thread Jérôme Gardou
Le 19/09/2011 14:35, Bernhard Loos a écrit : This patch should fix the problem: http://source.winehq.org/patches/data/79042 I switched it back to use nonoverlapped named pipe functions, as only the ConnectNamedPipe operation actually needs the overlapped mode, so I used a dedicated thread for

Re: Old imagehlp patches

2011-09-19 Thread Henri Verbeet
On 19 September 2011 03:37, Juan Lang wrote: > weren't good enough in 2004-5, they're not any better now.  You'd want > someone who has an active interest in this area to have a go at them, > I believe, unless you can convince the original author to take them up > again. AFAIK we're still not acce

Re: Something's rotten in git today...

2011-09-19 Thread Bernhard Loos
On Thu, Sep 15, 2011 at 8:55 PM, Bernhard Loos wrote: > On Thu, Sep 15, 2011 at 8:33 PM, Dan Kegel wrote: >> On Thu, Sep 15, 2011 at 11:13 AM, Bernhard Loos >> wrote: > It might be just me, but I've seen five very strange test failures > today out of about 30 build/test runs. > Has a

Re: Old imagehlp patches

2011-09-19 Thread Thomas Kluyver
On 19 September 2011 02:37, Juan Lang wrote: > I wouldn't > hold your breath expecting these patches to go in as-is: if they > weren't good enough in 2004-5, they're not any better now. You'd want > someone who has an active interest in this area to have a go at them, > I believe, unless you ca

Re: comctl32: Don't crash when getting a bad image list handle. (try 2)

2011-09-19 Thread Nikolay Sivov
On 9/19/2011 20:45, Chris Robinson wrote: On Monday, September 19, 2011 4:09:29 PM Francois Gouget wrote: I prefer this construct as using IsBadReadPtr() would introduce a race in is_valid(). Of course calling is_valid() is in itself racy anyway. So I don't mind switching over if that's preferre

Re: comctl32: Don't crash when getting a bad image list handle. (try 2)

2011-09-19 Thread Chris Robinson
On Monday, September 19, 2011 4:09:29 PM Francois Gouget wrote: > I prefer this construct as using IsBadReadPtr() would introduce a race > in is_valid(). Of course calling is_valid() is in itself racy anyway. So > I don't mind switching over if that's preferred (the code would have > fewer lines).

re: mscoree: Add .Net debugging interfaces

2011-09-19 Thread Dan Kegel
Doesn't apply here: $ wget http://source.winehq.org/patches/data/79041 $ git reset --hard origin $ patch -p1 < 79041 patching file include/Makefile.in patching file include/cordebug.idl patch: malformed patch at line 998: -- $ git reset --hard origin $ git apply 79041 79041:99: trailing whit

Re: Ole16 to Ole32 mapping

2011-09-19 Thread Marcus Meissner
On Mon, Sep 19, 2011 at 10:00:48AM -0300, Bruno Jesus wrote: > Hi, I would like some advice about Ole function redirection. The > winsock16 dll maps some operations to ws2_32 dll, I thought I could do > the same with Ole16disp to Oleaut32. For example the function > SAFEARRAYALLOCDESCRIPTOR in Ole1

Re: comctl32: Don't crash when getting a bad image list handle. (try 2)

2011-09-19 Thread Francois Gouget
On Mon, 19 Sep 2011, Nikolay Sivov wrote: [...] > > static inline BOOL is_valid(HIMAGELIST himl) > > { > > -return himl&& himl->lpVtbl ==&ImageListImpl_Vtbl; > > +BOOL valid; > > +__TRY > > +{ > > +valid = himl&& himl->lpVtbl ==&ImageListImpl_Vtbl; > > +} > > +

Re: [po]updated korean resource(2011-09-19)

2011-09-19 Thread Francois Gouget
msgstr "" +"Wine is free software; you can redistribute it and/or modify it under the " +"terms of the GNU Lesser General Public License as published by the Free " +"Software Foundation; either version 2.1 of the License, or (at your option) " +"any later version.\n" +"\n" +"Wine is distributed i

Re: comctl32: Don't crash when getting a bad image list handle. (try 2)

2011-09-19 Thread Nikolay Sivov
On 9/19/2011 17:32, Francois Gouget wrote: --- Don't return from inside the block this time. dlls/comctl32/imagelist.c | 13 - dlls/comctl32/tests/imagelist.c | 17 +++-- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/dlls/comctl32/imagelis

Re: [PATCH 16/17] vbscript: Added interp_me implementation

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14384 Your paranoid android

Re: Ole16 to Ole32 mapping

2011-09-19 Thread Damjan Jovanovic
On Mon, Sep 19, 2011 at 3:00 PM, Bruno Jesus <00cp...@gmail.com> wrote: > Hi, I would like some advice about Ole function redirection. The > winsock16 dll maps some operations to ws2_32 dll, I thought I could do > the same with Ole16disp to Oleaut32. For example the function > SAFEARRAYALLOCDESCRIP

Ole16 to Ole32 mapping

2011-09-19 Thread Bruno Jesus
Hi, I would like some advice about Ole function redirection. The winsock16 dll maps some operations to ws2_32 dll, I thought I could do the same with Ole16disp to Oleaut32. For example the function SAFEARRAYALLOCDESCRIPTOR in Ole16disp have a similar counterpart named SafeArrayAllocDescriptor in Ol

Re: [PATCH 14/17] vbscript: Added support for SCRIPTITEM_ISVISIBLE named items

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14383 Your paranoid android

Re: [PATCH 12/17] vbscript: Added error object stub implementation

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14382 Your paranoid android

Re: [PATCH 06/17] vbscript: Added is expression implementation

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14380 Your paranoid android

Re: [PATCH 05/17] vbscript: Added interp_lteq implementation

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14379 Your paranoid android

Re: vbscript: Make vbdisp_get_id() static.

2011-09-19 Thread Jacek Caban
Hi Francois, On 09/18/11 19:37, Francois Gouget wrote: --- dlls/vbscript/vbdisp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/vbscript/vbdisp.c b/dlls/vbscript/vbdisp.c index 14fb8b0..db1c864 100644 --- a/dlls/vbscript/vbdisp.c +++ b/dlls/vbscript/vbdisp.c @

Re: [PATCH 04/17] vbscript: Added interp_lt implementation

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14378 Your paranoid android

Re: [PATCH 03/17] vbscript: Added interp_gt implementation

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14377 Your paranoid android

Re: [PATCH 02/17] vbscript: Added interp_gteq implementation

2011-09-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14376 Your paranoid android

Re: comctl32: Don't crash when getting a bad image list handle.

2011-09-19 Thread Alexandre Julliard
Francois Gouget writes: > @@ -3587,7 +3588,15 @@ static const IImageListVtbl ImageListImpl_Vtbl = { > > static inline BOOL is_valid(HIMAGELIST himl) > { > -return himl && himl->lpVtbl == &ImageListImpl_Vtbl; > +__TRY > +{ > +return himl && himl->lpVtbl == &ImageListImpl_Vt