Re: Old imagehlp patches

2011-09-18 Thread Juan Lang
Hi Thomas, wrong mailing list. You wanted wine-devel instead (now cc'ed.) > I don't know about wine development, but are these patches still likely to > work? What would need to happen for them to be merged in? To your first question, try them and see! To your second question, a lot. They're m

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3)

2011-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14371 Your paranoid android

Re: ieframe/tests: Skip some tests on Windows if WebBrowser is not supported.

2011-09-18 Thread Francois Gouget
On Fri, 16 Sep 2011, Jacek Caban wrote: [...] > IEs older than 7 had WebBrowser control implemented in shdocvw.dll. We surely > don't want to run tests on anything older than IE6. IE6 results very little > value in this case, so I consider DLL presence check as a nice way of skipping > tests on too

re: msxml3: Fix printing NULL strings

2011-09-18 Thread Francois Gouget
On Sun, 18 Sep 2011, Dan Kegel wrote: [...] > $ ccache gcc -c -I. -I. -I../../include -I../../include > -I/usr/include/libxml2 -I/usr/include/libxml2 -D__WINESRC__ > -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing > -Wdeclaration-after-statement -Wempty-body -Wstrict-prot

Re: quartz/tests: Skip some tests if not allowed to register filters.

2011-09-18 Thread Francois Gouget
On Sun, 18 Sep 2011, Marvin wrote: [...] > === WNT4WSSP6 (32 bit filtermapper) === > filtermapper.c:93: Test failed: CoCreateInstance failed with 80040154 > filtermapper.c:230: Test failed: CoCreateInstance failed with 80040154 > filtermapper.c:344: Test failed: CoCreateInstance failed with 8004015

Re: shell32: Don't dereference NULL pointers when tracing.

2011-09-18 Thread Octavian Voicu
On Sun, Sep 18, 2011 at 8:37 PM, Francois Gouget wrote: > +    TRACE("-- vmode %#x, flags %#x", view_params->pfs->ViewMode, > view_params->pfs->fFlags); > +    if (view_params->prcView) > +        TRACE(", left %d, top %d, right %d, bottom %d", > view_params->prcView->left, > +              view

Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)

2011-09-18 Thread Octavian Voicu
2011/9/18 Dan Kegel : > 2011/9/18 Dan Kegel : >> Don't let this one languish - it makes a huge difference for me! > > I should mention: with your latest additions to the cmd tests, > time to run the cmd tests is starting to go off the cliff, > and is now above four minutes... but with your efficien

re: msxml3: Fix printing NULL strings

2011-09-18 Thread Dan Kegel
Hi Francois, your patch has a signedness problem which makes -Werror unhappy. (We could disable signedness warnings, but since we don't currently have any, it's nice to keep them out of the tree...) Here's the log from the buildbot: $ ccache gcc -c -I. -I. -I../../include -I../../include -I/usr/

Re: Unimplemented function?

2011-09-18 Thread Luis Carlos Busquets Pérez
Thanks Maarten. Your tip solved the issue. I wonder in any case if this should make rethink wine strategy and instead of forwarding funcs to a MS-name dll, depending on the API wine dlls could b e created. e.g. msvcrt.dll, msvr71.dll, msvcr80.dll, msvcr90.dll, ... --> winecr Other APIs could al

Re: quartz/tests: Skip some tests if not allowed to register filters.

2011-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14367 Your paranoid android

Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)

2011-09-18 Thread Frédéric Delanoy
2011/9/18 Dan Kegel : > 2011/9/18 Dan Kegel : >> Don't let this one languish - it makes a huge difference for me! > > I should mention: with your latest additions to the cmd tests, > time to run the cmd tests is starting to go off the cliff, > and is now above four minutes... but with your efficien

Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)

2011-09-18 Thread Dan Kegel
2011/9/18 Dan Kegel : > Don't let this one languish - it makes a huge difference for me! I should mention: with your latest additions to the cmd tests, time to run the cmd tests is starting to go off the cliff, and is now above four minutes... but with your efficiency patch, it only takes four sec

Update on testbot

2011-09-18 Thread Maarten Lankhorst
Hi all, I moved the windows 7 x64 vm with sp1 applied to the base pool now. This means that all submitted patches will be run on that vm as well. The original win7 vm is still available under its own name. Since all tests pass on that according to winehq tests I'm keeping it in the base pool. I ho

Creating register Resource.

2011-09-18 Thread Alistair Leslie-Hughes
Hi, I'm attempting to create a RES file from the xmlparser.idl file. After I modify the Makefile with IDL_R_SRCS = xmlparser.idl The .res file is created, but no register information is generated. Have I missed something? Best Regards Alistair Leslie-Hughes

Re: [PATCH 17/19] vbscript: Added support for exit do statement

2011-09-18 Thread Octavian Voicu
On Fri, Sep 16, 2011 at 2:30 PM, Jacek Caban wrote: > --- a/dlls/vbscript/compile.c > +++ b/dlls/vbscript/compile.c > static HRESULT compile_while_statement(compile_ctx_t *ctx, while_statement_t > *stat) > { > -unsigned start_addr; > +unsigned start_addr, prev_label; ... > +if(stat-

Re: Unimplemented function?

2011-09-18 Thread Maarten Lankhorst
Hey, On 09/18/2011 12:52 PM, Luis Carlos Busquets Pérez wrote: > It seems that there is a regression in wine 1.3.28. Before bi-secting, I woul > dlike to understand how that can happen. Apparently PlaChessV5.exe crashes > due to: > > wine: Call from 0x68215ca8 to unimplemented function msvcrt.dl

Unimplemented function?

2011-09-18 Thread Luis Carlos Busquets Pérez
It seems that there is a regression in wine 1.3.28. Before bi-secting, I woul dlike to understand how that can happen. Apparently PlaChessV5.exe crashes due to: wine: Call from 0x68215ca8 to unimplemented function msvcrt.dll._snwprintf_s, aborting but when I look at the spec file, the funct