Re: notepad: Die if we get an unknown encoding name in load_encoding_name().

2011-09-11 Thread Francois Gouget
On Mon, 12 Sep 2011, Octavian Voicu wrote: > On Mon, Sep 12, 2011 at 12:22 AM, Francois Gouget wrote: > > -            assert(0 && "bad encoding in load_encoding_name"); > > +            assert("bad encoding in load_encoding_name"); > > Hello, > > assert() is a debug macro which generates some

re: [5/5] ddraw: Use a Z format suported by the driver in the visual test

2011-09-11 Thread Dan Kegel
Fails to compile on gcc-2.95 here: visual.c: In function `enum_z_fmt': visual.c:61: request for member `u1' in something not a structure or union visual.c:61: request for member `u1' in something not a structure or union make[1]: *** [visual.o] Error 1 make: *** [dlls/ddraw/tests] Error 2 --

re: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames

2011-09-11 Thread Dan Kegel
Hi Frédéric, fails a test here: ../../../tools/runtest -q -P wine -M cryptnet.dll -T ../../.. -p cryptnet_test.exe.so cryptnet.c && touch cryptnet.ok fixme:cryptnet:CryptGetObjectUrl unimplemented for 0 cryptnet.c:444: Test failed: Expected ERROR_FILE_NOT_FOUND or ERROR_PATH_NOT_FOUND, got 123 -

Re: notepad: Die if we get an unknown encoding name in load_encoding_name().

2011-09-11 Thread Octavian Voicu
On Mon, Sep 12, 2011 at 12:22 AM, Francois Gouget wrote: > -            assert(0 && "bad encoding in load_encoding_name"); > +            assert("bad encoding in load_encoding_name"); Hello, assert() is a debug macro which generates some code such that, during runtime: if the argument is non-zer

Re: [1/3] msxml3: Add xmlparser interfaces

2011-09-11 Thread Francois Gouget
On Sun, 11 Sep 2011, Alistair Leslie-Hughes wrote: [...] > > So what's going on? > > > I have taken my values from xmlparser.idl found in the the PocketPC SDK that > is included with VS 2008. I think that's the problem. Wine reimplements the Windows' Platform SDK Win32 and Win64 APIs, not Window

Re: wpp: Shed an unused parameter from generic_msg. (RESEND)

2011-09-11 Thread Michael Stefaniuc
On 09/11/2011 04:58 AM, Gerald Pfeifer wrote: > On Thu, 8 Sep 2011, Alexandre Julliard wrote: >> It's still wrong, the parameter is used inside the #ifdef. > > Fair enough! How about the patch below then? Tested with and > without WANT_NEAR_INDICATION defined this time. This is patch is ugly. Ju

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 2)

2011-09-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14145 Your paranoid android

Re: Marking test cases as flaky?

2011-09-11 Thread Stefan Dösinger
On Saturday 10 September 2011 21:56:26 Dan Kegel wrote: > Might want to define the new form as ok2_ or something > so we can defer changing the explicit uses of ok_(). I dislike the idea, it has the feeling of legacy cruft. Either way it is a fairly minor point - the main change that needs debatin

Re: shell32/tests: Make test explicit about return pointer

2011-09-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14136 Your paranoid android

Re: wpp: Shed an unused parameter from generic_msg. (RESEND)

2011-09-11 Thread Gerald Pfeifer
On Thu, 8 Sep 2011, Alexandre Julliard wrote: > It's still wrong, the parameter is used inside the #ifdef. Fair enough! How about the patch below then? Tested with and without WANT_NEAR_INDICATION defined this time. Or would you rather see a patch that remove WANT_NEAR_INDICATION altogether? G