Re: [1/3] msxml3: Add xmlparser interfaces

2011-09-10 Thread Alistair Leslie-Hughes
Hi Francois, This patch defines an XML_ERROR_CODE enumeration type in xmlparser.idl which is a bit strange because I cannot find this type in the Windows SDK. But in the Windows 7 SDK there is an XmlError enumeration type in xmllite.h that looks similar but subtly different. These two enumarat

Re: Marking test cases as flaky?

2011-09-10 Thread Dan Kegel
On Sat, Sep 10, 2011 at 10:55 AM, Stefan Dösinger wrote: > On Saturday 10 September 2011 19:43:08 Dan Kegel wrote: >> #define ok_(file, func, line)       (winetest_set_location(file, func, >> line), 0) ? (void)0 : winetest_ok >> #define ok       ok_(__FILE__, __FUNCTION__, __LINE__) >> >> That wou

re: msi: Properly check for a specified flag combination

2011-09-10 Thread Dan Kegel
Test failed here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok ... err:msi:env_parse_flags Invalid flags: 0007 err:msi:ITERATE_Actions Execution halted, action L"RemoveEnvironmentStrings" returned 1627 err:msi:env_parse_flags Invalid f

Re: urlmon/tests: Removed a test that causes random failures on some machines

2011-09-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14120 Your paranoid android

Re: urlmon:sec_mgr failure on XP

2011-09-10 Thread Thomas Mullaly
Hi Francois, On Sat, Sep 10, 2011 at 6:33 AM, Francois Gouget wrote: > This test now fails on my Widnows XP VMs that have IE >= 7 with 'All > zones reset to default level': > http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/xp_fg-winxp-latest/urlmon:sec_mgr.html > > sec_mgr.c

Re: Marking test cases as flaky?

2011-09-10 Thread Stefan Dösinger
On Saturday 10 September 2011 19:43:08 Dan Kegel wrote: > #define ok_(file, func, line) (winetest_set_location(file, func, > line), 0) ? (void)0 : winetest_ok > #define ok ok_(__FILE__, __FUNCTION__, __LINE__) > > That would get you most of what you propose without any changes to the >

Re: speeding up builds with ext4 and ccache tuning

2011-09-10 Thread Dan Kegel
Two more things: - ccache's cache size matters. If ccache -s shows the cache is full after two builds, try raising it. The default is 1 GB, and I think with gcc-2.95, I needed a slightly larger cache. - ccache might slow you down if you have less than 3GB of RAM.

Re: Marking test cases as flaky?

2011-09-10 Thread Dan Kegel
On Sat, Sep 10, 2011 at 3:01 AM, Stefan Dösinger wrote: > A problem we have is that we have lots and lots of tests in dlls/d3d*/visual.c > and device.c that are unrelated to each other. d3d9/visual has about 100 > separate tests that could be in different files and work just the same way. > > Now

Re: [1/3] msxml3: Add xmlparser interfaces

2011-09-10 Thread Francois Gouget
On Wed, 7 Sep 2011, Alistair Leslie-Hughes wrote: > > Changelog: > msxml3: Add xmlparser interfaces This patch defines an XML_ERROR_CODE enumeration type in xmlparser.idl which is a bit strange because I cannot find this type in the Windows SDK. But in the Windows 7 SDK there is an XmlError

Re: gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.

2011-09-10 Thread Michael Mc Donnell
On Thu, Sep 8, 2011 at 8:11 PM, Francois Gouget wrote: > On Thu, 8 Sep 2011, Alexandre Julliard wrote: > [...] >> I don't think the name of the family really matters here. By using >> Tahoma the Wine implementation is trying to make sure we always return >> something, and that's what we should che

Re: The msctf:inputprocessor test is not reliable

2011-09-10 Thread Alexandre Julliard
Francois Gouget writes: > Or would it be better to change processPendingMessages() to look more > like user32/tests/msg.c's flush_events() function although it looks like > it's overkill for now? That's preferable, yes. -- Alexandre Julliard julli...@winehq.org

The msctf:inputprocessor test is not reliable

2011-09-10 Thread Francois Gouget
This test is not reliable on my Debian desktop. http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/linux_fg-deb64-t32/msctf:inputprocessor.html inputprocessor.c:2117: Test failed: OnSetFocus expected current focus 0x12b070 got 0x12b0d0 inputprocessor.c:538: Test failed: Unexpec

urlmon:sec_mgr failure on XP

2011-09-10 Thread Francois Gouget
This test now fails on my Widnows XP VMs that have IE >= 7 with 'All zones reset to default level': http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/xp_fg-winxp-latest/urlmon:sec_mgr.html sec_mgr.c:1695: Test failed: Expected zone 3, but got 1 for 'file/testing/test.test' T

Re: Marking test cases as flaky?

2011-09-10 Thread Stefan Dösinger
A problem we have is that we have lots and lots of tests in dlls/d3d*/visual.c and device.c that are unrelated to each other. d3d9/visual has about 100 separate tests that could be in different files and work just the same way. Now I don't suggest moving them into different files, that would mak

Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?

2011-09-10 Thread Eric Pouech
Le 09/09/2011 13:02, Frédéric Delanoy a écrit : 2011/9/9 Eric Pouech: WineDbg> set ! symbol_picker scoped will do what you want unfortunately, there's no way to store it as a default command (you can always use --command or --file on command line to help) Thanks for that quick response! Is th