Fix for bug 23287.
--Juan
From 1114085290c2ada360a02bae154b7167a0f2b0ca Mon Sep 17 00:00:00 2001
From: Juan Lang
Date: Thu, 8 Sep 2011 11:10:08 -0700
Subject: [PATCH 2/2] Test/correct CertGetNameString with NULL pvTypePara
---
dlls/crypt32/str.c | 18 -
dlls/crypt32/tests/str.c | 16
On Thu, 8 Sep 2011, Alexandre Julliard wrote:
[...]
> I don't think the name of the family really matters here. By using
> Tahoma the Wine implementation is trying to make sure we always return
> something, and that's what we should check: that we get a family, and
> that it's valid for creating a
Andrew Eikum asked:
>It would be nice to have tests for this,
>Are these part of the tests you're
>planning on submitting after you get the fixes in?
That is part of my tests, the latest testbot job is
https://testbot.winehq.org/JobDetails.pl?Key=14067
You can see that I still need to compute posit
Francois Gouget writes:
> I'm actually not entirely happy with this patch.
>
> Wine actually hardcodes the fallback fonts to Liberation Serif and
> Tahoma. So we could instead check that if on Wine and the Windows fonts
> are not installed then we get the fallback fonts.
>
> It's a bit what the
On Thu, Sep 8, 2011 at 6:37 PM, Octavian Voicu wrote:
> You are dereferencing 'closest' without checking if it's non-NULL. It
> can be NULL if control jumps to the 'exit' label for several cases.
> This only applies to winealsa; for wineoss there are no gotos.
Disregard that, I see now that hr is
--- a/dlls/winealsa.drv/mmdevdrv.c+++ b/dlls/winealsa.drv/mmdevdrv.c>
@@ -1310,17 +1313,14 @@ exit:
> LeaveCriticalSection(&This->lock);
> HeapFree(GetProcessHeap(), 0, formats);
>
> -if(hr == S_OK || !out){
> -CoTaskMemFree(closest);
> -if(out)
> -*out = N
> It's a bit what the test was trying to do with Microsoft Sans Serif
> except that I also take exception with the todo_wine since the fix is
> not to change Wine but to install the missing font.
I'm not too concerned about what happens in this case, but one
alternative would be to always test tha
In Wine, accept their fallbacks if the native fonts are not installed.
---
This is an alternative patch which is more strict as it only allows the
hardcoded fallbacks, and only if running in Wine.
diff --git a/dlls/gdiplus/tests/font.c b/dlls/gdiplus/tests/font.c
index 323461a..9c261d9 100644
--
It would be nice to have tests for this, and a fix for coreaudio if
needed. Likewise for patch 2/2. Are these part of the tests you're
planning on submitting after you get the fixes in?
Andrew
On Thu, Sep 08, 2011 at 04:09:37PM +0200, joerg-cyril.hoe...@t-systems.com
wrote:
> Hi,
>
> Wine is cu
I'm actually not entirely happy with this patch.
Wine actually hardcodes the fallback fonts to Liberation Serif and
Tahoma. So we could instead check that if on Wine and the Windows fonts
are not installed then we get the fallback fonts.
It's a bit what the test was trying to do with Microsoft
err.. I know there's no debugging going on right now, but I'm planning
on submiting a couple more patches to this file and I'll print some
debug info then.
2011/9/8 Francois Gouget :
> ---
> dlls/dinput/config.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/d
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=14060
Your paranoid android
Gerald Pfeifer writes:
> I sent basically this in February without any feedback, and it still
> applies.
It's still wrong, the parameter is used inside the #ifdef.
--
Alexandre Julliard
julli...@winehq.org
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=14056
Your paranoid android
14 matches
Mail list logo
