Re: comctl32: Fix the wizard and property sheet dialog styles.

2011-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14049 Your paranoid android

Re: Updated Clang static analysis results / Valgrind update

2011-09-07 Thread Austin English
Valgrind (ac0a7b644fa464fa640e06a6e26b2191b5a29a92) : http://austinenglish.com/logs/valgrind/2011-09-07-11.07/ Clang (f74a897f0eb47bea874b9247a24ad0dd61aa3507): http://www.sendspace.com/file/nvoxsk c8521b390e70a3ed31c00e69a095a35b702e1b0f scan-build-2011-09-06-1.tar.bz2 we're down to 1629 from 1

Re: Marking test cases as flaky?

2011-09-07 Thread Dan Kegel
André wrote: > Plan C could be to do what testbot does and remember possible fails, maybe > including the out of the blue ones. Testbot still suffers from a lot of false positives, I think. Yes, a build bot can do all sorts of workarounds, but we shouldn't forget about normal developers. It wou

Re: [2/3] msxml3: Register XML Parser interfaces (try 2)

2011-09-07 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: >> Do you really need this? I think existing coclasses are registered >> with .idl in /msxml3. Maybe just add new .idl in it? >> > Since these interfaces aren't part of the msxml3 typelib, we properly > want to keep them separated. You still want to generate the re

Re: ntdll: check for string and stringlength in _wcslwr and _wcsupr

2011-09-07 Thread Octavian Voicu
2011/9/7 André Hentschel : > +    if (!str || !*str) return NULL; >     return strlwrW( str ); >+if (!str || !*str) return NULL; >return struprW( str ); It seems strange to return NULL when called with an empty, non-NULL string. Maybe it should be `return str' instead (so it covers both t

Re: ntdll: check for string and stringlength in _wcslwr and _wcsupr

2011-09-07 Thread Nikolay Sivov
2011/9/7 André Hentschel : > Fixes http://bugs.winehq.org/show_bug.cgi?id=28303 (str="") > --- >  dlls/ntdll/wcstring.c |    2 ++ >  1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/ntdll/wcstring.c b/dlls/ntdll/wcstring.c > index 7f0035d..d75f10e 100644 > --- a/dlls/ntdll/wcs

Re: [3/3] msxml3: Support creating IXMLParser Interface (try 2)

2011-09-07 Thread Nikolay Sivov
On Wed, Sep 7, 2011 at 4:13 PM, Alistair Leslie-Hughes wrote: > On 7/09/2011 9:43 PM, Nikolay Sivov wrote: > >> >> (not related to patch contents) >> >> First time I saw this on a list I thought - god dammit, another parser >> interface. But looking at methods list it's probably a first candidate

Re: ntdll: Fix two buffer overflow conditions in RtlDosPathNameToNtPathName_U.

2011-09-07 Thread Vitaliy Margolen
On 09/06/2011 08:46 AM, Octavian Voicu wrote: On Tue, Sep 6, 2011 at 4:40 PM, Vitaliy Margolen wrote: The fix is not entirely correct. UNICODE_STRING does not have to have a terminating \0 character. The code should not use str* functions on not zero-terminated strings. I was also unsure abo

Re: Getting Wine's PO files on Launchpad

2011-09-07 Thread Aric Stewart
So Newman and I just got a Pootle server setup for CrossOver translations and I was going to talk here about putting winehq's po files up on it also. I am still just getting use to admin for pootle, and I am not sure if i can get it hooked up directly to git or not. But if people are interes

Re: [3/3] msxml3: Support creating IXMLParser Interface (try 2)

2011-09-07 Thread Vijay Kiran Kamuju
On Wed, Sep 7, 2011 at 2:13 PM, Alistair Leslie-Hughes wrote: > On 7/09/2011 9:43 PM, Nikolay Sivov wrote: > >> >> (not related to patch contents) >> >> First time I saw this on a list I thought - god dammit, another parser >> interface. But looking at methods list it's probably a first candidate

Re: Getting Wine's PO files on Launchpad

2011-09-07 Thread André Hentschel
Am 07.09.2011 12:43, schrieb Francois Gouget: > But Launchpage is certainly not the only option. We could set up our own > Pootle server for instance. > > http://translate.sourceforge.net/wiki/pootle/features > > A number of projects do so. > http://translate.sourceforge.net/wiki/pootle/live_ser

Re: [2/3] msxml3: Register XML Parser interfaces (try 2)

2011-09-07 Thread Alistair Leslie-Hughes
On 7/09/2011 9:39 PM, Nikolay Sivov wrote: On Wed, Sep 7, 2011 at 2:04 PM, Alistair Leslie-Hughes wrote: Hi, Changelog: msxml3: Register XML Parser interfaces Do you really need this? I think existing coclasses are registered with .idl in /msxml3. Maybe just add new .idl in it? Sin

Re: [3/3] msxml3: Support creating IXMLParser Interface (try 2)

2011-09-07 Thread Alistair Leslie-Hughes
On 7/09/2011 9:43 PM, Nikolay Sivov wrote: (not related to patch contents) First time I saw this on a list I thought - god dammit, another parser interface. But looking at methods list it's probably a first candidate to be independent from libxml2 without any loss in functionality or big overh

Re: Marking test cases as flaky?

2011-09-07 Thread André Hentschel
Am 07.09.2011 06:14, schrieb Dan Kegel: > Hi folks, > I've been running "make test" a lot lately, and occasionally > (it happened five times today), a test will fail out of > the blue, in one out of twenty or a hundred runs. > It would be bad form for buildbot to reject a patch > because of a spuri

Re: winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol (resend)

2011-09-07 Thread Alexandre Julliard
joerg-cyril.hoe...@t-systems.com writes: > Hi, > > [unmodified & sent alone. There's no apply failure in testbot.] > > With this patch, MacOS will be the first to correctly implement the allowed > ordering of Get and ReleaseBuffer according to my rendering tests (see bug > #27937). > > [...captu

Re: [3/3] msxml3: Support creating IXMLParser Interface (try 2)

2011-09-07 Thread Nikolay Sivov
On Wed, Sep 7, 2011 at 2:05 PM, Alistair Leslie-Hughes wrote: > Hi, > > Use a skip if we cannot create the control. > > Changelog: >     msxml3: Support creating IXMLParser Interface > > > Best Regards >  Alistair Leslie-Hughes > > (not related to patch contents) First time I saw this on a list

Re: [2/3] msxml3: Register XML Parser interfaces (try 2)

2011-09-07 Thread Nikolay Sivov
On Wed, Sep 7, 2011 at 2:04 PM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: >     msxml3: Register XML Parser interfaces > Do you really need this? I think existing coclasses are registered with .idl in /msxml3. Maybe just add new .idl in it?

Re: [PATCH 1/2] cmd: Remove attrib from builtins list

2011-09-07 Thread Alexandre Julliard
Frédéric Delanoy writes: > The changes to the PO files would have to be committed as some point, > so why not generate them yourself rather than force Alexandre to alter > the patch after submission IMHO. > > Maybe Alexandre can bring some light on this subject? It's all auto-generated, so it's

Re: [PATCH 1/2] cmd: Remove attrib from builtins list

2011-09-07 Thread Francois Gouget
On Wed, 7 Sep 2011, Frédéric Delanoy wrote: [...] > The changes to the PO files would have to be committed as some point, > so why not generate them yourself rather than force Alexandre to alter > the patch after submission IMHO. I don't think it generates more work for Alexandre. The reason for n

Re: Getting Wine's PO files on Launchpad

2011-09-07 Thread Francois Gouget
On Tue, 6 Sep 2011, Austin English wrote: [...] > There's at least one other option: > http://translationproject.org/html/welcome.html It does not look like they make it possible to translate online. They seem to be more like a repository for PO files. So it seems less translator friendly and no

Re: [PATCH 1/2] cmd: Remove attrib from builtins list

2011-09-07 Thread Frédéric Delanoy
2011/9/7 Francois Gouget : > On Wed, 7 Sep 2011, Frédéric Delanoy wrote: > >> On Wed, Sep 7, 2011 at 09:09, Christian Costa wrote: >> > -- >> > >> > This series remove attrib from the builtins list. Only the brief >> > description in the global help is kept. >> > An externals list of commands shi

Re: [PATCH 1/2] cmd: Remove attrib from builtins list

2011-09-07 Thread Francois Gouget
On Wed, 7 Sep 2011, Frédéric Delanoy wrote: > On Wed, Sep 7, 2011 at 09:09, Christian Costa wrote: > > -- > > > > This series remove attrib from the builtins list. Only the brief > > description in the global help is kept. > > An externals list of commands shipped with cmd.exe is created so when

Re: [PATCH 1/2] cmd: Remove attrib from builtins list

2011-09-07 Thread Frédéric Delanoy
On Wed, Sep 7, 2011 at 09:09, Christian Costa wrote: > -- > > This series remove attrib from the builtins list. Only the brief description > in the global help is kept. > An externals list of commands shipped with cmd.exe is created so when the > help builtins is called, the > requested help is

Re: [PATCH 2/2] cmd: Launch the command with the /? option for external commands shipped with cmd.exe

2011-09-07 Thread Frédéric Delanoy
On Wed, Sep 7, 2011 at 09:10, Christian Costa wrote: > +        WCHAR space_slashdot_ask[] = {' ', '/','?','\0'}; space_slash_questionmark would probably be a more appropriate name

Re: winecfg: Specify a context for the 'Letter' paper size. (try 2)

2011-09-07 Thread Octavian Voicu
On Wed, Sep 7, 2011 at 11:27 AM, Francois Gouget wrote: > Actually, paper size is the more common term. ... > --- a/programs/winecfg/winecfg.rc > +++ b/programs/winecfg/winecfg.rc ... > -    IDS_COL_DRIVELETTER         "Letter" > +    IDS_COL_DRIVELETTER         "#msgctxt#Paper size#Letter" While

Re: [3/3] msxml3: Support creating IXMLParser Interface

2011-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14026 Your paranoid android

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

2011-09-07 Thread Christian Costa
Yes. It is adressed in the next serie I just sent. Christian > Message du 07/09/11 08:34 > De : "Frédéric Delanoy" > A : "Christian Costa" > Copie à : "Wine Devel" > Objet : Re: [PATCH] attrib: Move implementation from cmd.exe to the > standalone command (try 4) (resend) > > "help attr