"help attrib" from within cmd, and "wine attrib /?" give different results.
That should probably be aligned, for better integration, if possible.
Frédéric.
Hi folks,
I've been running "make test" a lot lately, and occasionally
(it happened five times today), a test will fail out of
the blue, in one out of twenty or a hundred runs.
It would be bad form for buildbot to reject a patch
because of a spurious test failure, so I've been making a list of
test
On Mon, Sep 5, 2011 at 11:30, Scott Ritchie wrote:
> On 09/05/2011 04:46 AM, Henri Verbeet wrote:
>> On 5 September 2011 10:38, Michael Stefaniuc wrote:
>>> Permission to relicense the existing translations with a BSD license...
>>> https://help.launchpad.net/Translations/StartingToTranslate#Lice
On 09/01/2011 10:50 AM, Henri Verbeet wrote:
> Looking at this from a slightly different angle, I think that if you
> expect people to take buildbot results seriously, you should run it on
> a configuration that's known to be solid, so that people can be
> confident any failures are actual issues w
Am 07.09.2011 00:48, schrieb Francois Gouget:
> It's likely that letter does not always translate the same way for the paper
> format and the alphabet characters.
> ---
>
> This is more to provide context for the translator than to avoid
> conflicts.
>
> programs/winecfg/winecfg.rc |2 +-
>
2011/9/6 Dan Kegel :
> Hi André,
> your patch failed to build on an ubuntu 10.04 system here:
>
> ccache gcc -c -I. -I. -I../../../include -I../../../include
> -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT
> -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement
Hi André,
your patch failed to build on an ubuntu 10.04 system here:
ccache gcc -c -I. -I. -I../../../include -I../../../include
-DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT
-fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement
-Wempty-body -Wstrict-prototypes
Hi,
The ddrawmodes test has a problem on W7PROX64 when running as a 64 bit binary.
The test times out, and debugging showed that it freezes in crash_callbackA,
in dlls/ddraw/tests/ddrawmodes.c. The function is supposed to crash,
DirectDrawEnumerateA catches the exception and returns DDERR_INVAL
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=14016
Your paranoid android
Am 06.09.2011 18:02, schrieb Alexandre Julliard:
> André Hentschel writes:
>
>> @@ -44,7 +44,7 @@ IDR_BROWSE_CONTEXT_MENU MENU
>> MENUITEM "Set as &Desktop Item", IDM_SETDESKTOPITEM
>> MENUITEM SEPARATOR
>> MENUITEM "Select &All",IDM_SELECTALL
>> -
> I don't have such an error here. Are you sure it is my patch that causes
> this ?
> Line 591 does not say much. Is it in the .cmd file or the .cmd.exp one. What
> is the failing command ?
> I don't see the point with testbot, there is no tests change in my patch.
Don't have the error anymore, pr
On 06/09/2011 15:33, Frédéric Delanoy wrote:
On Tue, Sep 6, 2011 at 09:35, Christian Costa wrote:
--
It's just a resend. The patch is unmodified, just rebased on latest git.
try4:
- add missing NULL ending character to help_option string
try3:
- fix /? option. This fixes cmd tests regression
André Hentschel writes:
> @@ -44,7 +44,7 @@ IDR_BROWSE_CONTEXT_MENU MENU
> MENUITEM "Set as &Desktop Item", IDM_SETDESKTOPITEM
> MENUITEM SEPARATOR
> MENUITEM "Select &All",IDM_SELECTALL
> -MENUITEM "&Paste", IDM_PASTE
> +ME
On Tue, Sep 6, 2011 at 4:40 PM, Vitaliy Margolen
wrote:
> The fix is not entirely correct. UNICODE_STRING does not have to have a
> terminating \0 character. The code should not use str* functions on not
> zero-terminated strings.
I was also unsure about this when coding the patch, but I read her
It's that time of year again. I thought I'd forward this on to
wine-devel since we're all Git users here.
- Forwarded message from Jakub Narebski -
Date: Mon, 5 Sep 2011 02:43:20 +0200
From: Jakub Narebski
To: g...@vger.kernel.org
Subject: [ANNOUNCE] Git User's Survey 2011
User-Agent: K
On Tue, Sep 6, 2011 at 2:12 AM, Francois Gouget wrote:
> I found that most of the processes I had that were left behind were
> winedbg processes showing the crash dialog. This was slowing things
> down quite a bit with winetest because each was triggering the two
> minutes timeout.
In my case, it
Alistair Leslie-Hughes writes:
> Hi,
>
>
> Changelog:
> uxtheme: Return error on invalid parameters
Get/SetPropW already check the handle, don't add redundant checks.
--
Alexandre Julliard
julli...@winehq.org
Francois Gouget writes:
> @@ -59,57 +59,87 @@ typedef BOOL (CALLBACK *LPFNADDPROPSHEETPAGES)(LPVOID,
> LPFNADDPROPSHEETPAGE, LPA
> /*
> * Property sheet support (structures)
> */
> +#ifndef _WIN32
> +typedef const VOID* PROPSHEETPAGE_RESOURCE;
> +#elif defined(UNICODE)
> +typedef LPCDLG
On 09/06/2011 06:23 AM, Octavian Voicu wrote:
First one is an off-by-one error: RtlGetFullPathName_U, on success, returns
the number of bytes written, without counting the terminating NULL. The
allocated size for ntpath->Buffer didn't account for that NULL byte, so
for UNC paths the NULL byte wou
François Gouget asked:
>> + * Depending on OSX settings, the firewall will ask whether to
>> allow incoming network access for tests involving server sockets.
>Does it cause test failures?
Sorry, I've not tracked it down.
Either I click "agree" fast enough (they occur towards the end of the
~20 mi
On Tue, Sep 6, 2011 at 09:35, Christian Costa wrote:
> --
>
> It's just a resend. The patch is unmodified, just rebased on latest git.
>
> try4:
> - add missing NULL ending character to help_option string
>
> try3:
> - fix /? option. This fixes cmd tests regression
>
> try2:
> - keep attrib infos
On Tue, 6 Sep 2011, Dmitry Timoshkov wrote:
[...]
> - if (sec->Characteristics & IMAGE_SCN_MEM_WRITE) vprot |=
> VPROT_READ|VPROT_WRITE;
> + if (sec->Characteristics & IMAGE_SCN_MEM_WRITE) vprot |= VPROT_WRITECOPY;
>
> So, probably restore adding VPROT_READ.
Yep, that works.
André, I'll let you d
Well, I did the patch mostly for personal use and dropped here as some
might find it useful.
If wine ever needs something like this, let's say for testing or for
some people wanting to fake display information, or do not want to use
XRandR or others for some reason, then it would at least need to
s
On 09/06/2011 02:25 PM, Jari Vetoniemi wrote:
I have them both disabled, however then some applications won't work
because they don't get any resolution information.
I only use FakeDisp.
IMO, there is a need and your patch is a solution (among other).
Is there a relevant developer able to answe
I have them both disabled, however then some applications won't work
because they don't get any resolution information.
I only use FakeDisp.
2011/9/5 Roderick Colenbrander :
> On Mon, Sep 5, 2011 at 3:14 PM, Jari Vetoniemi wrote:
>> Yes, sorry about that.. Gmail does not seem to play nice with so
Francois Gouget writes:
> I can't because they append the A/W suffix whereas here it must be
> inserted in the middle. I could potentially define+undefine a specific
> macro just for this case if you prefer.
The important thing is that the defines must not be available in Wine
code.
--
Alexa
On Tue, 6 Sep 2011, Alexandre Julliard wrote:
[...]
> > +typedef PROPSHEETPAGEA_LATESTPROPSHEETPAGE_LATEST;
> > +typedef LPPROPSHEETPAGEA_LATEST LPPROPSHEETPAGE_LATEST;
> > +typedef LPCPROPSHEETPAGEA_LATEST LPCPROPSHEETPAGE_LATEST;
> > +#define PROPSHEETPAGE_V1_SIZEPROPSHEETPAGEA_V1_SIZE
>
Francois Gouget writes:
> @@ -213,6 +247,27 @@ DECL_WINELIB_TYPE_AW(PROPSHEETHEADER)
> DECL_WINELIB_TYPE_AW(LPPROPSHEETHEADER)
> DECL_WINELIB_TYPE_AW(LPCPROPSHEETHEADER)
> DECL_WINELIB_TYPE_AW(LPFNPSPCALLBACK)
> +#ifdef UNICODE
> +typedef PROPSHEETPAGEW_LATESTPROPSHEETPAGE_LATEST;
> +typed
Francois Gouget wrote:
The kernel32:loader test was crashing on line 660:
ok(!memcmp((const char *)info.BaseAddress, section_data,
section.SizeOfRawData), "wrong section data\n");
Further that was just for the following entries:
{ IMAGE_SCN_MEM_WRITE, PAGE_WRITECOPY },
an
On Tue, 6 Sep 2011, Dan Kegel wrote:
> The buildbot does three things to get fast, reliable test runs:
[...]
> - it kills wineserver after the run (since some tests leave processes around)
I found that most of the processes I had that were left behind were
winedbg processes showing the crash dia
On Tue, 6 Sep 2011, Dmitry Timoshkov wrote:
> André Hentschel wrote:
>
> > As per tests in kernel32:loader it seems linux&co allows reads on PROT_WRITE
> > areas, but solaris doesn't and crashes.
> > This fixes this issue.
>
> > -if (vprot & VPROT_WRITECOPY) prot |= PROT_WRITE;
> > +
The buildbot does three things to get fast, reliable test runs:
- it runs a 'safe' set of tests in the background, without DISPLAY
set, in a different wineprefix; this saves three minutes
- it has a blacklist of known flaky or broken tests, listing how it's
broken and linking to the bug report
- it
32 matches
Mail list logo
