Re: [2/2] ntdll: Allow reading from a VPROT_WRITECOPY protected memory

2011-09-05 Thread Dmitry Timoshkov
André Hentschel wrote: As per tests in kernel32:loader it seems linux&co allows reads on PROT_WRITE areas, but solaris doesn't and crashes. This fixes this issue. -if (vprot & VPROT_WRITECOPY) prot |= PROT_WRITE; +if (vprot & VPROT_WRITECOPY) prot |= PROT_READ | PROT_WRITE;

Re: comctl32: Property sheets must be able to redraw themselves even if no page is selected.

2011-09-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13992 Your paranoid android

Re: Undocumented registry settings

2011-09-05 Thread Vitaliy Margolen
On 09/05/2011 08:59 AM, Henri Verbeet wrote: On 4 September 2011 21:20, Vitaliy Margolen wrote: Would you mind documenting recently added registry entries to wined3d on Wiki page http://wiki.winehq.org/UsefulRegistryKeys ? I can't find description of "AlwaysOffscreen". I updated the page a bi

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)

2011-09-05 Thread Frédéric Delanoy
On Mon, Sep 5, 2011 at 14:35, Henri Verbeet wrote: > 2011/9/5 Frédéric Delanoy : >> +        keys = HeapAlloc(GetProcessHeap(), 0, capacity * sizeof(WCHAR*)); >> +        vals = HeapAlloc(GetProcessHeap(), 0, capacity * >> sizeof(LARGE_INTEGER)); > ... >> +                    keys = HeapReAlloc(G

Re: Getting Wine's PO files on Launchpad

2011-09-05 Thread Scott Ritchie
On 09/05/2011 04:46 AM, Henri Verbeet wrote: > On 5 September 2011 10:38, Michael Stefaniuc wrote: >> Permission to relicense the existing translations with a BSD license... >> https://help.launchpad.net/Translations/StartingToTranslate#Licensing_your_translations >> The license itself is sane but

Re: msxml3: Correct MSXML Object Safety tests (try 2)

2011-09-05 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > Hi, > Add the enabled test as well. > > Changelog: > msxml3: Correct Object Safety tests It doesn't work here: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok domdoc.c:4706: Test failed: expecte

Re: [patch] Fake display interface

2011-09-05 Thread Roderick Colenbrander
On Mon, Sep 5, 2011 at 3:14 PM, Jari Vetoniemi wrote: > Yes, sorry about that.. Gmail does not seem to play nice with some > mailing lists which is weird. > Anyways, I looked at the bug report. This could work for resolution > and frequency, but it does not fake color depth. > > 2011/9/5 GOUJON Al

Re: ole32/tests: Test for correct storage creation.

2011-09-05 Thread Vincent Povirk
You might just want to try reopening the file and checking its CLSID, instead of directly checking the contents. That should make it more obvious that something is seriously wrong. With the direct checks, it's hard to figure out what the test actually means. Anyway, this should be easy to fix. We

Re: [1/2] programs: Add a stub implementation of regasm.exe.

2011-09-05 Thread Vincent Povirk
On Windows, this is a .NET assembly. We should probably do it the same way.

Re: [dsound] InstanceId holds a pointer, so it needs to be as wide as a pointer.

2011-09-05 Thread Michael Stefaniuc
Hello Dan, Dan Kegel wrote: > Not that we do anything with it... still the correct fix would be to rewrite the driver to use a more modern header version than DirectX 5. I guess that's part of Andrew's dsound rewrite. bye michael

Re: Undocumented registry settings

2011-09-05 Thread Henri Verbeet
On 4 September 2011 21:20, Vitaliy Margolen wrote: > Would you mind documenting recently added registry entries to wined3d on > Wiki page http://wiki.winehq.org/UsefulRegistryKeys ? I can't find > description of "AlwaysOffscreen". > I updated the page a bit.

Re: configure.ac: add -Werror to default compiler options

2011-09-05 Thread Dan Kegel
On Wed, Aug 31, 2011 at 11:13 PM, Octavian Voicu wrote: > On Thu, Sep 1, 2011 at 4:27 AM, Dan Kegel wrote: >> At which point it would probably be a fine idea to add -Werror by default; >> buildbot will help keep everyone in sync, even if they're using a compiler >> that doesn't catch as many warn

Re: [1/4] urlmon: Use CoTaskMemFree instead of HeapFree for memory allocated with CoTaskMemAlloc

2011-09-05 Thread Thomas Mullaly
Hi Jacek, On Mon, Sep 5, 2011 at 3:33 AM, Jacek Caban wrote: > AFAICS secur_url wasn't allocated with CoTaskMemAlloc until this patch. Why > are you changing it? map_url_to_zone gets "secur_url" allocated in one of two ways. The first way is through CoInternetGetSecurityUrl, which allocates the

Re: [patch] Fake display interface

2011-09-05 Thread Jari Vetoniemi
Yes, sorry about that.. Gmail does not seem to play nice with some mailing lists which is weird. Anyways, I looked at the bug report. This could work for resolution and frequency, but it does not fake color depth. 2011/9/5 GOUJON Alexandre : > On 09/02/2011 10:57 PM, Jari Vetoniemi wrote: >> >> Ye

Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)

2011-09-05 Thread Eric Pouech
this won't work if a .bat file calls another .bat file the cache must be stored inside the context structure... A+ -- Eric Pouech

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)

2011-09-05 Thread Henri Verbeet
2011/9/5 Frédéric Delanoy : > +        keys = HeapAlloc(GetProcessHeap(), 0, capacity * sizeof(WCHAR*)); > +        vals = HeapAlloc(GetProcessHeap(), 0, capacity * > sizeof(LARGE_INTEGER)); ... > +                    keys = HeapReAlloc(GetProcessHeap(), 0, keys, > +                              

Re: [1/5] ddraw: Add some NULL pointer tests

2011-09-05 Thread Stefan Dösinger
Am 05.09.2011 um 00:30 schrieb Marvin: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.wi

Re: Getting Wine's PO files on Launchpad

2011-09-05 Thread Henri Verbeet
On 5 September 2011 10:38, Michael Stefaniuc wrote: > Permission to relicense the existing translations with a BSD license... > https://help.launchpad.net/Translations/StartingToTranslate#Licensing_your_translations > The license itself is sane but it will require quite some work and time > to acc

Re: [PATCH 2/4] wined3d: Git rid of the rect checks for present in IWineD3DSurfaceImpl_BltOverride().

2011-09-05 Thread Henri Verbeet
On 5 September 2011 10:45, Stefan Dösinger wrote: > The comment is slightly outdated, fbo_blit could handle this just fine, but > apparently the rest of the code doesn't call fbo_blit yet. So we're not quit > ready to remove this hack, yeah. > FBO blits aren't the issue, this is for when those are

Re: [2/4] msi/tests: Fix a number of test messages.

2011-09-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13969 Your paranoid android

Re: [patch] Fake display interface

2011-09-05 Thread GOUJON Alexandre
On 09/02/2011 10:57 PM, Jari Vetoniemi wrote: Yeah, I'm aware of virtual desktop and used to create scripts to launch applications using wine explorer \desktop=WIDTHxHEIGHT or whatever the parameters were, it works well. But means that you have to create always new shell script, and it also can p

Re: [2/3] winhttp/tests: Initialize a variant with a known value.

2011-09-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13968 Your paranoid android

Re: Getting Wine's PO files on Launchpad

2011-09-05 Thread Ferenc Gergely Szilagyi
Hello, the LP Translation FAQ writes: "I have no problem with BSD myself, but I also uploaded translations from upstream. What do I do? As long as the uploads were marked as translations that were published elsewhere, they fall under a separate copyright regime: those imports will retain their ori

Re: [PATCH 2/4] wined3d: Git rid of the rect checks for present in IWineD3DSurfaceImpl_BltOverride().

2011-09-05 Thread Stefan Dösinger
On Monday 05 September 2011 01:19:27 Henri Verbeet wrote: > On 5 September 2011 00:03, Stefan Dösinger wrote: > > On Sunday 04 September 2011 22:43:50 Henri Verbeet wrote: > >> These are no longer needed since present can handle these now. > > > > I think we can remove the entire special case and

Re: Getting Wine's PO files on Launchpad

2011-09-05 Thread Michael Stefaniuc
Francois Gouget wrote: > Launchpad has a PO file translation website. This makes it easier for > non-developpers to contribute and review translations. > > https://translations.launchpad.net/ > > So what would it take to get Wine's PO files on Launchpad? Permission to relicense the existing tran

Re: [1/4] urlmon: Use CoTaskMemFree instead of HeapFree for memory allocated with CoTaskMemAlloc

2011-09-05 Thread Jacek Caban
Hi Thomas, AFAICS secur_url wasn't allocated with CoTaskMemAlloc until this patch. Why are you changing it? Jacek

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)

2011-09-05 Thread Frédéric Delanoy
On Mon, Sep 5, 2011 at 06:47, Octavian Voicu wrote: > 2011/9/5 Frédéric Delanoy : >> +        static WCHAR string[MAX_PATH]; > > Why make this static? It's only a temporary buffer and it's only used > once, when building the cache. Yeah true. Bad copy-paste from old WCMD_goto, although making it

Re: Getting Wine's PO files on Launchpad

2011-09-05 Thread Scott Ritchie
On 09/04/2011 03:26 PM, Francois Gouget wrote: > * Launchpad would need to pull updated PO files from Wine regularly. >Ideally that would be automatic and happen daily (both to account >for translations happening outside Launchpad and to take changes in >the resource files into acco