Re: configure.ac: add -Werror to default compiler options

2011-08-31 Thread Octavian Voicu
On Thu, Sep 1, 2011 at 4:27 AM, Dan Kegel wrote: > At which point it would probably be a fine idea to add -Werror by default; > buildbot will help keep everyone in sync, even if they're using a compiler > that doesn't catch as many warnings as the one buildbot uses. Have you tried compiling on 64

re: configure.ac: add -Werror to default compiler options

2011-08-31 Thread Dan Kegel
(Reviving http://www.winehq.org/pipermail/wine-devel/2008-September/069266.html ) After http://www.winehq.org/pipermail/wine-patches/2011-August/106150.html and http://www.winehq.org/pipermail/wine-patches/2011-August/106151.html, configuring with -Wall -Werror gives the right results, judging by

Re: 78223: Subject: configure: fix configure failures under -Werror -Wall

2011-08-31 Thread buildbot
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/168 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

Re: 78222: Subject: configure: AC_C_CONST is obsolete

2011-08-31 Thread buildbot
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/167 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

Re: buildbot status

2011-08-31 Thread Dan Kegel
On Wed, Aug 31, 2011 at 3:53 PM, Stefan Dösinger wrote: > On the other hand I think having a hardware with "strange" limits in the > testbot system can help to avoid getting bad assumptions about those limits > into the code, so I'll spend a day or two trying to isolate the issues and at > least f

Re: WineHQ Maintenance.

2011-08-31 Thread Jeremy Newman
OK, the maintenance is complete. Let me know if you notice any odd errors with our various websites. Everything but the Wiki, as that is hosted elsewhere. -Newman On 08/30/2011 01:07 PM, Jeremy Newman wrote: We will be performing upgrades and maintenance to the WineHQ.org server starting at 1

Re: buildbot status

2011-08-31 Thread Stefan Dösinger
On Sunday 28 August 2011 17:52:21 Dan Kegel wrote: > On Sun, Aug 28, 2011 at 2:16 AM, Stefan Dösinger wrote: > > Is it possible to set up a slave that e.g. runs only the d3d tests? I > > have some older machines with older GPUs that are still worth > > covering(Radeon X1600, Geforce 7, maybe even

Re: fake patch #2 just to test error emails

2011-08-31 Thread buildbot
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/166 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

Re: cmd/tests: Add README doc file

2011-08-31 Thread Alexandre Julliard
Octavian Voicu writes: > 2011/8/31 Alexandre Julliard : >> That sort of thing should be on the wiki. READMEs in the source are >> never maintained properly. > > Speaking of obsolete documentation, we should remove the > documentation/ChangeLog.* files. They haven't been updated since wine > 1.0 a

Re: 78217: Subject: [PATCH 3/3] winecfg: Remove driver selection from Audio tab

2011-08-31 Thread Dan Kegel
Ah, I see you resent a fixed version, sorry for the noise. (FWIW, the bot won't test your retry, since it was an incomplete patch series.) On Wed, Aug 31, 2011 at 1:22 PM, Dan Kegel wrote: > On Wed, Aug 31, 2011 at 1:10 PM,   wrote: >> The Buildbot has detected a failed build on builder runtests

Re: 78217: Subject: [PATCH 3/3] winecfg: Remove driver selection from Audio tab

2011-08-31 Thread Dan Kegel
On Wed, Aug 31, 2011 at 1:10 PM, wrote: > The Buildbot has detected a failed build on builder runtests while building > Wine. > Full details are available at: > http://buildbot.kegel.com/builders/runtests/builds/161 > BUILD FAILED: failed git Something's fishy; looking at http://marc.info/?l=w

Re: 78214: Subject: winusb: add new stub dll (resend)

2011-08-31 Thread Dan Kegel
On Wed, Aug 31, 2011 at 1:00 PM, wrote: > The Buildbot has detected a failed build on builder runtests while building > Wine. > Full details are available at: > http://buildbot.kegel.com/builders/runtests/builds/158 > BUILD FAILED: failed git > > > For more info about this message, see http://w

Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing

2011-08-31 Thread Frédéric Delanoy
2011/8/31 Frédéric Delanoy : > 2011/8/31 Frédéric Delanoy : >> 2011/8/31 Martin Wilck : Just ask if you don't understand the @keywords@. Doc is a bit lacking; I might add a quick wiki help page if desired. >>> >>> Yes, that'd be helpful (IMO just a README file in the tests/ directory >>>

Re: cmd/tests: Add README doc file

2011-08-31 Thread Octavian Voicu
2011/8/31 Alexandre Julliard : > That sort of thing should be on the wiki. READMEs in the source are > never maintained properly. Speaking of obsolete documentation, we should remove the documentation/ChangeLog.* files. They haven't been updated since wine 1.0 and are confusing. I tried sending a

Re: d3dx9_36/tests: Fix printing a NULL string

2011-08-31 Thread David Laight
On Wed, Aug 31, 2011 at 05:18:57PM +0200, joerg-cyril.hoe...@t-systems.com wrote: > Bruno Haible was so kind to provide the following test run results: > > glibc SIGSEGV > MacOS X 10.5 (null) > FreeBSD 6.4(null) > OpenBSD 4.9(null) > AIX 7.1empty > HP-UX 11.31empty

Re: [PATCH 2/5] ddraw: Get rid of the surface implementation switching code.

2011-08-31 Thread Alexandre Julliard
Henri Verbeet writes: > Despite what the comment says, switching the implementation of an already > created surface isn't so straightforward. > --- > dlls/ddraw/ddraw.c | 179 + > dlls/ddraw/surface.c | 25 --- > dlls/wined3d/swapchain

Re: Severe startup latencies for Windows applications run under wine

2011-08-31 Thread Henri Verbeet
On 31 August 2011 17:25, Ben Peddell wrote: > msys-bash uses WriteProcessMemory() to copy 500kB during an emulated > fork.  This equates to about 125000 ptrace(PTRACE_POKEDATA,...) > syscalls, each of which takes about 0.8us on linux 2.6.38. > I wonder if writing to /proc/pid/mem instead would hel

Re: d3dx9_36/tests: Fix printing a NULL string

2011-08-31 Thread Henri Verbeet
On 31 August 2011 17:18, wrote: > Looks like the next Coccinelle job will be to flag potential NULL pointers > used in %s in logs, not the tests... > If it's something we get from the application, it should be using the debugstr_*() functions. Wouldn't be a bad thing to check though.

Re: d3dx9_36/tests: Fix printing a NULL string

2011-08-31 Thread Michael Stefaniuc
joerg-cyril.hoe...@t-systems.com wrote: > Bruno Haible was so kind to provide the following test run results: > > glibc SIGSEGV > MacOS X 10.5 (null) > FreeBSD 6.4(null) > OpenBSD 4.9(null) > AIX 7.1empty > HP-UX 11.31empty > IRIX 6.5 (null) > OSF/1 5.1 (n

Re: [PATCH 2/4] msi: reorder tables to optimize condition evaluation

2011-08-31 Thread Dan Kegel
On Wed, Aug 31, 2011 at 3:10 AM, wrote: > The Buildbot has detected a failed build on builder runtests while building > Wine. > Full details are available at: > http://buildbot.kegel.com/builders/runtests/builds/136 > BUILD FAILED: failed shell_3 > > > For more info about this message, see http

Re: Severe startup latencies for Windows applications run under wine

2011-08-31 Thread Ben Peddell
On 31/08/2011 3:12 AM, Dan Kegel wrote: > Try oprofile instead. > > ( A really old intro is at > http://www.winehq.org/wwn/249#oprofile%20&%20Wine ) > Using oprofile, testing 500 iterations of ExitProcess.exe with msys-bash under wine: About 2/3 of the active processor time was in wineserver. A

d3dx9_36/tests: Fix printing a NULL string

2011-08-31 Thread Joerg-Cyril . Hoehle
Bruno Haible was so kind to provide the following test run results: glibc SIGSEGV MacOS X 10.5 (null) FreeBSD 6.4(null) OpenBSD 4.9(null) AIX 7.1empty HP-UX 11.31empty IRIX 6.5 (null) OSF/1 5.1 (null) Solaris 10 SIGSEGV Cygwin (null) mingw

Re: d3dx9_36/tests: Fix printing a NULL string

2011-08-31 Thread Francois Gouget
On Tue, 30 Aug 2011, joerg-cyril.hoe...@t-systems.com wrote: > André Hentschel suggested: > >Should stop the crash on Solaris and maybe others > >-trace("parent_data = (%p) -> %s\n", parent_data, (char *)parent_data); > >+trace("parent_data (%p) -> %s\n", parent_data, parent_data ? (char

Re: hhctrl: IDTB_XXX resource strings

2011-08-31 Thread Owen Rudge
So I propose the attached patch. I wouldn't object to that. If somebody wants to implement support for the Jump buttons in the future, they can always be re-added, although I would say that in such a circumstance, a resource file entry wouldn't be necessary anyway. -- Owen Rudge http://www.

Re: hhctrl: IDTB_XXX resource strings

2011-08-31 Thread Francois Gouget
On Mon, 22 Aug 2011, Owen Rudge wrote: [...] > > But from there it's not clear to me they whether they will be used or > > not. Did you specifically mean that only Jump1/2 would not be used or > > does that apply to the other IDTB_XXX strings too? > > I was referring specifically to Jump1/2 in thi

Re: [PATCH 4/5] mountmgr.sys: Also unlink a:: drive when removing a dos device

2011-08-31 Thread Alexandre Julliard
GOUJON Alexandre writes: > What happened : when you click on the apply button, > apply_drive_changes() is called, then mountmgr_ioctl(), then > define_unix_drive(), then remove_dos_device() which unlink() k: but > not k:: Like I said, that's on purpose. -- Alexandre Julliard julli...@winehq.or

Re: [PATCH 1/5] kernel32: Add UDF support

2011-08-31 Thread Alexandre Julliard
GOUJON Alexandre writes: > As I said earlier, it also fails without my patch. > I will investigate but my patch does not cause a regression (as all > new features). It certainly doesn't fail here without your patch. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 4/5] mountmgr.sys: Also unlink a:: drive when removing a dos device

2011-08-31 Thread GOUJON Alexandre
On 08/31/2011 01:16 PM, Alexandre Julliard wrote: Alexandre Goujon writes: @@ -818,6 +818,7 @@ NTSTATUS remove_dos_device( int letter, const char *udi ) if ((path = get_dosdevices_path(&p ))) { p[0] = 'a' + drive->drive; +unlink( path ); That's no

Re: [PATCH 1/5] kernel32: Add UDF support

2011-08-31 Thread GOUJON Alexandre
On 08/31/2011 01:21 PM, Alexandre Julliard wrote: Alexandre Goujon writes: Based on Steven Wallace work. Should fix the wine side of bug #26273 It fails here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so volume.c&& touch volume.ok volume.c:105: Test

Re: [PATCH 3/5] kernel32: Improve GetVolumeInformation filesystem flags

2011-08-31 Thread GOUJON Alexandre
On 08/31/2011 01:15 PM, Alexandre Julliard wrote: Alexandre Goujon writes: if (fsname) lstrcpynW( fsname, ntfsW, fsname_len ); if (filename_len) *filename_len = 255; -if (flags) *flags = FILE_CASE_PRESERVED_NAMES; +if (flags) *flags = FILE_NAMED_STREAMS | FI

Re: user32: fix potential crash when loading unsupported files (with tests) (try 2) (resend)

2011-08-31 Thread Alexandre Julliard
Vitaly Perov writes: > @@ -1238,6 +1260,12 @@ static void test_LoadImage(void) > test_LoadImageFile("JPG", jpgimage, sizeof(jpgimage), "jpg", 0); > test_LoadImageFile("PNG", pngimage, sizeof(pngimage), "png", 0); > > +/* Corrupted images */ > +test_LoadCorruptedImageFile("corr

Re: [PATCH 1/5] kernel32: Add UDF support

2011-08-31 Thread Alexandre Julliard
Alexandre Goujon writes: > Based on Steven Wallace work. > Should fix the wine side of bug #26273 It fails here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so volume.c && touch volume.ok volume.c:105: Tests skipped: can't test removing fake drive volume.

Re: [PATCH 4/5] mountmgr.sys: Also unlink a:: drive when removing a dos device

2011-08-31 Thread Alexandre Julliard
Alexandre Goujon writes: > @@ -818,6 +818,7 @@ NTSTATUS remove_dos_device( int letter, const char *udi ) > if ((path = get_dosdevices_path( &p ))) > { > p[0] = 'a' + drive->drive; > +unlink( path ); That's not done on purpose, to make it more likely tha

Re: [PATCH 3/5] kernel32: Improve GetVolumeInformation filesystem flags

2011-08-31 Thread Alexandre Julliard
Alexandre Goujon writes: > if (fsname) lstrcpynW( fsname, ntfsW, fsname_len ); > if (filename_len) *filename_len = 255; > -if (flags) *flags = FILE_CASE_PRESERVED_NAMES; > +if (flags) *flags = FILE_NAMED_STREAMS | FILE_SUPPORTS_ENCRYPTION | > FILE_SUPPORTS_OBJEC

Re: cmd/tests: Test del /s recursion in subdirectories with colons.

2011-08-31 Thread Octavian Voicu
2011/8/31 Frédéric Delanoy : > My point was simply to make sure that subsequent wine patches, maybe a > year or two from now, won't make it "work" again (think regression) You got that wrong -- it *does* work on Wine already :) I think we can be more permissive in this aspect, it's not like some w

Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing

2011-08-31 Thread Frédéric Delanoy
2011/8/31 Frédéric Delanoy : > 2011/8/31 Martin Wilck : >>> Just ask if you don't understand the @keywords@. Doc is a bit lacking; >>> I might add a quick wiki help page if desired. >> >> Yes, that'd be helpful (IMO just a README file in the tests/ directory >> would be even better). It took me a w

Re: [PATCH 1/5] ddraw: Make the OpenGL renderer the default one.

2011-08-31 Thread Henri Verbeet
On 31 August 2011 10:58, Stefan Dösinger wrote: > This will break 2D-only apps in situations where OpenGL is not available. It Well, DirectDraw 2D-only applications, but yes. All three people in that situation should either install a software GL renderer or explicitly set the "DirectDrawRenderer"

Re: [PATCH 1/4] msi: speed up WHERE statement evaluation by evaluating the condition as early as possible

2011-08-31 Thread Alexandre Julliard
Bernhard Loos writes: > @@ -639,6 +715,8 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, > MSIRECORD *record ) > while ((table = table->next)); > > rows = msi_alloc( wv->table_count * sizeof(*rows) ); > +memset( rows, 0xFF, sizeof( rows ) ); > + If the goal is to set them

Re: cmd/tests: Test del /s recursion in subdirectories with colons.

2011-08-31 Thread Frédéric Delanoy
2011/8/30 Octavian Voicu : > 2011/8/30 Frédéric Delanoy : >> You don't test the result of your 'mkdir "foo:"'. You can't know from >> the test whether the dir was created and removed, or never existed. > > That's the whole point! I tested in cmd prompt on a Windows XP machine > (and I assume all Wi

Re: [PATCH] ntdll: provide a timestamp debug channel, which prints a millisecond resolution timestamp in front of debug output, very useful to debug deadlocks (resend)

2011-08-31 Thread Alexandre Julliard
Bernhard Loos writes: > @@ -164,8 +165,16 @@ static int NTDLL_dbg_vlog( enum __wine_debug_class cls, > struct __wine_debug_chan > /* only print header if we are at the beginning of the line */ > if (info->out_pos == info->output || info->out_pos[-1] == '\n') > { > +if (TRA

Re: cmd/tests: Add README doc file

2011-08-31 Thread Alexandre Julliard
Frédéric Delanoy writes: > --- > programs/cmd/tests/README | 120 > + > 1 files changed, 120 insertions(+), 0 deletions(-) > create mode 100644 programs/cmd/tests/README That sort of thing should be on the wiki. READMEs in the source are never main

Re: [PATCH 1/5] ddraw: Make the OpenGL renderer the default one.

2011-08-31 Thread Stefan Dösinger
On Tuesday 30 August 2011 20:12:31 Henri Verbeet wrote: > This imlicitly gets rid of the "auto" option as well, since there's no way > to explicitly specify it. This will no doubt cause its share of > regressions, but I prefer actually fixing those bugs to running into the > surface implementation

Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing

2011-08-31 Thread Frédéric Delanoy
2011/8/31 Martin Wilck : > >> IMHO we should probably split it only when it's reasonably complete, >> where we'd have a broader view. > > Well, it's up to you. I just made an attempt to merge my stuff into > test_builtins and gave up after 2 hours :-( > >> Also, test_parsing name is probably a bit

Re: ieframe: Fix a few incorrect pointer/integer casts on x64.

2011-08-31 Thread Michael Stefaniuc
Hello Octavian, in general please use the ULongToHandle*() / HandleToULong() macro family instead of the explicit casting. Octavian Voicu wrote: > --- > dlls/ieframe/iexplore.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/ieframe/iexplore.c b/dlls/iefr