Re: Testing edge cases and undocumented behavior

2011-08-30 Thread Steven Edwards
On Fri, Aug 26, 2011 at 6:00 AM, Michael Stefaniuc wrote: > It is a good advice. But that doesn't means one has to submit tests that > don't make sense. It seems like a simple comment describing the undocumented behavior would help. I wrote some tests years ago (the details are not important beca

Re: [3/7] dinput: Added enumerated devices to ConfigureDevices dialog

2011-08-30 Thread Octavian Voicu
On Wed, Aug 31, 2011 at 3:11 AM, Lucas Zawacki wrote: > Any pointers on what's the set of winapi functions used to store and > retrieve data in windows? I've searched MSDN for almost 30 minutes and > no luck. Try SetWindowLongPtr [1] / GetWindowLongPtr [2]. You probably want to use the W variants

Re: [3/7] dinput: Added enumerated devices to ConfigureDevices dialog

2011-08-30 Thread Lucas Zawacki
> It doesn't make sense to pass the info as WM_INITDIALG parameter if it's > going to be stored in global variables anyway. A better way would be to > store this in the window info. > Any pointers on what's the set of winapi functions used to store and retrieve data in windows? I've searched MSDN

Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing

2011-08-30 Thread Frédéric Delanoy
2011/8/30 Martin Wilck : > Hi Frédéric, > >> Some of those tests are already present in the test_builtins.cmd* >> (e.g. the spacing tests) >> You should probably integrated your tests in there: that makes it >> easier to spot regressions and helps prevent tests duplication > > I can certainly do th

re: [SOLVED] [PATCH]Where is the best place to report a fscanf bug found under wine-1.3.27?

2011-08-30 Thread Alan W. Irwin
On 2011-08-30 08:33-0700 Dan Kegel wrote: Today I discovered .. that the scanf family of functions was introducing float (32-bit floating-point) noise into double (64-bit floating-point) results. I see it here, too: $ sudo apt-get install mingw32 $ i586-mingw32msvc-gcc test_fscanf.c $ echo "1

win7 pro sp1 x64 testbot live

2011-08-30 Thread Maarten Lankhorst
Hi all, I've added a win7 sp1 testbot, it's currently in the extra vm's pool, so it requires some extra actions to find it, but if you want to run your tests against windows 7 sp1 with ie9 installed, you should now be able to. Happy testing!! ~Maarten

Re: Where is the best place to report a fscanf bug found under wine-1.3.27?

2011-08-30 Thread Eric Pouech
Le 30/08/2011 20:38, Peter Rosin a écrit : Den 2011-08-30 20:18 skrev David Laight: On Mon, Aug 29, 2011 at 06:43:41PM -0700, Alan W. Irwin wrote: double x; while(fscanf(stdin, " %le ",&x) == 1) You are using the wrong format, %le is for 'long double', this will probably overwrite too mu

Re: Where is the best place to report a fscanf bug found under wine-1.3.27?

2011-08-30 Thread Peter Rosin
Den 2011-08-30 20:18 skrev David Laight: > On Mon, Aug 29, 2011 at 06:43:41PM -0700, Alan W. Irwin wrote: >> double x; >> while(fscanf(stdin, " %le ", &x) == 1) > > You are using the wrong format, %le is for 'long double', this will > probably overwrite too much data. Nope, you are mistaken a

Re: Where is the best place to report a fscanf bug found under wine-1.3.27?

2011-08-30 Thread David Laight
On Mon, Aug 29, 2011 at 06:43:41PM -0700, Alan W. Irwin wrote: > double x; > while(fscanf(stdin, " %le ", &x) == 1) You are using the wrong format, %le is for 'long double', this will probably overwrite too much data. David -- David Laight: da...@l8s.co.uk

Re: d3dx9_36/tests: Fix printing a NULL string

2011-08-30 Thread David Laight
On Tue, Aug 30, 2011 at 12:44:05PM +0200, joerg-cyril.hoe...@t-systems.com wrote: > Wine logs in Solaris can randomly crash Wine because it crashes on > printf("%s", NULL)? > > I'm very surprised. I thought Solaris was one of the first machines - decades > ago - where I observed "(null)" for NU

Re: winelib an fpc

2011-08-30 Thread Roderick Colenbrander
On Tue, Aug 30, 2011 at 9:43 AM, Paul Chitescu wrote: > On Tuesday 30 August 2011 01:57:30 am Reinier Napoles Martinez wrote: >> >>This won't work. Simply doing a dlopen on the wine libraries won't get >> >>your environment setup properly. >> >> what can i do then to setup the wine environment cor

WineHQ Maintenance.

2011-08-30 Thread Jeremy Newman
We will be performing upgrades and maintenance to the WineHQ.org server starting at 1800 CDT on Wednesday August 31st. This process will take the server off-line for about an hour. The Websites (www,appdb,forums), and Mailing lists, and Git will be off-line during this period. -Newman

Re: cmd/tests: Test del /s recursion in subdirectories with colons.

2011-08-30 Thread Octavian Voicu
2011/8/30 Frédéric Delanoy : > You don't test the result of your 'mkdir "foo:"'. You can't know from > the test whether the dir was created and removed, or never existed. That's the whole point! I tested in cmd prompt on a Windows XP machine (and I assume all Windows versions act the same in this

Re: widl: duplicate type in case of argument with range attribute

2011-08-30 Thread Alexandre Julliard
Jérôme Gardou writes: > Anyway, I've looked into this a bit, and it seems that the place to > write a proper test is rpcrt4 test suite. > While writing the test would per se be very easy, the problem won't > show up if -Oif isn't set on the tested idl file. Adding this to the > EXTRAIDLFLAGS vari

Re: cmd/tests: Test del /s recursion in subdirectories with colons.

2011-08-30 Thread Frédéric Delanoy
On Tue, Aug 30, 2011 at 14:19, Octavian Voicu wrote: > -- > Issue was fixed by 94d2312fe2fdd77669ac826afa24e6821571ebba. This test is to > prevent future regressions, as suggested by Frederic. > > Windows doesn't accept colons in directory names, so it will just fail on the > mkdir/rmdir commands

re: Severe startup latencies for Windows applications run under wine

2011-08-30 Thread Dan Kegel
Try oprofile instead. ( A really old intro is at http://www.winehq.org/wwn/249#oprofile%20&%20Wine )

Re: widl: duplicate type in case of argument with range attribute

2011-08-30 Thread Jérôme Gardou
Le 30/08/2011 17:50, Jérôme Gardou a écrit : Hello. Maybe the comment isn't clear enough. The ranges are correctly output into the format string, but the offset of each output is lost during the processing. For instance, declaring a function like this one : DWORD Test( [in, range(0, 102

Re: Severe startup latencies for Windows applications run under wine

2011-08-30 Thread Octavian Voicu
On Tue, Aug 30, 2011 at 6:56 PM, Ben Peddell wrote: > A modification of the timestamp patch from Bernhard Loos should help us > find what calls are taking the longest. > Speaking of that, I've been trying to compile cmd tests with profiling (-pg, for use with gprof), but no luck. I added -pg to b

Re: Severe startup latencies for Windows applications run under wine

2011-08-30 Thread Ben Peddell
On 08/30/11 10:33, Alan W. Irwin wrote: > On 2011-08-30 08:20+1000 Ben Peddell wrote: >> Some things I have seen while investigating: >> >> I created a program which had a startup that immediately called >> ExitProcess to attempt to eliminate most of the initialization of the >> process being forke

Re: widl: duplicate type in case of argument with range attribute

2011-08-30 Thread Jérôme Gardou
Hello. Maybe the comment isn't clear enough. The ranges are correctly output into the format string, but the offset of each output is lost during the processing. For instance, declaring a function like this one : DWORD Test( [in, range(0, 1024)] DWORD dwParam1, [in, range(0, 255)] DW

Re: RFC - ws2_32/socket.c: SIO_KEEPALIVE_VALS vs TCP_KEEPIDLE/TCP_KEEPINTVL

2011-08-30 Thread Juan Lang
Hi Bruno, > The SIO_KEEPALIVE_VALS message on windows takes parameters as > miliseconds, on some other systems there are the equivalent > TCP_KEEPIDLE/TCP_KEEPINTVL which takes the parameters as seconds. To > solve this there is a division by 1000 on wine source code but the > problem is that valu

Re: wineview: Rename view to wineview and install it

2011-08-30 Thread Alexandre Julliard
Dan Kegel writes: > Alexandre wrote: >> I don't think we need to rename it. > > $ which view > /usr/bin/view > $ view --version > VIM - Vi IMproved 7.2 (2008 Aug 9, compiled Apr 16 2010 12:33:18) > ... > > I'm pretty sure view has been taken for many years as > the way to invoke vi in read-only m

re: Where is the best place to report a fscanf bug found under wine-1.3.27?

2011-08-30 Thread Dan Kegel
> Today I discovered .. that the scanf family of functions was > introducing float (32-bit floating-point) noise into double (64-bit > floating-point) results. I see it here, too: $ sudo apt-get install mingw32 $ i586-mingw32msvc-gcc test_fscanf.c $ echo "1.1e+01 1.1e+00 1.1e-01 1.1e-02 1.1e-03 1

re: wineview: Rename view to wineview and install it

2011-08-30 Thread Dan Kegel
Alexandre wrote: > I don't think we need to rename it. $ which view /usr/bin/view $ view --version VIM - Vi IMproved 7.2 (2008 Aug 9, compiled Apr 16 2010 12:33:18) ... I'm pretty sure view has been taken for many years as the way to invoke vi in read-only mode. - Dan

Re: Testing edge cases and undocumented behavior

2011-08-30 Thread Scott Ritchie
On 08/30/2011 04:05 AM, joerg-cyril.hoe...@t-systems.com wrote: > For instance, Scott Ritchie's example is not unusual: > + * If lpszStr is Null, returns how long a formatted string would be. > This is a very common pattern. Probably MSDN forgot to mention it. > Expect apps to use that when they

Re: [4/6] ddraw: Convert dwZBufferBitDepth into a DDPIXELFORMAT (try 2)

2011-08-30 Thread Henri Verbeet
On 30 August 2011 12:57, Stefan Dösinger wrote: > +static DWORD make_bitmask(DWORD count) > +{ > +DWORD ret = 0; > +for (count--; count != ~0U; count--) ret |= 1 << count; > +return ret; > +} You could probably do something like "return count ? ~0U >> (32 - count) : 0;" In this specif

RFC - ws2_32/socket.c: SIO_KEEPALIVE_VALS vs TCP_KEEPIDLE/TCP_KEEPINTVL

2011-08-30 Thread Bruno Jesus
This discussion is related to the test failing in bug 21271: http://bugs.winehq.org/show_bug.cgi?id=21271 The SIO_KEEPALIVE_VALS message on windows takes parameters as miliseconds, on some other systems there are the equivalent TCP_KEEPIDLE/TCP_KEEPINTVL which takes the parameters as seconds. To s

Testing edge cases and undocumented behavior

2011-08-30 Thread Joerg-Cyril . Hoehle
Hi, Michael Stefaniuc wrote: >What you do want to test is: >- the de jure API (as documented), and >- the de facto API (as used by applications You plead for operational profile testing. I say that the API "as used by applications" is unknown to me because the 10 apps out there don't send me

Re: widl: duplicate type in case of argument with range attribute

2011-08-30 Thread Alexandre Julliard
Jérôme Gardou writes: > @@ -1418,6 +1418,11 @@ static var_t *declare_var(attr_list_t *attrs, > decl_spec_t *decl_spec, const decl >type_t *func_type = decl ? decl->func_type : NULL; >type_t *type = decl_spec->type; > > + /* In case of a range attribute, duplicate the type to keep trac

d3dx9_36/tests: Fix printing a NULL string

2011-08-30 Thread Joerg-Cyril . Hoehle
André Hentschel suggested: >Should stop the crash on Solaris and maybe others >-trace("parent_data = (%p) -> %s\n", parent_data, (char *)parent_data); >+trace("parent_data (%p) -> %s\n", parent_data, parent_data ? (char >*)parent_data : "(null)"); This is sooo backwards. You don't want t

Re: [PATCH 2/3] vbscript: Added SetScriptSite tests

2011-08-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13830 Your paranoid android

Re: wineview: Rename view to wineview and install it

2011-08-30 Thread Alexandre Julliard
André Hentschel writes: > i think wineview is a better name for installation > this also merges the resources I don't think we need to rename it. Also the accelerators are supposed to be translatable. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 2/3] vbscript: Added SetScriptSite tests

2011-08-30 Thread Jacek Caban
On 08/30/11 11:43, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.

Re: winelib an fpc

2011-08-30 Thread Paul Chitescu
On Tuesday 30 August 2011 01:57:30 am Reinier Napoles Martinez wrote: > >>This won't work. Simply doing a dlopen on the wine libraries won't get > >>your environment setup properly. > > what can i do then to setup the wine environment correctly > and use the wine libraries from fpc. > thanks Essen

Re: [1/5] ddraw: Introduce a function to convert a DDSURFACEDESC to a DDSURFACEDESC2

2011-08-30 Thread Stefan Dösinger
On Monday 29 August 2011 21:54:52 Stefan Dösinger wrote: > Technically that's true for this specific function since the result is only > used by our code and never the application. Yet I prefer to keep the > memset for consistency with other code that handles DDSURFACEDESC(2) > structures. I tried

Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing

2011-08-30 Thread Frédéric Delanoy
On Tue, Aug 30, 2011 at 00:34, Martin Wilck wrote: > This patch adds some tests for command line parsing and treatment > of quotes and special characters in the command line and in program > names and parameters. The .exp file was created using Win XP. > Follow-up patches will fix the marked TODOs

Re: cmd: Don't parse colons as stream separators when splitting paths.

2011-08-30 Thread Frédéric Delanoy
2011/8/30 Octavian Voicu : > 2011/8/29 Octavian Voicu >> >> Alexandre already committed the patch, so if native passes the test I can >> send a test for the next iteration. On the other hand, if native chokes on >> the colon, then we shouldn't add any testcases. If it works, might also >> throw a