A test that passes on Windows and fails on Wine is not sufficient to
motivate a change to Wine.
I think we normally consider the following factors:
* Is the change correct? If not, we should consider leaving Wine
alone, but I can imagine there being other compelling reasons, in rare
circumstances,
There was a bit of a philosophical discussion on #winehackers about the
merits of creating tests for functions that might be testing undefined
or unimportant behavior. Windows behaves one way, we behave another,
the tests measure this delta, but it's unknown if this will actually
improve a real wo
There have been a couple of replacement packages.
$ sudo apt-get build-dep wine1.3
The following packages have unmet dependencies:
ia32-libs : Depends: lib32v4l-0 but it is not going to be installed
lib32v4l-dev : Depends: libv4l-0 (= 0.8.3-2) but 0.8.5-3ubuntu1 is to be
installed
On Thu, Aug 25, 2011 at 3:31 AM, Nowres Rafid wrote:
> I want to help the wine project, any one can tell me what tasks I can start
> with.Thanks
Are there any parts of win32 that you have ever used? Those might be
good to look into if you want to code. A quick grep on the code for
FIXME or stub c
On 8/25/11 9:50 AM, Nicolas Le Cam wrote:
2011/8/25 Aric Stewart:
Ah i see what you are seeing.
I will see if that helps. However it is still strange that the tests are
all working for me and when i submit tests but not when it is submitted as a
patch.
-aric
On 8/25/11 7:47 AM, Hans Leidekke
2011/8/25 Aric Stewart :
> Ah i see what you are seeing.
>
> I will see if that helps. However it is still strange that the tests are
> all working for me and when i submit tests but not when it is submitted as a
> patch.
>
> -aric
>
> On 8/25/11 7:47 AM, Hans Leidekker wrote:
>>
>> On Thu, 2011-0
The error message you have got because you are trying to run a corrupted or
missing d3dx9.dll file. Windows displays the above message when system
unable to run d3dx9.dll file. To fix the issue, you can restore it. Here is
the link to download d3dx9.dll file.
http://www.d3dx9.net
After download t
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=13713
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=13711
Your paranoid android
Ah i see what you are seeing.
I will see if that helps. However it is still strange that the tests
are all working for me and when i submit tests but not when it is
submitted as a patch.
-aric
On 8/25/11 7:47 AM, Hans Leidekker wrote:
On Thu, 2011-08-25 at 07:38 -0500, Aric Stewart wrote:
On 08/25/11 14:40, Octavian Voicu wrote:
On Thu, Aug 25, 2011 at 3:31 PM, Jacek Caban wrote:
As long as there is a failure (like in your patch), I'm fine with return.
Just let's not pretend it's somehow valid run with skip() call. Also testing
hres is cleaner than unk, IMO.
Yeah, the skip will
On Thu, 2011-08-25 at 07:38 -0500, Aric Stewart wrote:
> Yes, it depends on if it is a RTL or LTR string. That is correct.
What I meant is that it does not always match the right hand operand
in the test condition.
On Thu, Aug 25, 2011 at 3:31 PM, Jacek Caban wrote:
> As long as there is a failure (like in your patch), I'm fine with return.
> Just let's not pretend it's somehow valid run with skip() call. Also testing
> hres is cleaner than unk, IMO.
Yeah, the skip will only come after a failure because unk
Yes, it depends on if it is a RTL or LTR string. That is correct.
-aric
On 8/25/11 7:30 AM, Hans Leidekker wrote:
On Thu, 2011-08-25 at 07:15 -0500, Aric Stewart wrote:
"should return piX=0 not 0"? seems like 0 == 0 to me. They are both
int values...
That test doesn't look right:
win
Bernhard Loos writes:
> +/* below is the query interface to a table */
> +
> typedef struct tagMSIROWENTRY
> {
> -UINT value;
> +UINT values[0];
Zero-size arrays are not portable.
--
Alexandre Julliard
julli...@winehq.org
On 08/25/11 14:09, Octavian Voicu wrote:
On Thu, Aug 25, 2011 at 2:59 PM, Jacek Caban wrote:
Those are failures on Wine, so tests are fine, it's Wine that needs fixing.
Yes, the first test usually fails on Wine. Nonetheless, if
CoCreateInstance fails for whatever reason (like it happens on tha
On Thu, 2011-08-25 at 07:15 -0500, Aric Stewart wrote:
> "should return piX=0 not 0"? seems like 0 == 0 to me. They are both
> int values...
That test doesn't look right:
winetest_ok(piX == offsets[iCP+1],
"ScriptCPtoX trailing: iCP=%d should return piX=%d not %d\n",
iCP, offsets[iCP
25 aug 2011 kl. 14:12 skrev Frédéric Delanoy:
> On Thu, Aug 25, 2011 at 03:31, Nowres Rafid wrote:
>> Hello,
>>
>> I want to help the wine project, any one can tell me what tasks I can start
>> with.Thanks
>>
>> Nowres rafid
>
> There are many things that can be done to help Wine: bug hunting
I don't get this.
I do the test locally, they all pass.
I submit it directly to testbot and they all pass.
I submit the patch and i get these nonsense failures.
"should return piX=0 not 0"? seems like 0 == 0 to me. They are both
int values...
Is this just testbot being strange?
-aric
On 8
On Thu, Aug 25, 2011 at 03:31, Nowres Rafid wrote:
> Hello,
>
> I want to help the wine project, any one can tell me what tasks I can start
> with.Thanks
>
> Nowres rafid
There are many things that can be done to help Wine: bug hunting,
fixes, triage (http://bugs.winehq.org/), test applications f
On Thu, Aug 25, 2011 at 2:59 PM, Jacek Caban wrote:
> Those are failures on Wine, so tests are fine, it's Wine that needs fixing.
Yes, the first test usually fails on Wine. Nonetheless, if
CoCreateInstance fails for whatever reason (like it happens on that
NT4 machine, for example), running the r
On 08/25/11 13:55, Octavian Voicu wrote:
On Thu, Aug 25, 2011 at 2:38 PM, Jacek Caban wrote:
Where do you get such a broken installation from? I don't see such failures
on test.winehq.org.
Hi Jacek,
It's not only me, see [1]. It fails every time on WOW64 giving
something like this [2].
It's a
On Thu, Aug 25, 2011 at 2:38 PM, Jacek Caban wrote:
> Where do you get such a broken installation from? I don't see such failures
> on test.winehq.org.
Hi Jacek,
It's not only me, see [1]. It fails every time on WOW64 giving
something like this [2].
It's a different crash from the win64 one (whi
Hi Octavian,
On 08/25/11 13:26, Octavian Voicu wrote:
Prevents a crash on WOW64, where CLSID_InternetExplorer\LocalServer32
points to nonexistent iexplore.exe in Program Files (x86) folder.
Where do you get such a broken installation from? I don't see such
failures on test.winehq.org.
Jacek
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=13705
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=13699
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=13700
Your paranoid android
In the wvifil32 resources we have this string:
IDS_AVISTREAMFORMAT "%s %s #%d"
I see no way in which this can be meaningfully translated and many ways
in which translators can mess it up. It was introduced in this
commit:
commit 4c04e1fd8773fd7b8884a8c5fead4609869bf4ab
Author: Mi
In the resources, and hence in the PO files we have this string:
IDS_TITLEFMT"%s - %s"
I see no way in which this can be meaningfully translated and many ways
in which translators can mess it up. Yet it was moved there by this
commit:
commit 1573382dd6baa48bb825c26faef96a
Hi,
what happened to this patch?
There are already 2 bug reports about crashes in ReleaseBuffer that may be
cured by this, even though
the underlying problem is #28093 (GetCurrentPadding would not return "buffer
full" on
native, so the SW would not attempt to Release 0 bytes which causes
winec
On 8/25/2011 08:49, Bernhard Loos wrote:
---
dlls/ntdll/tests/pipe.c |2 +-
server/named_pipe.c |6 ++
2 files changed, 7 insertions(+), 1 deletions(-)
@@ -964,6 +964,12 @@ DECL_HANDLER(create_named_pipe)
struct unicode_str name;
struct directory *root = NULL;
+
On Thu, Aug 25, 2011 at 01:06, Octavian Voicu wrote:
> 2011/8/25 Frédéric Delanoy :
>> + const WCHAR inW[] = {'i','n'};
>> + const WCHAR doW[] = {'d','o'};
> ...
>
> Hello,
>
> After these patches get in, it might be a good idea to make all these
> strings static. Even if they are const, the com
32 matches
Mail list logo
