Re: [PATCH 3/6] server: sharing 0 is not allowed for named pipes

2011-08-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13692 Your paranoid android

Tasks request

2011-08-24 Thread Nowres Rafid
Hello, I want to help the wine project, any one can tell me what tasks I can start with.Thanks Nowres rafid

Re: [1/7] cmd: Fix FOR tab handling (try 3)

2011-08-24 Thread Octavian Voicu
2011/8/25 Frédéric Delanoy : > +  const WCHAR inW[] = {'i','n'}; > +  const WCHAR doW[] = {'d','o'}; ... Hello, After these patches get in, it might be a good idea to make all these strings static. Even if they are const, the compiler still needs to generate code to initialize the arrays on the s

Re: (resend)usp10/test: test ScriptXtoX on an RTL set with differring cChars and cGlyphs

2011-08-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13681 Your paranoid android

Age of Empires online

2011-08-24 Thread Laurens van Oorschot
Hello, I am trying to get Age of Empires online to work under wine, unfortunately I'm having a problem getting the Windows Market Place to work. Any suggestions? Kind Regards Laurens van Oorschot

Re: gsoc mentor summit

2011-08-24 Thread Jeremy White
fyi, Bradley writes the following missive, which I am just relaying: --- TL;DR Version: *Now* is the time for all your org-admins to be in touch with Conservancy. Please make sure that org-admins (a) read everything below, (b) get in touch with me right away, and (c) talk to me dire

Re: winemenubuilder: appbundle patch 20110618

2011-08-24 Thread Steven Edwards
Hi Per, On Sat, Aug 20, 2011 at 9:39 AM, Per Johansson wrote: >> I've finally gotten back around to hacking the *.app bundle support in >> winemenubuilder and come close to having something that mostly works. > > I'm attaching my current work, since I'm not sure when I'll work on it next > (migh

Re: kernel32: Fix writing to a pipe in WriteConsoleW().

2011-08-24 Thread Eric Pouech
> > > > so it would make more sense to simply let WriteConsoleW fail when > > is_console_handle(hConsoleOutput) is FALSE ? > > (similar functions as WriteConsoleA, ReadConsoleA/W should be protected > > the same way) > > Currently only three APIs in console.c check is_console_handle(): > VerifyCon

Re: kernel32: Fix writing to a pipe in WriteConsoleW().

2011-08-24 Thread Francois Gouget
On Tue, 23 Aug 2011, Eric Pouech wrote: > Le 03/08/2011 18:07, Francois Gouget a écrit : > > WriteFile() checks if the handle corresponds to the console and if it > > does invokes WriteConsoleA(). This barely escaped an infinite loop but > > messed up the string encoding as CP_UNIXCP is usually di

Re: po: Update French translation

2011-08-24 Thread Frédéric Delanoy
On Wed, Aug 24, 2011 at 14:44, Francois Gouget wrote: > On Wed, 24 Aug 2011, Frédéric Delanoy wrote: > [...] >>  #: notepad.rc:81 >> -#, fuzzy >>  msgid "" >>  "You did not enter any text.\n" >>  "Please type something and try again." > > This one is wrong because you forgot to add the trailing do

Re: Assorted spelling fixes.

2011-08-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13664 Your paranoid android

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Francois Gouget
On Wed, 24 Aug 2011, Francois Gouget wrote: [...] > From my understanding, in this case using a simple skip() means that > anyone running WineTest on Windows in a non-administrator account will > get a test failure. Since we don't seem to have a policy mandating that > WineTest be run in an admi

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Francois Gouget
On Wed, 24 Aug 2011, GOUJON Alexandre wrote: > On 08/24/2011 10:47 AM, Hans Leidekker wrote: > > No, win_skip is for behavior observed on Windows that Wine should not > > emulate, which is not the case here. > Is there any page on the wiki explaining the meaning of broken(), skip(), > win_skip() ?

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Hans Leidekker
On Wed, 2011-08-24 at 15:11 +0200, Francois Gouget wrote: > From my understanding, in this case using a simple skip() means that > anyone running WineTest on Windows in a non-administrator account will > get a test failure. Since we don't seem to have a policy mandating that Quite the opposite

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread GOUJON Alexandre
On 08/24/2011 10:47 AM, Hans Leidekker wrote: No, win_skip is for behavior observed on Windows that Wine should not emulate, which is not the case here. Is there any page on the wiki explaining the meaning of broken(), skip(), win_skip() ? Because your definition of win_skip is my definition of

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Francois Gouget
On Wed, 24 Aug 2011, Hans Leidekker wrote: > On Wed, 2011-08-24 at 03:26 -0500, Austin English wrote: > > > Shouldn't that be a win_skip()? Wine always runs as administrator, and > > if the process is running as a limited user, something may be broken? > > Unless you're preparing for when wine su

Re: [PATCH 1/8] msi: use an array instead of a hashtable for WHEREVIEW

2011-08-24 Thread Alexandre Julliard
Bernhard Loos writes: > +static UINT add_row(MSIWHEREVIEW *wv, UINT val) > { > -MSIHASHENTRY *new = msi_alloc(sizeof(MSIHASHENTRY)); > -MSIHASHENTRY *prev; > +MSIROWENTRY *new; > + > +if (wv->reorder_size <= wv->row_count) > +{ > +MSIROWENTRY **new_reorder; > +

Re: mmdevapi: Do not mix frames and bytes.

2011-08-24 Thread Andrew Eikum
(Resending to include wine-devel. I'm still adjusting to mutt, sorry.) On Wed, Aug 24, 2011 at 11:32:05AM +0200, joerg-cyril.hoe...@t-systems.com wrote: > what happened to that patch? Sometimes things just get lost, especially with large disturbances like AJ being on vacation. Just resend it. >

Re: po: Update French translation

2011-08-24 Thread Francois Gouget
On Wed, 24 Aug 2011, Frédéric Delanoy wrote: [...] > #: notepad.rc:81 > -#, fuzzy > msgid "" > "You did not enter any text.\n" > "Please type something and try again." This one is wrong because you forgot to add the trailing dot to the translation. -- Francois Gouget http://f

Re: [2/8] cmd: Fix FOR tab handling

2011-08-24 Thread Alexandre Julliard
Frédéric Delanoy writes: > @@ -902,8 +902,10 @@ void WCMD_for (WCHAR *p, CMD_LIST **cmdList) { >WIN32_FIND_DATAW fd; >HANDLE hff; >int i; > - const WCHAR inW[] = {'i', 'n', ' ', '\0'}; > - const WCHAR doW[] = {'d', 'o', ' ', '\0'}; > + const WCHAR inW[]= {'i', 'n', ' ', '\0'};

Re: [PATCH] ntdll: provide a timestamp debug channel, which prints a millisecond resolution timestamp in front of debug output, very useful to debug deadlocks

2011-08-24 Thread Dmitry Timoshkov
Bernhard Loos wrote: > ret = wine_dbg_printf( "%7u:", (unsigned int) (now.QuadPart - > server_start_time) / 1 ); Probably you want to use wine_dbgstr_longlong() here. -- Dmitry.

Documenting WineTest best practices

2011-08-24 Thread Francois Gouget
I have done a major refresh of the Wiki's conformance tests page. http://wiki.winehq.org/ConformanceTests One aspect I would like to document there is the best practices mostly for people running WineTest unattended on their computer. For instance I recently learned that one should really make

Re: ntdll: provide a timestamp debug channel, which prints a millisecond resolution timestamp in front of debug output, very useful to debug deadlocks

2011-08-24 Thread Alexandre Julliard
Bernhard Loos writes: > @@ -164,8 +165,16 @@ static int NTDLL_dbg_vlog( enum __wine_debug_class cls, > struct __wine_debug_chan > /* only print header if we are at the beginning of the line */ > if (info->out_pos == info->output || info->out_pos[-1] == '\n') > { > +if (TRA

mmdevapi: Do not mix frames and bytes.

2011-08-24 Thread Joerg-Cyril . Hoehle
Hi, what happened to that patch? Perhaps there is too much understatement in the subject line. If you look at the code, not the patch, you'll see that alsa_wrap_buffer is called twice, once with bytes, once with frames. That is obviously wrong, so my patch puts frames everywhere. Regards, Jörg

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.

2011-08-24 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> The font would have to be generated from the .sfd. > > Is that because it's in a binary form? .sfd is just another font storage > format, > it's not the "source" by any means, nor it makes editing the file any easier. It makes the diffs

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.

2011-08-24 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > The font would have to be generated from the .sfd. Is that because it's in a binary form? .sfd is just another font storage format, it's not the "source" by any means, nor it makes editing the file any easier. > A better approach is > probably to create it on the fly

Re: [4/4] urlmon: Added basic MapUrlToZoneEx2 implementation

2011-08-24 Thread Jacek Caban
Hi Thomas, On 08/24/11 01:58, Thomas Mullaly wrote: +static HRESULT map_uri_to_zone(IUri *uri, DWORD *zone) +{ +HRESULT hres; +BOOL has_scheme = FALSE; + +*zone = URLZONE_INVALID; + +hres = IUri_HasProperty(uri, Uri_PROPERTY_SCHEME_NAME,&has_scheme); +if(hres != S_OK) +

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Hans Leidekker
On Wed, 2011-08-24 at 03:26 -0500, Austin English wrote: > Shouldn't that be a win_skip()? Wine always runs as administrator, and > if the process is running as a limited user, something may be broken? > Unless you're preparing for when wine supports non-admin mode.. :) No, win_skip is for behavi

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.

2011-08-24 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Dmitry Timoshkov wrote: > >> > Alexandre Julliard wrote: >> > >> > > > + >> > > > +/* @makedep: wine_test.ttf */ >> > > > +wine_test.ttf RCDATA wine_test.ttf >> > > >> > > How was this file created? >> > >> > It was created with fontforge. Here it is in a .sfd form

Re: winhttp: Support setting WinHttpRequestOption_EnableRedirects.

2011-08-24 Thread Jacek Caban
Hi Hans, On 08/24/11 10:23, Hans Leidekker wrote: +EnterCriticalSection(&request->cs ); +switch (option) +{ +case WinHttpRequestOption_EnableRedirects: +{ +if (V_BOOL(&value ) == VARIANT_TRUE) You shouldn't compare bools like that, it should be if(V_BOOL(&value)).

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Austin English
On Wed, Aug 24, 2011 at 03:22, Hans Leidekker wrote: > --- >  dlls/msi/tests/action.c |    6 ++ >  1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/dlls/msi/tests/action.c b/dlls/msi/tests/action.c > index aac601f..90832af 100644 > --- a/dlls/msi/tests/action.c > +++ b/dlls/ms

mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.

2011-08-24 Thread Joerg-Cyril . Hoehle
Hi, what about this patch of mine? #77305 is about to fall off the queue. 3 weeks later, it's still ok AFAICT. >This will need another sweep in some future after somebody tests what happens >in EXCLUSIVE mode about which MSDN says the pointer is set to null. >I only tested SHARED mode with standa

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.

2011-08-24 Thread GOUJON Alexandre
On 08/24/2011 07:16 AM, Dmitry Timoshkov wrote: That doesn't explain why the test case (!) sent one month ago has not been accepted and has stalled in the pending state while many other patches have been committed before and after the two weeks vacation time. I'd guess that's because my mailing a

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command

2011-08-24 Thread Frédéric Delanoy
2011/8/24 Frédéric Delanoy : > On Wed, Aug 24, 2011 at 08:20, Christian Costa wrote: >> -- >> >> I added a stub last year to make an installer work but didn't know the >> command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So >> here is a patch that takes what's in cmd.exe an