Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command

2011-08-23 Thread Frédéric Delanoy
On Wed, Aug 24, 2011 at 08:20, Christian Costa wrote: > -- > > I added a stub last year to make an installer work but didn't know the > command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So > here is a patch that takes what's in cmd.exe and move it to the standalone > comma

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.

2011-08-23 Thread Dmitry Timoshkov
GOUJON Alexandre wrote: > On 08/24/2011 03:42 AM, Dmitry Timoshkov wrote: > > It's pretty disappointing to see no any reaction except the (answered) > > question above in a month. > > > Do you know AJ has been on vacation for two weeks ? > That you're not the only developer ? > That AJ has tons o

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.

2011-08-23 Thread GOUJON Alexandre
On 08/24/2011 03:42 AM, Dmitry Timoshkov wrote: It's pretty disappointing to see no any reaction except the (answered) question above in a month. Do you know AJ has been on vacation for two weeks ? That you're not the only developer ? That AJ has tons of patch to read and comment ? You should

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.

2011-08-23 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > > Alexandre Julliard wrote: > > > > > > + > > > > +/* @makedep: wine_test.ttf */ > > > > +wine_test.ttf RCDATA wine_test.ttf > > > > > > How was this file created? > > > > It was created with fontforge. Here it is in a .sfd format just in case. > > Is there anything

Re: tools/winegcc: support a trailing / in paths to winebuild

2011-08-23 Thread Bernhard Loos
On Tue, Aug 23, 2011 at 11:20 AM, David Laight wrote: > On Mon, Aug 22, 2011 at 07:13:42PM +0200, Bernhard Loos wrote: >> On Mon, Aug 22, 2011 at 7:02 PM, Jerome Leclanche wrote: >> > That's to be fixed in bash-completion, not winegcc... >> >> Uhm, what's wrong with bash-completation? -B takes a

Re: André Hentschel : po: German translations added and updated.

2011-08-23 Thread André Hentschel
Am 23.08.2011 22:57, schrieb Francois Gouget: > > On Mon, 22 Aug 2011, Alexandre Julliard wrote: > >> Module: wine >> Branch: master >> Commit: aeb9f621292dec7a6366209106468da8d0371684 >> URL: >> http://source.winehq.org/git/wine.git/?a=commit;h=aeb9f621292dec7a6366209106468da8d0371684 > > I

Re: André Hentschel : po: German translations added and updated.

2011-08-23 Thread Francois Gouget
On Mon, 22 Aug 2011, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: aeb9f621292dec7a6366209106468da8d0371684 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=aeb9f621292dec7a6366209106468da8d0371684 I think the string below should really be translated. It's dis

Re: kernel32: Fix writing to a pipe in WriteConsoleW().

2011-08-23 Thread Eric Pouech
Le 03/08/2011 18:07, Francois Gouget a écrit : WriteFile() checks if the handle corresponds to the console and if it does invokes WriteConsoleA(). This barely escaped an infinite loop but messed up the string encoding as CP_UNIXCP is usually different from CP_ACP. --- I noticed this issue while

Summer is ending, you can't procrastinate any more, come to Wineconf!

2011-08-23 Thread Jeremy White
So summer holidays are rapidly ending, and before you know it, Wineconf will be upon us - just 5 more weeks until Wineconf! The full details, including the hotel information, is available here: http://wiki.winehq.org/WineConf2011 For those of you that have asked for sponsorship, I'm trying to c

Re: [5/5] ddraw: Emulate a 24 bit depth format without stencil or padding

2011-08-23 Thread Henri Verbeet
On 23 August 2011 11:48, Stefan Dösinger wrote: > 3) Advertise both X8D24 versions if X8D24 is supported. > Change ddraw_surface_init to make sure we don't have to convert back from > the wined3d format. Then, once device_parent_create_depth_stencil is gone, > we'll never convert wined3d depth for

Re: [3/7] msi: Don't create a temporary copy of the package. (try 2)

2011-08-23 Thread Octavian Voicu
On Tue, Aug 23, 2011 at 3:13 PM, Joris Huizer wrote: > On 08/23/2011 11:45 AM, Hans Leidekker wrote: > >> +if (!strcmpiW( package, unsquashed )) >> > > I'm confused about the last part of the function. > I think if the comparison between 'package' and 'unsquashed' fails, you > want to return a

Re: Hebrew: update

2011-08-23 Thread Aric Stewart
On 8/23/11 8:38 AM, Francois Gouget wrote: [...] Wineconsole does not support Hebrew or Arabic script out of the box, there are several fonts that should be installed in order to enable that, AFAIK Arabic displayed in the right order but the letters are not joined, I can check that and get back t

Re: Hebrew: update

2011-08-23 Thread Yaron Shahrabani
On Tue, Aug 23, 2011 at 4:38 PM, Francois Gouget wrote: > On Tue, 23 Aug 2011, Yaron Shahrabani wrote: > [...] > >> Wineconsole does not support Hebrew or Arabic script out of the box, >> there are several fonts that should be installed in order to enable >> that, AFAIK Arabic displayed in the rig

Re: Hebrew: update

2011-08-23 Thread Francois Gouget
On Tue, 23 Aug 2011, Yaron Shahrabani wrote: [...] > > > Since we have certain RTL issues with the Linux kernel (Hebrew is > > > displayed in reverse) we discourage the translators to translate > > > strings that would probably appear there > > > > How does the Linux kernel get involved? Using Wine

Re: Hebrew: update

2011-08-23 Thread Francois Gouget
On Tue, 23 Aug 2011, Yaron Shahrabani wrote: [...] > > On Tue, 23 Aug 2011, Yaron Shahrabani wrote: > > > > > On Mon, Aug 22, 2011 at 3:25 PM, Francois Gouget wrote: > > > > > > > > >  #: crypt32.rc:182 > > > > >  msgid "KeyID=" > > > > > -msgstr "" > > > > > +msgstr "KeyID=" > > > > > > > > I thi

Re: [7/7] msi/tests: Clean up local packages.

2011-08-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13580 Your paranoid android

Re: [3/7] msi: Don't create a temporary copy of the package. (try 2)

2011-08-23 Thread Joris Huizer
Just an implementation detail I noticed: On 08/23/2011 11:45 AM, Hans Leidekker wrote: + +static UINT get_registered_local_package( const WCHAR *product, const WCHAR *package, WCHAR *localfile ) +{ +MSIINSTALLCONTEXT context; +HKEY product_key, props_key; +WCHAR *registered_package

Re: [6/7] msi: Remove icons when the product is uninstalled.

2011-08-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13579 Your paranoid android

Re: Hebrew: update

2011-08-23 Thread Yaron Shahrabani
On Tue, Aug 23, 2011 at 12:43 PM, Francois Gouget wrote: > > Did you really mean not to CC wine-devel? Right sorry... > > > On Tue, 23 Aug 2011, Yaron Shahrabani wrote: > > > On Mon, Aug 22, 2011 at 3:25 PM, Francois Gouget wrote: > > > > > > >  #: crypt32.rc:182 > > > >  msgid "KeyID=" > > > > -

Re: [7/7] msi/tests: Clean up local packages.

2011-08-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13576 Your paranoid android

Re: [6/7] msi: Remove icons when the product is uninstalled.

2011-08-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13575 Your paranoid android

Re: [PATCH 2/4] shell32: Register standard known folders on initialization.

2011-08-23 Thread Alexandre Julliard
Mariusz Pluciński writes: > +for(i=0; i < sizeof(CSIDL_Data)/sizeof(CSIDL_Data[0]); ++i) > +{ > +if(!CSIDL_Data[i].szValueName) > +{ > +FIXME("known folder %d has no value name, ignoring\n", i); > +continue; > +}

Re: [5/5] ddraw: Emulate a 24 bit depth format without stencil or padding

2011-08-23 Thread Stefan Dösinger
Am 23.08.2011 um 00:53 schrieb Henri Verbeet: > On 23 August 2011 00:38, Stefan Dösinger wrote: >>> How is WINED3DFMT_D24_UNORM different from WINED3DFMT_X8D24_UNORM? >> It has a different application-visible ddraw format. > I'm not sure that really justifies adding duplicate formats in > wined3d

Re: tools/winegcc: support a trailing / in paths to winebuild

2011-08-23 Thread David Laight
On Mon, Aug 22, 2011 at 07:13:42PM +0200, Bernhard Loos wrote: > On Mon, Aug 22, 2011 at 7:02 PM, Jerome Leclanche wrote: > > That's to be fixed in bash-completion, not winegcc... > > Uhm, what's wrong with bash-completation? -B takes a directory as an > argument so bash adds a slash during autoc