When running a test bot, one notices flaky things that
otherwise happen too seldom to be noticed.
For instance, today, the buildbot crashed once during wineboot:
wine: created the configuration directory
'/home/dank/wineslave.dir/sandbox/slave/runtests/build/wineprefix'
fixme:storage:create_stora
André Hentschel wrote:
> +if(!InternetCrackUrlA(pi->lpszProxy, 0, 0, &UrlComponents)) return;
> +heap_free(pi);
If InternetCrackUrlA() fails pi is leaked.
--
Dmitry.
2011/8/19 Frédéric Delanoy :
> The last [10/10] patch was the cause. I sent an updated version.
Hmm. You sent 10/10 before 1/10. My patch series recognizer
rejected the series. It would be hard to fix. Let's see if we can
live with the rule "patch series must be sent in order".
> I wonder how
On Fri, Aug 19, 2011 at 02:46, Nowres Rafid wrote:
>
else {
+pos = string;
/* Remove any double quotes, which may be in the
middle, eg. cd "C:\Program Files"\Microsoft is ok */
-pos = string;
> That's a gratuitous change
while (*command) {
if (*command != '"')
You should use @space@ elements to make the tests clearer.
Also, you shouldn't use (retry) in your patch mail subject, but rather (try N)
2011/8/19 Dan Kegel :
> Hi Frédéric,
> your patch series seems to have failed the cmd tests:
>
> batch.c:259: Test failed: unexpected char 0x53 position 0 in line 301
> (got 'Syntax error', wanted '1')
> batch.c:259: Test failed: unexpected char 0x31 position 0 in line 302
> (got '1', wanted '3')
>
On 08/20/2011 12:15 AM, Scott Ritchie wrote:
> I'm trying to cleanup a bit of a packaging mess whereby Wine currently
> pulls in 250 or so gstreamer plugins.
>
> Which ones are actually useful for applications? Do we even know?
>
> Thanks,
> Scott Ritchie
>
>
wine-gstreamer only needs decoding and
Hi Seth,
yum, yes, please send me your changes. I'd be happy to add gentoo
prerequisite handling.
I don't think the build slave needs any incoming connections at all,
it always connects to the master, not the other way around.
What graphics card do you have?
- Dan
On Fri, Aug 19, 2011 at 3:32 P
Dan,
Great job with this. I've got a 64bit E6300 I can setup as a build slave.
It's up and on 24/7 folding (gpu) so the cpu sites mostly idle. I've already
adapted your scripts to work with gentoo/funtoo. I just replaced the apt-get
with emerge commands. I can send those changes to you if you want
I'm trying to cleanup a bit of a packaging mess whereby Wine currently
pulls in 250 or so gstreamer plugins.
Which ones are actually useful for applications? Do we even know?
Thanks,
Scott Ritchie
> just sent a patch doing that.
Looks good to me, thanks!
--Juan
Am 18.08.2011 22:50, schrieb Juan Lang:
>> Is the ProxyServer specified as an URL? If yes then use the proper API
>> to dissect the URL instead of cobbling something together.
>
> Just to follow up in this idea, you could use InternetCrackUrl.
> mshtml delay loads wininet, but it also loads urlmon
2011/8/19 Frédéric Delanoy :
>> Incidentally, that 'Syntax error' probably should go to stderr;
>> and since the cmd tests ignore stderr, that might fix your failure.
>
> They should eventually go to stderr, but I wouldn't change them right now.
> The current tests can run successfully only if the
2011/8/19 Dan Kegel :
> Hi Frédéric,
> your patch series seems to have failed the cmd tests:
>
> batch.c:259: Test failed: unexpected char 0x53 position 0 in line 301
> (got 'Syntax error', wanted '1')
> batch.c:259: Test failed: unexpected char 0x31 position 0 in line 302
> (got '1', wanted '3')
>
On Wed, 2011-08-17 at 08:19 -0700, Dan Kegel wrote:
> On Wed, Aug 17, 2011 at 8:17 AM, Dan Kegel wrote:
> > Hi Nowres,
> > did you run the regedit tests,
> > cd programs/regedit/tests
> > make test
> > after that change? Here it fails with
> > regedit.c:384: Test failed: regedit not availabl
Hi Frédéric,
your patch series seems to have failed the cmd tests:
batch.c:259: Test failed: unexpected char 0x53 position 0 in line 301
(got 'Syntax error', wanted '1')
batch.c:259: Test failed: unexpected char 0x31 position 0 in line 302
(got '1', wanted '3')
batch.c:259: Test failed: unexpected
On Fri, Aug 19, 2011 at 2:20 PM, Stefan Dösinger wrote:
> Am 19.08.2011 um 14:04 schrieb Michael Mc Donnell:
>> Ok I see that in dlls/d3d9/tests/buffers.c. So it will fail to lock on
>> Win7 if D3DLOCK_DISCARD is specified and the vertex buffer wasn't
>> created with D3DUSAGE_DYNAMIC?
> Yes, unles
Hi,
here's just for fun an interpretation of some test data:
A native machine passes all my tests in shared mode.
In exclusive mode, that machine behaves like PulseAudio in Wine now :-)
render.c:797: BufferSize 21846 frames
render.c:799: Test failed: BufferSize 21846 too small for duration at ra
Maarten Lankhorst wrote:
[nice to hear from you]
>> IMHO AudioClient_Stop must not map to
>> snd_pcm_drop. It is more like snd_pcm_pause. Or perhaps simply lead
>> ALSA into an underrun.
>afaict pause, with reset mapped to drop,
Indeed. But I believe I need a fallback because ALSA says that
p
(The buildbot worked its way back to the day after Alexandre went on vacation.
Even though the patches are old, git hasn't changed, so they ought to
apply still.)
It didn't apply here:
patching file dlls/shlwapi/string.c
patching file dlls/shlwapi/tests/string.c
Hunk #1 FAILED at 622.
Hunk #2 FAI
On Fri, Aug 19, 2011 at 2:15 AM, Nowres Rafid wrote:
>> That means that your patch series
>> [1/2] cmd: fixing an error with redirection operators
>> [2/2] cmd/tests: fixing an error with redirection operators (updating
>> test results)
>>
>> is incorrect, since tests marked todo_wine will fail af
On 08/19/2011 01:30 PM, joerg-cyril.hoe...@t-systems.com wrote:
> Reece,
>
> I wrote the text in a hurry and forgot that Wine results
> are most interesting to me with my patch applied.
>
> Please use my patch with something like:
> WINETEST_DEBUG=3 WINEDEBUG=warn+alsa wine mmdevapi_test.exe render
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 19.08.2011 um 14:04 schrieb Michael Mc Donnell:
> Ok I see that in dlls/d3d9/tests/buffers.c. So it will fail to lock on
> Win7 if D3DLOCK_DISCARD is specified and the vertex buffer wasn't
> created with D3DUSAGE_DYNAMIC?
Yes, unless Microsoft chan
On Thu, Aug 18, 2011 at 8:05 PM, Stefan Dösinger wrote:
> Hi,
>
> I noticed one small issue:
> On Saturday 13 August 2011 12:22:03 Michael Mc Donnell wrote:
>> +static HRESULT convert_vertex_buffer(ID3DXMesh *mesh_dst, ID3DXMesh
> *mesh_src)
>> ...
>> + hr = mesh_dst->lpVtbl->LockVertexBuffer(m
Reece,
I wrote the text in a hurry and forgot that Wine results
are most interesting to me with my patch applied.
Please use my patch with something like:
WINETEST_DEBUG=3 WINEDEBUG=warn+alsa wine mmdevapi_test.exe render
>render.c:897: Test failed: Position 24000 too far after 200ms
That's not
Compiler warnings - clang/gcc would be nice I guess. I have a terrible
10-line shell script to generate reports, I sent two to the mailing
list in the past.
As for hosting a buildbot, I can probably do that, I have an ubuntu
x64 8-core i7 machine on a static IP with 98% uptime. Can you ping me
on
For those interested in coccinelle
Michael Stefaniuc wrote:
> On 08/18/2011 03:29 PM, Dan Kegel wrote:
>> Seems to cause a test failure here?
> Argh, indeed!
> - (IUnknown*)&runtimes[i]
> + &runtimes->ICLRRuntimeInfo_iface
>
> The array subscript got dropped and that wasn't a manual change. Need
On 19/08/2011 03:14, Dan Kegel wrote:
Hi Nowres,
it's awesome that you're digging into cmd like this!
The rule with Wine is that
Each patch you submit shall pass tests.
That means that your patch series
[1/2] cmd: fixing an error with redirection operators
[2/2] cmd/tests: fixing an error wi
Hi Steven, list,
I tried both AppleScript and shell script versions and AppleScript doesn't
really add anything, so it's probably better to go with shell script and
generate the bundle manually.
I'll see if I can help smoothing it out.
--
Pelle Johansson
17 aug 2011 kl. 00.06 skrev Steven Edwa
29 matches
Mail list logo
