Re: w9x testbot state?

2011-08-06 Thread James McKenzie
On 8/3/11 7:10 AM, Maarten Lankhorst wrote: On 08/01/2011 07:12 PM, joerg-cyril.hoe...@t-systems.com wrote: Hi, what happened to the w9x test bots? I'd like them to run some kernel32 tests. Testbot says "offline". They were hosted at Gé's house. Testbot can no longer reach them. Are there

Re: [rfc] WINE_ONCE macro

2011-08-06 Thread Dan Kegel
On Sat, Aug 6, 2011 at 2:58 PM, Sven Baars wrote: > Alexandre turned it down last time: > > http://www.winehq.org/pipermail/wine-devel/2011-January/088123.html Ah, foo, now I remember. Thanks... - Dan

Re: [rfc] WINE_ONCE macro

2011-08-06 Thread Sven Baars
On 06-08-2011 at 11:12 PM, Dan Kegel wrote: There are many places in the wine source that use a static to print a fixme just once. Here's a simple macro that combines declaring and testing the static. Thoughts? Hi Dan, Alexandre turned it down last time: http://www.winehq.org/pipermail/wine

[rfc] WINE_ONCE macro

2011-08-06 Thread Dan Kegel
There are many places in the wine source that use a static to print a fixme just once. Here's a simple macro that combines declaring and testing the static. Thoughts? diff --git a/include/wine/debug.h b/include/wine/debug.h index ba6fabe..3112401 100644 --- a/include/wine/debug.h +++ b/include/w

Printing fixme's once (was: Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9)

2011-08-06 Thread Dan Kegel
Stefan wrote: > I think there was once a discussion about a FIXME_ONCE macro that took care > of this. not sure what happened with that idea. Judging by http://source.winehq.org/git/wine.git/commitdiff/45ead7fe85e7107de91bd79a8ceeb1cb17e4f71d, Alexandre's preferred idiom is static BOOL fixm

Re: [5/5] shlwapi/tests: Test return value of StrFromTimeInterval with cchMax set to 0 (try2)

2011-08-06 Thread Scott Ritchie
On 08/06/2011 08:38 AM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.wineh

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-08-06 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 06.08.2011 um 15:24 schrieb Michael Mc Donnell: > I can't find any definitions of UBYTE except for one in > dlls/itss/lzx.c. The BYTE is already defined [1] as a being unsigned > so isn't that ok? Oh, I thought BYTE is signed, and I thought I used

Re: [5/5] shlwapi/tests: Test return value of StrFromTimeInterval with cchMax set to 0 (try2)

2011-08-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13371 Your paranoid android

Re: [4/5] shlwapi/tests: Test for an unchanged buffer when cchMax=0 in StrFromTimeInterval

2011-08-06 Thread Scott Ritchie
On 08/06/2011 06:59 AM, Marcus Meissner wrote: > On Sat, Aug 06, 2011 at 06:54:48AM -0700, Scott Ritchie wrote: >> --- >> dlls/shlwapi/tests/string.c | 15 +++ >> 1 files changed, 15 insertions(+), 0 deletions(-) >> >> > >> diff --git a/dlls/shlwapi/tests/string.c b/dlls/shlwapi/tes

Re: [4/5] shlwapi/tests: Test for an unchanged buffer when cchMax=0 in StrFromTimeInterval

2011-08-06 Thread Marcus Meissner
On Sat, Aug 06, 2011 at 06:54:48AM -0700, Scott Ritchie wrote: > --- > dlls/shlwapi/tests/string.c | 15 +++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > > diff --git a/dlls/shlwapi/tests/string.c b/dlls/shlwapi/tests/string.c > index 68028d7..ecc58cc 100644 > --- a/dll

Re: configure: Disable gstreamer support if headers are not compatible with build environment. (try 2)

2011-08-06 Thread Octavian Voicu
On Sat, Aug 6, 2011 at 2:49 PM, Octavian Voicu wrote: > A proper fix would be a patch to configure.ac to detect the correct > PKG_CONFIG_PATH for the target architecture. There is also a proposed change > [1] to pkgconfig to allow you to specify the host system type for > cross-compiles, but I'm n

Re: [PATCH] gdi32: Avoid uninitialized fields in dst and src (Coverity)

2011-08-06 Thread Octavian Voicu
On Sat, Aug 6, 2011 at 1:06 PM, Marcus Meissner wrote: > src.visrect.left = src.x = 0; > src.visrect.top= src.y = 0; > These two lines become redundant after your patch. Octavian

Re: configure: Disable gstreamer support if headers are not compatible with build environment. (try 2)

2011-08-06 Thread Octavian Voicu
On Sat, Aug 6, 2011 at 12:08 AM, Alex Villací­s Lasso < a_villa...@palosanto.com> wrote: > El 02/08/11 17:38, Octavian Voicu escribió: > > When building a 32-bit wine in a 64-bit build environment with >> default glib headers (gstreamer uses glib.h), glib 64-bit types >> (such as gint64 and guint