Re: [PATCH 1/2] comctl32: Fix to ComboBoxEx processing of WM_ENABLE message (try 2)

2011-08-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13267 Your paranoid android

Re: Assorted spelling fixes.

2011-08-03 Thread James McKenzie
On 8/3/11 4:23 PM, Francois Gouget wrote: On Wed, 3 Aug 2011, Frédéric Delanoy wrote: [...] -rem Removing non-existent directory +rem Removing nonexistent directory [...] There is apparently no hard rule on the usage of hypens between 'non' and a subsequent adjective, but I've seen lots of "no

Re: dlls/tests: Assorted spelling fixes

2011-08-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13256 Your paranoid android

Re: dlls/tests: Assorted spelling fixes

2011-08-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13249 Your paranoid android

Re: dlls/tests: Assorted spelling fixes

2011-08-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13236 Your paranoid android

Re: Assorted spelling fixes.

2011-08-03 Thread Francois Gouget
On Wed, 3 Aug 2011, Frédéric Delanoy wrote: [...] > > -rem Removing non-existent directory > > +rem Removing nonexistent directory [...] > There is apparently no hard rule on the usage of hypens between 'non' > and a subsequent adjective, but I've seen lots of "non-" (sometimes > even "non ") so I

Re: cmd: mkdir: complain properly if no arg given (resending)

2011-08-03 Thread Frédéric Delanoy
On Thu, Aug 4, 2011 at 00:21, Dan Kegel wrote: > Also output the error to stderr, as native does. > > Resending to make testbot happy (first time the odd numbering confused it). You should probably send the WCMD_output_stderr implementation as a separate patch, since it's not mkdir-specific Fréd

Re: Assorted spelling fixes.

2011-08-03 Thread Frédéric Delanoy
On Wed, Aug 3, 2011 at 11:36, Francois Gouget wrote: > diff --git a/programs/cmd/tests/test_builtins.cmd > b/programs/cmd/tests/test_builtins.cmd > index eb79fb2..be1eead 100644 > --- a/programs/cmd/tests/test_builtins.cmd > +++ b/programs/cmd/tests/test_builtins.cmd > @@ -530,7 +530,7 @@ mkdir f

Re: oleaut32/tests: Skip tests if typelib can't be registered

2011-08-03 Thread André Hentschel
Am 03.08.2011 22:14, schrieb Octavian Voicu: > 2011/8/3 André Hentschel mailto:n...@dawncrow.de>> > > a80a90fcb7f917ef4ec999007f5a49eb63d1b0a6 > > > Doesn't look like a valid commit... which one is that? > > Octavian sry, i mean 862cc73fb4cd8e6c8d454ab822a70a5072cb5dda -- Best Regards,

Re: oleaut32/tests: Skip tests if typelib can't be registered

2011-08-03 Thread Octavian Voicu
2011/8/3 André Hentschel > a80a90fcb7f917ef4ec999007f5a49eb63d1b0a6 > Doesn't look like a valid commit... which one is that? Octavian

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.

2011-08-03 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > Alexandre Julliard wrote: > > > > + > > > +/* @makedep: wine_test.ttf */ > > > +wine_test.ttf RCDATA wine_test.ttf > > > > How was this file created? > > It was created with fontforge. Here it is in a .sfd format just in case. Is there anything else that prevents ac

Re: net: Convert to Unicode. (take 2)

2011-08-03 Thread Francois Gouget
On Wed, 3 Aug 2011, Alexandre Julliard wrote: [...] > We should stick to the API. Sooner or later we'll need to make > WriteConsole behave like Windows. That was my leaning too but it's good to have confirmation. Patches follow. -- Francois Gouget http://fgouget.free.fr/

Re: NtQuerySystemInformation and exposing unix_pid

2011-08-03 Thread Paul Vriens
On 08/03/2011 07:13 PM, Alexandre Julliard wrote: Paul Vriens writes: Hi, I would like to add some per-process information in NtQuerySystemInformation with respect to cpu-usage. The wine server doesn't currently expose the unix_pid so I can't use /proc//* information. Would it be ok to expo

Re: user32: fix potential crash when loading unsupported files (with tests)

2011-08-03 Thread Alexandre Julliard
Vitaly Perov writes: > @@ -1002,6 +1002,54 @@ static unsigned char gif4pixel[42] = { > 0x02,0x00,0x00,0x02,0x03,0x14,0x16,0x05,0x00,0x3b > }; > > +/* Corrupted images */ > +/* 1x1 pixel corrupted bmp */ > +static unsigned char corruptedbmpimage[38] = { > +0x42,0x4d,0x26,0x00,0x01,0x00,0x00,0x

Re: net: Convert to Unicode. (take 2)

2011-08-03 Thread Alexandre Julliard
Francois Gouget writes: > So the question is: Do we care if these applications don't work right on > Windows if their output is redirected? > > Or from a different point of view: Should these applications take > advantage of this Wine-specific behavior or stick to the letter of the > API? We

Re: NtQuerySystemInformation and exposing unix_pid

2011-08-03 Thread Alexandre Julliard
Paul Vriens writes: > Hi, > > I would like to add some per-process information in > NtQuerySystemInformation with respect to cpu-usage. > > The wine server doesn't currently expose the unix_pid so I can't use > /proc//* information. > > Would it be ok to expose the unix_pid in some of the server

Re: net: Convert to Unicode. (take 2)

2011-08-03 Thread Francois Gouget
On Wed, 3 Aug 2011, Francois Gouget wrote: [...] > I sort of modeled this after ipconfig's ipconfig_vprintfW() function. > However that function has a WriteFile() fallback in case WriteConsole() > fails. But I don't see what's the point of this or when using > WriteFile() instead of WriteConsole

Re: oleaut32: Skip tests if interface is not accessable

2011-08-03 Thread Alexandre Julliard
André Hentschel writes: > The hole test_ function depends on succeeding here (more than i thought first) Actually you'd want to skip even more than that, the real failure is earlier. -- Alexandre Julliard julli...@winehq.org

Re: wined3d: Update GLSL spam filter for recent fglrx versions.

2011-08-03 Thread Matteo Bruni
2011/8/3 Stefan Dösinger : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Am 03.08.2011 um 17:31 schrieb Matteo Bruni: > >> Users tend to get confused by those messages on the terminal. Since we >> already have code to filter irrelevant GLSL compiler messages, let's >> update it. > I think

Re: [PATCH 1/3] winmm: Memory related fixes.

2011-08-03 Thread Alexandre Julliard
joerg-cyril.hoe...@t-systems.com writes: > Hi, > > IMHO, this does not need further splitting. We have had that big 100KB patch > which introduced > the bugs and don't need N patches of a fraction that size each to fix them > one by one. > Instead, we need to find and remove them quickly so use

Re: wined3d: Update GLSL spam filter for recent fglrx versions.

2011-08-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 03.08.2011 um 17:31 schrieb Matteo Bruni: > Users tend to get confused by those messages on the terminal. Since we > already have code to filter irrelevant GLSL compiler messages, let's > update it. I think the plan a while ago was to remove the s

Re: w9x testbot state?

2011-08-03 Thread Maarten Lankhorst
On 08/01/2011 07:12 PM, joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > what happened to the w9x test bots? I'd like them to run some kernel32 tests. > Testbot says "offline". > They were hosted at Gé's house. Testbot can no longer reach them. ~Maarten

Re: w9x testbot state?

2011-08-03 Thread Frédéric Delanoy
On Wed, Aug 3, 2011 at 10:09, wrote: > Hi, > > Stefan Dösinger wrote: >>> Testbot says "offline". >>I think we killed w9x testing a few months ago > > That's not exactly right.  While test.winehq.org no more performs daily w9x > tests for Wine, the w9x machines have been available on testbot.wine

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-08-03 Thread Henri Verbeet
Well yes, it's implementation defined, not undefined. The point is that there isn't necessarily any relation to endianness. Just use shifts and masks.

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-08-03 Thread max
On 08/03/2011 05:18 AM, Stefan Dösinger wrote: On Wednesday 03 August 2011 10:56:25 Michael Mc Donnell wrote: It is *technically* undefined, but all the compilers I have tested it on do the same thing. There may be a future compiler that behaves differently. You may get away with it right now,

Re: mmdevapi tests

2011-08-03 Thread Andrew Eikum
On 08/02/2011 09:30 AM, joerg-cyril.hoe...@t-systems.com wrote: I've a couple of mmdevapi tests that I could put into submittable form soon, however there's one big problem: There are three different backends (ALSA, OSS, MacOS) and each one needs a different set of todo_wine. How to deal with th

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-08-03 Thread Stefan Dösinger
On Wednesday 03 August 2011 10:56:25 Michael Mc Donnell wrote: > It is *technically* undefined, but all the compilers I have tested it > on do the same thing. There may be a future compiler that behaves differently. You may get away with it right now, but it will cause pain in the rear sooner or l

w9x testbot state?

2011-08-03 Thread Joerg-Cyril . Hoehle
Hi, Stefan Dösinger wrote: >> Testbot says "offline". >I think we killed w9x testing a few months ago That's not exactly right. While test.winehq.org no more performs daily w9x tests for Wine, the w9x machines have been available on testbot.winehq when you select "show all VMs" -- and they are s

Re: [PATCH 1/2] comctl32: Fix to ComboBoxEx processing of WM_ENABLE message

2011-08-03 Thread Nikolay Sivov
On 8/3/2011 02:49, Richard Bradbrook wrote: comctl32: Fix to ComboBoxEx processing of WM_ENABLE message This fixes some of the issues mentioned in bug 27920 Hi, Richard. Few comments: +static LRESULT COMBOEX_Enable (COMBOEX_INFO *infoPtr, BOOL enable) +{ +TRACE("hwnd=%p, enable=%s\n", inf