Re: [1/2] cmd/tests: Add FOR /D tests (try 2)

On Fri, Jul 29, 2011 at 22:05, Octavian Voicu wrote: > 2011/7/29 Frédéric Delanoy : >> +rem for /d %%i in (ba*) do echo %%i>> tmp >> +rem sort < tmp >> +rem del tmp > > I believe you can also use this syntax [put for instruction in > parentheses, add | sort at the end]: > (for ... ...) | sort Yea

Re: [1/2] cmd/tests: Add FOR /D tests (try 2)

2011/7/29 Frédéric Delanoy : > +rem for /d %%i in (ba*) do echo %%i>> tmp > +rem sort < tmp > +rem del tmp I believe you can also use this syntax [put for instruction in parentheses, add | sort at the end]: (for ... ...) | sort Btw, it's a horrible hack, but until you'll have a wine sort you can

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2, resend)

On Fri, Jul 29, 2011 at 9:55 AM, Paul Vriens wrote: >> +        win_skip("Not on WOW64, skipping test.\n"); > > Why a win_skip()? Isn't a normal skip() more appropriate? Year, you're right, win_skip didn't make much sense. I was only thinking at GetSystemWow64DirectoryW when I wrote that (which,

Re: [PATCH 2/9] wscript: added arguments.c; implemented Host_get_Arguments (resend)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13001 Your paranoid android

Re: [PATCH 4/9] wscript: implemented Arguments2_Count (resend)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13003 Your paranoid android

Re: [PATCH 6/9] wscript: implemented Host_get_Interactive (resend)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13005 Your paranoid android

Re: [PATCH 7/9] wscript: implemented Host_put_Interactive (resend)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13006 Your paranoid android

Re: [PATCH 8/9] wscript: implemented Host_get_Application (resend)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13007 Your paranoid android

Re: [PATCH 5/9] wscript: implemented Arguments2_get_length (resend)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13004 Your paranoid android

Re: git send-email (Was: Re: [PATCH 1/2] winmm: Trivial code simplifications and fixes.)

On 29 July 2011 16:38, Michael Stefaniuc wrote: > If you're new to (Wine) development or you do a lot of janitorial work I > would actually recommend to *avoid* git send-email. See it as an > opportunity to look again at your patch when you manually submit it. I think that's orthogonal. I certainl

git send-email (Was: Re: [PATCH 1/2] winmm: Trivial code simplifications and fixes.)

Henri Verbeet wrote: > On 29 July 2011 09:46, wrote: >> these fixes all trivial errors I mentioned recently but one, plus a few ones >> I discovered since then. >> > These need to be separate patches, of course. I'd also encourage > everyone to just use git send-email for sending patches. As alw

Re: patch for dlls/gdi32/dib.c: fixes crash

Am Donnerstag, 28. Juli 2011 schrieb Huw Davies: > On Thu, Jul 28, 2011 at 04:14:56PM +0200, Wolfgang Walter wrote: > > I think that > > > > bitmapinfo_from_user_bitmapinfo() > > > > is the real culprit. I think colors gets to big (> 256) and therefore the > > size for the memcpy. > > Hopefully

Re: [PATCH 1/2] winmm: Trivial code simplifications and fixes.

On 29 July 2011 09:46, wrote: > these fixes all trivial errors I mentioned recently but one, plus a few ones > I discovered since then. > These need to be separate patches, of course. I'd also encourage everyone to just use git send-email for sending patches.

Re: [PATCH 2/8] ntdll: rework the handling of server ioctls a little bit to avoid a crash with later patches

Bernhard Loos writes: > On Thu, Jul 28, 2011 at 7:46 PM, Alexandre Julliard > wrote: >> Bernhard Loos writes: >> >>> @@ -1273,10 +1282,16 @@ static NTSTATUS server_ioctl_file( HANDLE handle, >>> HANDLE event, >>> >>>      if (wait_handle) >>>      { >>> -        NtWaitForSingleObject( wait_ha

Re: [5/7] cmd/tests: Add FOR /D tests

2011/7/28 Alexandre Julliard : > Frédéric Delanoy writes: > >> --- >>  programs/cmd/tests/test_builtins.cmd     |    6 ++ >>  programs/cmd/tests/test_builtins.cmd.exp |   11 +++ >>  2 files changed, 17 insertions(+), 0 deletions(-) > > It fails here: > > ../../../tools/runtest -q -P wi