Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2, resend)

2011-07-28 Thread Paul Vriens
On 07/29/2011 01:29 AM, Octavian Voicu wrote: +else +win_skip("Not on WOW64, skipping test.\n"); Why a win_skip()? Isn't a normal skip() more appropriate? -- Cheers, Paul.

Re: ancient email messages being sent, or at least archived, again?

2011-07-28 Thread Austin English
On Jul 28, 2011 10:50 PM, "Dan Kegel" wrote: > > What's with messages like > http://www.winehq.org/pipermail/wine-bugs/2011-July/285020.html ? > I was doing Bugzilla maintenance and cleared the unsent email queue. -Austin

ancient email messages being sent, or at least archived, again?

2011-07-28 Thread Dan Kegel
What's with messages like http://www.winehq.org/pipermail/wine-bugs/2011-July/285020.html ?

Re: Nvidia GeForce GTX560 Ti detection fix

2011-07-28 Thread Henri Verbeet
On 28 July 2011 22:46, wrote: > This patch fixes the problem that a GeForce GTX560 Ti GPU is not being > detected in current build. (http://bugs.winehq.org/show_bug.cgi?id=27924) > The change itself looks reasonable enough, though I don't have the hardware to verify the strings. Please use git to

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2)

2011-07-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12984 Your paranoid android

Re: [PATCH 2/8] ntdll: rework the handling of server ioctls a little bit to avoid a crash with later patches

2011-07-28 Thread Bernhard Loos
On Thu, Jul 28, 2011 at 7:46 PM, Alexandre Julliard wrote: > Bernhard Loos writes: > >> @@ -1273,10 +1282,16 @@ static NTSTATUS server_ioctl_file( HANDLE handle, >> HANDLE event, >> >>      if (wait_handle) >>      { >> -        NtWaitForSingleObject( wait_handle, (options & >> FILE_SYNCHRONOUS

Re: user32/tests: Don't treat a button as a dialog (valgrind)

2011-07-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12982 Your paranoid android

Re: make "bisected" a keyword in bugzilla?

2011-07-28 Thread Austin English
On Sun, May 23, 2010 at 22:45, Wolfram Sang wrote: >> Probably it would be better to add a field for commit id that caused >> a regression just like there is one for url/keywords instead of inventing >> new keywords. So a 'regression' with a commit id would automatically mean >> 'bisected'. That w

Re: bugzilla: merge OS X/Windows OS versions

2011-07-28 Thread Jerome Leclanche
On Thu, Jul 28, 2011 at 7:40 PM, Austin English wrote: > This was mentioned a while back, though I can't find the reference on > wine-devel, perhaps it was in #winehackers... > > Anyway, would anyone be opposed to merging the Mac OS X versions (and > possibly the Windows versions) in the OS field

bugzilla: merge OS X/Windows OS versions

2011-07-28 Thread Austin English
This was mentioned a while back, though I can't find the reference on wine-devel, perhaps it was in #winehackers... Anyway, would anyone be opposed to merging the Mac OS X versions (and possibly the Windows versions) in the OS field in Bugzilla? We don't differentiate any other OS, and for Windows

Re: gsoc mentor summit

2011-07-28 Thread Juan Lang
>> I'd be interested if there's a space going free. We just get to send 2 >> mentors though as I understand it? > Yes. I'd be interested as well, that's why I started this thread. I've been > there already in 2009, so if anyone else wants to go I'd be happy to yield. Whoever does go, I'll be happy

Re: NtQuerySystemInformation needs a little bit more flesh for SystemProcessorPerformanceInformation

2011-07-28 Thread Juan Lang
> This Reserved1[0] is the DPC Time but I'm wondering what values from > /proc/stat to use here (remainder[0] is I/O wait). We could always make up > something of course but being accurate would be nicer. DPC Time has no equivalent in /proc/stat. It's an NT thing. Making something up is the only

Re: [PATCH 2/8] ntdll: rework the handling of server ioctls a little bit to avoid a crash with later patches

2011-07-28 Thread Alexandre Julliard
Bernhard Loos writes: > @@ -1273,10 +1282,16 @@ static NTSTATUS server_ioctl_file( HANDLE handle, > HANDLE event, > > if (wait_handle) > { > -NtWaitForSingleObject( wait_handle, (options & > FILE_SYNCHRONOUS_IO_ALERT), NULL ); > -status = io->u.Status; > +sta

Re: [5/7] cmd/tests: Add FOR /D tests

2011-07-28 Thread Alexandre Julliard
Frédéric Delanoy writes: > --- > programs/cmd/tests/test_builtins.cmd |6 ++ > programs/cmd/tests/test_builtins.cmd.exp | 11 +++ > 2 files changed, 17 insertions(+), 0 deletions(-) It fails here: ../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p cmd.exe_test.ex

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths.

2011-07-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12975 Your paranoid android

Re: patch for dlls/gdi32/dib.c: fixes crash

2011-07-28 Thread Huw Davies
On Thu, Jul 28, 2011 at 04:14:56PM +0200, Wolfgang Walter wrote: > I think that > > bitmapinfo_from_user_bitmapinfo() > > is the real culprit. I think colors gets to big (> 256) and therefore the > size > for the memcpy. Hopefully http://source.winehq.org/patches/data/77076 should fix th

Re: patch for dlls/gdi32/dib.c: fixes crash

2011-07-28 Thread Wolfgang Walter
Am Mittwoch, 27. Juli 2011 schrieben Sie: > On Wed, Jul 27, 2011 at 6:44 PM, Wolfgang Walter wrote: > > -    char src_bmibuf[FIELD_OFFSET( BITMAPINFO, bmiColors[256] )]; > > -    BITMAPINFO *src_info = (BITMAPINFO *)src_bmibuf; > > -    char dst_bmibuf[FIELD_OFFSET( BITMAPINFO, bmiColors[256] )];

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-07-28 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 26.07.2011 um 11:29 schrieb Michael Mc Donnell: >> Duplicating the code for 16 and 32 bit indices looks a bit ugly. Maybe you >> can use inline functions to read and write values from the proper buffer? >> The other possibility, which the ddraw b

Re: ieframe: Moved ie.c tests to ieframe

2011-07-28 Thread Jacek Caban
On 07/28/11 13:45, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: ieframe: Moved ie.c tests to ieframe

2011-07-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12968 Your paranoid android

Re: ieframe: Moved ie.c tests to ieframe

2011-07-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12967 Your paranoid android

Re: Bug status transitions ~ bug 27908

2011-07-28 Thread Alexandre Julliard
Austin English writes: > In the case of bug 27908, there was no release yet, and I don't think > it's unreasonable for a user to report bugs that are in the latest > release. Building from git is a time/space consuming pain for most > users. If a user reports a bug in a very old release, it's not