Re: msvcrt/tests: remove unused assignments (LLVM/Clang)

2011-07-25 Thread Frédéric Delanoy
On Tue, Jul 26, 2011 at 03:48, Austin English wrote: > -- > -Austin Already sent similar patches. Not sure AJ likes those.

Re: [PATCH 3/4] ntdll: implement the NamedPipeConfiguration value for the FilePipeLocalInformation class of NtQueryInformati

2011-07-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12805 Your paranoid android

Re: [PATCH 1/4] server, ntdll: get rid of the blocking parameter for ioctls. blockingness depends on the overlapped flag for

2011-07-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12803 Your paranoid android

Re: [PATCH 2/4] kernel32, ntdll, server: implement permission checks for named pipes

2011-07-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12804 Your paranoid android

Re: Questions on WINE releases and stability

2011-07-25 Thread Vitaliy Margolen
On 07/25/2011 11:54 AM, lo...@museresearch.com wrote: - Does the development branch of WINE go through a battery of tests before it is posted? What kind of criteria has to be met before a development release is made available on the main page? Each applied patch have to compile and pass all conf

d3d8/tests: make sure to use return values (LLVM/Clang)

2011-07-25 Thread Austin English
-- -Austin diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index 9a4369b..d159a52 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -1050,6 +1050,7 @@ static void test_reset(void) hr = IDirect3DDevice8_GetRenderTarget(device1, &surface); ok(SUCCEEDE

Re: comdlg32/tests: make sure to use a return value (LLVM/Clang)

2011-07-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12798 Your paranoid android

Re: Updated Clang static analysis results / Valgrind update

2011-07-25 Thread Austin English
On Sat, Jul 2, 2011 at 19:15, Austin English wrote: > Web space usage was getting a bit high, so I've uploaded a tarball to > a file download service: > http://www.sendspace.com/file/5hot36 > > austin@aw21 ~ $ sha1sum scan-build-2011-07-02.tar.bz2 > ac3cb3920ef97641fff1f5376f8136cef01f15bf  scan-b

I need someone to present at the Desktop summit in my steed (Berlin)

2011-07-25 Thread Scott Ritchie
External events are preventing me from leaving the country these next few weeks, and I'll be missing the Desktop Summit in Berlin on Monday, Aug 8th. This is the venue to talk to our friends responsible for Freedesktop.org, Gnome, KDE, Unity, and others. https://www.desktopsummit.org/program http

Re: cmd/tests: Add tests for stdout redirection and appending operators

2011-07-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12796 Your paranoid android

Re: [PATCH] mmdevapi: Try loading multiple audio drivers from the registry

2011-07-25 Thread Octavian Voicu
On Tue, Jul 26, 2011 at 12:46 AM, Andrew Eikum wrote: +for(p = driver_name; p; p = next + 1){ +next = strchrW(p, ','); +if(next) +*next = '\0'; + +if(load_driver(p)) +return TRUE; + +

Re: Questions on WINE releases and stability

2011-07-25 Thread Stefan Dösinger
On Monday 25 July 2011 19:54:00 lo...@museresearch.com wrote: > - Does the development branch of WINE go through a battery of tests before > it is posted? What kind of criteria has to be met before a development > release is made available on the main page? Every git revision has to pass the wine

Re: [PATCH 1/3] wineoss.drv: Attempt to verify that the system is actually running OSS

2011-07-25 Thread Alexandre Julliard
Andrew Eikum writes: > Mm, don't see much of a difference between this and an ordered list in > the code like we are using now. This also doesn't solve the original > problem of a broken OSS continuing to fail to load even if the user > explicitly requests OSS in the registry. The difference is

Re: [PATCH 1/3] wineoss.drv: Attempt to verify that the system is actually running OSS

2011-07-25 Thread Andrew Eikum
On 07/25/2011 12:33 PM, Alexandre Julliard wrote: Andrew Eikum writes: On 07/25/2011 09:09 AM, Alexandre Julliard wrote: It's not the driver's business to check the configuration key. If there's really a need to know if some other driver was configured, this info should be passed from the dri

Re: Questions on WINE releases and stability

2011-07-25 Thread Jerome Leclanche
On Mon, Jul 25, 2011 at 6:54 PM, wrote: > - It's my understanding that the stable branch only has select features > and patches ported over (from the wiki: "..with only minimal changes > merged in").  Would this mean that if I compared a stable release with a > development release from around the

Questions on WINE releases and stability

2011-07-25 Thread louis
Hi, I am a developer for a product which makes heavy use of WINE. Right now, we're deciding which newer version of WINE to go to, and I thought the wine-devel community might have some insight. I did read the WineReleaseCriteria entry on the wiki, but still have some questions. If anyone could

Re: [PATCH 1/3] wineoss.drv: Attempt to verify that the system is actually running OSS

2011-07-25 Thread Alexandre Julliard
Andrew Eikum writes: > On 07/25/2011 09:09 AM, Alexandre Julliard wrote: >> It's not the driver's business to check the configuration key. If >> there's really a need to know if some other driver was configured, this >> info should be passed from the driver loader. But it would be preferable >> t

Wine Gecko 1.3-beta1

2011-07-25 Thread Jacek Caban
Hi all, I've just uploaded a new Wine Gecko beta package. It's a bit earlier than we usually updated the package, but it's part of the plan. The last release was the most successful ever - we've successfully avoided regressions and fixed existing bugs. The fact that we had long (over month) beta p

Re: [PATCH 4/4] shell32/tests: Add verification of known folders relative paths.

2011-07-25 Thread Alexandre Julliard
Mariusz Pluciński writes: > Checks relative path for each known folder. This one crashes here: ../../../../wine/tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so ../../../../wine/dlls/shell32/tests/shellpath.c && touch shellpath.ok fixme:shell:_SHGetUserProfilePath un

Re: [3/5] msi: Don't create a temporary copy of the package.

2011-07-25 Thread Alexandre Julliard
Hans Leidekker writes: > There's no need for it now that we open the package in transacted mode. This breaks the Gecko install: fixme:msi:MSI_OpenDatabaseW open failed r = 80030005 for L"Z:\\home\\julliard\\wine\\wine\\..\\gecko\\wine_gecko-1.2.0-x86.msi" err:appwizcpl:install_file MsiInstallP

Re: [PATCH 03/10] winmm: Implement waveOut* on top of MMDevAPI

2011-07-25 Thread Andrew Eikum
On 07/25/2011 06:52 AM, joerg-cyril.hoe...@t-systems.com wrote: I spent several evenings reviewing the code, here are my findings. Thanks! Lots of good comments here. I've made notes about your suggestions to come back to later. Some specific responses follow... - Some more comments are nee

Re: [PATCH 1/3] wineoss.drv: Attempt to verify that the system is actually running OSS

2011-07-25 Thread Andrew Eikum
On 07/25/2011 09:09 AM, Alexandre Julliard wrote: It's not the driver's business to check the configuration key. If there's really a need to know if some other driver was configured, this info should be passed from the driver loader. But it would be preferable to avoid that. I see your point. T

Re: [PATCH 1/3] wineoss.drv: Attempt to verify that the system is actually running OSS

2011-07-25 Thread Alexandre Julliard
Andrew Eikum writes: > +/* Attempt to determine if we are running on OSS or ALSA's OSS compatability > + * layer. There is no official way to do that, so just check for validity > + * as best as possible, without rejecting valid OSS implementations. */ > +static BOOL verify_actually_oss(void) > +

Re: [docs] winedev: Update code columns limit (resend)

2011-07-25 Thread max
On 07/23/2011 07:05 PM, James McKenzie wrote: On 7/23/11 3:33 PM, Andrew Eikum wrote: On 07/23/2011 05:02 PM, Francois Gouget wrote: On Mon, 4 Jul 2011, André Hentschel wrote: [...] -Code is usually limited to 80 columns. This helps prevent -mailers mangling patches by line wra

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-07-25 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, A few more comments, with one day delay: > +static float max_abs_diff_vec2(D3DXVECTOR2 *v1, D3DXVECTOR2 *v2) > +{ > +float diff_x = fabs(v1->x - v2->x); > +float diff_y = fabs(v1->y - v2->y); > + > +return fmax(diff_x, diff_y); > +} f

Re: po: Use non-breaking spaces where required by the French typography rules.

2011-07-25 Thread Frédéric Delanoy
2011/7/25 Francois Gouget : > On Sun, 24 Jul 2011, Frédéric Delanoy wrote: > [...] >> Did you use thin/normal non-breaking spaces? > > I used regular non-breaking spaces. > >> Keep in mind that the space "width" and breakability rules change >> slightly between e.g. France and French-speaking Canad

Re: [PATCH 1/3] wineoss.drv: Attempt to verify that the system is actually running OSS

2011-07-25 Thread Andrew Eikum
On 07/24/2011 06:56 PM, Vitaliy Margolen wrote: On 07/22/2011 08:35 AM, Andrew Eikum wrote: This is really crude, but does seem to work. I tested it correct with just ALSA 1.0.24; ALSA 1.0.24's snd-pcm-oss and snd-pcm-mixer modules; and on OSS4.2. It was also tested by Gerald Pfeifer on FreeBSD

[PATCH 03/10] winmm: Implement waveOut* on top of MMDevAPI

2011-07-25 Thread Joerg-Cyril . Hoehle
Hi, I spent several evenings reviewing the code, here are my findings. The Good + You did it! + outer layer (wave*) uses hwave, inner layer uses device parameter (except WINMM_Pause/Reset which break this separation). + ValidateAndLock pattern + Invoking driver callbacks outside of critical

Re: [docs] winedev: Update code columns limit (resend)

2011-07-25 Thread Michael Stefaniuc
André Hentschel wrote: > Am 24.07.2011 00:02, schrieb Francois Gouget: >> On Mon, 4 Jul 2011, André Hentschel wrote: >> [...] >>> - Code is usually limited to 80 columns. This helps prevent >>> - mailers mangling patches by line wrap. Also it generally >>> + Code is usually limite

Re: Statur of DIB Engine

2011-07-25 Thread Massimo Del Fedele
Il 25/07/2011 10:20, Huw Davies ha scritto: On Sun, Jul 24, 2011 at 07:10:46PM +0300, Octavian Voicu wrote: Disclaimer: these comments are based only on what I gather from following commits and looking at the code, so can't guarantee it's 100% accurate; Huw or Alexandre would know better. This

Re: po: Use non-breaking spaces where required by the French typography rules.

2011-07-25 Thread Francois Gouget
On Sun, 24 Jul 2011, Frédéric Delanoy wrote: [...] > Did you use thin/normal non-breaking spaces? I used regular non-breaking spaces. > Keep in mind that the space "width" and breakability rules change > slightly between e.g. France and French-speaking Canada, and that some > (most?) translation

Re: Statur of DIB Engine

2011-07-25 Thread Huw Davies
On Sun, Jul 24, 2011 at 07:10:46PM +0300, Octavian Voicu wrote: > Disclaimer: these comments are based only on what I gather from > following commits and looking at the code, so can't guarantee it's > 100% accurate; Huw or Alexandre would know better. This is a good summary of where we're at - nic