Re: urlmon: Fix various typos/misspellings

2011-07-23 Thread James McKenzie
On 7/23/11 12:29 AM, Austin English wrote: 2011/7/23 Frédéric Delanoy: On Sat, Jul 23, 2011 at 02:03, Andrew Eikum wrote: On 07/22/2011 06:49 PM, Frédéric Delanoy wrote: 2011/7/22 Dan Kegel: -/* List of 3 character top level domain names Windows seems to recognize. +/* List of 3 characters t

Re: urlmon: Fix various typos/misspellings

2011-07-23 Thread James McKenzie
On 7/23/11 12:07 AM, Frédéric Delanoy wrote: On Sat, Jul 23, 2011 at 02:03, Andrew Eikum wrote: On 07/22/2011 06:49 PM, Frédéric Delanoy wrote: 2011/7/22 Dan Kegel: -/* List of 3 character top level domain names Windows seems to recognize. +/* List of 3 characters top level domain names Windo

Re: [docs] winedev: Update code columns limit (resend)

2011-07-23 Thread James McKenzie
On 7/23/11 3:33 PM, Andrew Eikum wrote: On 07/23/2011 05:02 PM, Francois Gouget wrote: On Mon, 4 Jul 2011, André Hentschel wrote: [...] -Code is usually limited to 80 columns. This helps prevent -mailers mangling patches by line wrap. Also it generally +Code is usually l

Re: [docs] winedev: Update code columns limit (resend)

2011-07-23 Thread Jerome Leclanche
I believe Julliard already mentioned the column limit was bumped up (I believe it was actually 120?). 1024 resolution isn't exactly "typical" anymore, even for laptops - most developers I know actually have more than one screen nowadays. As for terminal emulators, they may default at 80 but that ca

Re: [docs] winedev: Update code columns limit (resend)

2011-07-23 Thread Andrew Eikum
On 07/23/2011 05:02 PM, Francois Gouget wrote: On Mon, 4 Jul 2011, André Hentschel wrote: [...] - Code is usually limited to 80 columns. This helps prevent - mailers mangling patches by line wrap. Also it generally + Code is usually limited to 100 columns. It genera

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-07-23 Thread Stefan Dösinger
Hi, I just started reading this, I'll write more once I am done. Just a quick question: What do you mean with "built in function" in the comment above color_to_vector? Stefan On Friday 22 July 2011 12:56:14 Michael Mc Donnell wrote: > Here is my stab at D3DXWeldVertices in one big patch. It im

Re: [docs] winedev: Update code columns limit (resend)

2011-07-23 Thread Francois Gouget
On Mon, 4 Jul 2011, André Hentschel wrote: [...] > - Code is usually limited to 80 columns. This helps prevent > - mailers mangling patches by line wrap. Also it generally > + Code is usually limited to 100 columns. It generally I'd prefer to keep the 80 columns recommandat

Re: [2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody. (try 2)

2011-07-23 Thread Hans Leidekker
On Sat, 2011-07-23 at 16:01 +0200, Jacek Caban wrote: > > +VariantInit( &body ); > > +V_VT( &body ) = VT_ERROR; > > +hr = IWinHttpRequest_get_ResponseBody( req, &body ); > > +ok( hr == S_OK, "got %08x\n", hr ); > > +ok( V_VT( &body ) == (VT_ARRAY|VT_UI1), "got %08x\n", V_VT( &b

Re: [2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody. (try 2)

2011-07-23 Thread Jacek Caban
Hi Hans, On 07/23/11 09:52, Hans Leidekker wrote: > @@ -2107,7 +2107,7 @@ static void test_IWinHttpRequest(void) > HRESULT hr; > IWinHttpRequest *req; > BSTR method, url, response = NULL, status_text = NULL; > -VARIANT async, empty, timeout; > +VARIANT async, empty, timeout,

Re: [2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody. (try 2)

2011-07-23 Thread Hans Leidekker
On Sat, 2011-07-23 at 09:57 +0200, Marvin wrote: > === W2K8SE (32 bit winhttp) === > winhttp.c:926: Test failed: failed to receive response 12152 > winhttp.c:933: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 12019 > winhttp.c:937: Test failed: failed unexpectedly 12019 > winhttp.c:938: Tes

Re: [2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody. (try 2)

2011-07-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12710 Your paranoid android

Re: urlmon: Fix various typos/misspellings

2011-07-23 Thread Austin English
2011/7/23 Frédéric Delanoy : > On Sat, Jul 23, 2011 at 02:03, Andrew Eikum > wrote: >> On 07/22/2011 06:49 PM, Frédéric Delanoy wrote: >>> >>> 2011/7/22 Dan Kegel: > > -/* List of 3 character top level domain names Windows seems to > recognize. > +/* List of 3 characters top level

Re: urlmon: Fix various typos/misspellings

2011-07-23 Thread Frédéric Delanoy
On Sat, Jul 23, 2011 at 02:03, Andrew Eikum wrote: > On 07/22/2011 06:49 PM, Frédéric Delanoy wrote: >> >> 2011/7/22 Dan Kegel: -/* List of 3 character top level domain names Windows seems to recognize. +/* List of 3 characters top level domain names Windows seems to recog