Re: po: French translation tweaks and fixes.

2011-07-20 Thread Jerome Leclanche
> Yeah. Guess we use different denominations in my country. > Although if I were nitpicking I would use mebioctets or similar ;) 2¢: IMHO, we should use whatever unit is used by Windows native - assuming they translate it right, of course.

Re: po: French translation tweaks and fixes.

2011-07-20 Thread Frédéric Delanoy
2011/7/20 Francois Gouget : > On Wed, 20 Jul 2011, Frédéric Delanoy wrote: > [...] >>  #: shlwapi.rc:27 >>  msgid "%ld bytes" >> -msgstr "%ld bytes" >> +msgstr "%ld octets" > [...] >> Bytes and octets are different things; octets have exactly 8 bits >> while bytes can have more (or less) > > This i

Re: Experimental website for tracking translation issues

2011-07-20 Thread Frédéric Delanoy
2011/7/20 Francois Gouget : > On Wed, 20 Jul 2011, Frédéric Delanoy wrote: > [...] >> I added simple non-breaking space due to a variety of display problems >> for different apps. > > Ah, that's interesting. So not using non-breaking spaces can break > applications. I was more expecting the reverse

Re: Experimental website for tracking translation issues

2011-07-20 Thread Alexandre Julliard
Francois Gouget writes: > I think we can ignore thin non-breaking spaces like everyone else > (Gnomefr for instance). At least for now. However, based on your > previous comment and the fines.pdf report, it seems like putting > non-breaking spaces everywhere in Wine should be safe enough. > Do

Re: [PATCH 4/4] winmm: Fix check for DCB_NULL callback type

2011-07-20 Thread Michael Stefaniuc
Hello Jörg, On 07/20/2011 02:28 PM, joerg-cyril.hoe...@t-systems.com wrote: > wouldn't it be possible to add a function to the static checkers to be able > to detect static functions whose return is systematically ignored and rewrit > these and their callers to use void? > I came across another

Re: Experimental website for tracking translation issues

2011-07-20 Thread Francois Gouget
On Wed, 20 Jul 2011, Frédéric Delanoy wrote: [...] > I added simple non-breaking space due to a variety of display problems > for different apps. Ah, that's interesting. So not using non-breaking spaces can break applications. I was more expecting the reverse to happen. > In fact, it's even mor

Re: po: French translation tweaks and fixes.

2011-07-20 Thread Francois Gouget
On Wed, 20 Jul 2011, Frédéric Delanoy wrote: [...] > #: shlwapi.rc:27 > msgid "%ld bytes" > -msgstr "%ld bytes" > +msgstr "%ld octets" [...] > Bytes and octets are different things; octets have exactly 8 bits > while bytes can have more (or less) This is about the size of a file. It makes no sen

Re: [PATCH 2/2] ntdll: Set restart_scan on first call to NtQueryDirectoryFile.

2011-07-20 Thread David Laight
On Wed, Jul 20, 2011 at 07:29:13PM +0200, Alexandre Julliard wrote: > Grazvydas Ignotas writes: > > > Here is another idea: > > > > It seems getdents64 is indeed returning "." and "..", but not > > necessarily first, like Windows does. I think we could swap first 2 > > entries returned, whatever

Re: [PATCH 2/2] ntdll: Set restart_scan on first call to NtQueryDirectoryFile.

2011-07-20 Thread Alexandre Julliard
Grazvydas Ignotas writes: > Here is another idea: > > It seems getdents64 is indeed returning "." and "..", but not > necessarily first, like Windows does. I think we could swap first 2 > entries returned, whatever they are, with "." and "..". It would work > like this: > > - read the 2 first ent

Re: comctl32: Improve the stub of TaskDialogIndirect to display a simple message box pending a full implementation

2011-07-20 Thread Reece Dunn
On 20 July 2011 15:39, Jeff Latimer wrote: > This should allow more apps to run.  My mail import has blown up and I > may have messed up the format of the patch. The patch is line wrapped -- you need to send the patch as an attachment in a form that gets recognised as an octet stream (using the .

Re: Experimental website for tracking translation issues

2011-07-20 Thread Frédéric Delanoy
> Checking that ':;!?' are preceded by an unbreakable space in French > would be nice. It would not be very hard to add that check. > > But I wonder what's the official word is on unbreakable spaces. It's > quite confusing because they seem to be used both in GUI elements (e.g. > in comdlg32) and i

Re: Experimental website for tracking translation issues

2011-07-20 Thread Francois Gouget
On Wed, 20 Jul 2011, Frédéric Delanoy wrote: > On Wed, Jul 20, 2011 at 16:12, Francois Gouget wrote: > > > > I have started running a script that can check for translation issues in > > PO files against Wine's PO files. > > > > The issues it checks for include: > >  * Mismatched printf format spe

Re: po: French translation tweaks and fixes.

2011-07-20 Thread Frédéric Delanoy
2011/7/20 Francois Gouget : > --- >  po/fr.po |  108 > -- >  1 files changed, 56 insertions(+), 52 deletions(-) @@ -6857,7 +6859,7 @@ msgstr "Corbeille" #: shlwapi.rc:27 msgid "%ld bytes" -msgstr "%ld bytes" +msgstr "%ld octets" #:

Re: po: Remove English strings from the Polish translation.

2011-07-20 Thread Jacek Caban
On 07/20/11 17:33, Francois Gouget wrote: > On Wed, 20 Jul 2011, Jacek Caban wrote: > [...] >> Separator, diagram and folder are the right Polish translations (that > 'Separator' is translated to 'Odstęp' in another place. They slightly differ, it depends on context. > Would 'schemat' or 'wykres

Re: Experimental website for tracking translation issues

2011-07-20 Thread Frédéric Delanoy
On Wed, Jul 20, 2011 at 16:12, Francois Gouget wrote: > > I have started running a script that can check for translation issues in > PO files against Wine's PO files. > > The issues it checks for include: >  * Mismatched printf format specifiers. >  * Mismatched trailing ellipsis. >  * Other misma

Re: po: Remove English strings from the Polish translation.

2011-07-20 Thread Francois Gouget
On Wed, 20 Jul 2011, Jacek Caban wrote: [...] > Separator, diagram and folder are the right Polish translations (that 'Separator' is translated to 'Odstęp' in another place. Would 'schemat' or 'wykres' make sense for 'diagram'? 'folder' seems to be translated into either 'folderu' (might be a

Re: po: Remove English strings from the Polish translation.

2011-07-20 Thread Jacek Caban
Hi Francois, On 07/20/11 16:14, Francois Gouget wrote: > --- > po/pl.po | 88 > +++--- > 1 files changed, 44 insertions(+), 44 deletions(-) > Separator, diagram and folder are the right Polish translations (that happen to be identical to

Experimental website for tracking translation issues

2011-07-20 Thread Francois Gouget
I have started running a script that can check for translation issues in PO files against Wine's PO files. The issues it checks for include: * Mismatched printf format specifiers. * Mismatched trailing ellipsis. * Other mismatched trailing punctuation like full stop, question mark, space,

Re: [PATCH 2/2] ntdll: Set restart_scan on first call to NtQueryDirectoryFile.

2011-07-20 Thread Grazvydas Ignotas
Here is another idea: It seems getdents64 is indeed returning "." and "..", but not necessarily first, like Windows does. I think we could swap first 2 entries returned, whatever they are, with "." and "..". It would work like this: - read the 2 first entries to advance file pointer, but ignore t

[PATCH 4/4] winmm: Fix check for DCB_NULL callback type

2011-07-20 Thread Joerg-Cyril . Hoehle
Andrew Eikum wrote: >-if(info->flags & DCB_NULL) >+if((info->flags & DCB_TYPEMASK) == DCB_NULL) Instead of add ing a special case, I suggest to simplify the code: always call DriverCallback and declare void WINMM_NotifyClient. You currently ignore its return value anyway. Using void is co

Re: [PATCH 1/5] quartz: Rather than assert, continue when IAsyncReader::WaitForNext is flushing and break when it actually times out.

2011-07-20 Thread Alexandre Julliard
Erich Hoover writes: > @@ -479,13 +488,27 @@ static void PullPin_Thread_Process(PullPin *This) > else > { > /* FIXME: This is not well handled yet! */ > -ERR("Processing error: %x\n", hr); > if (hr == VFW_E_TIMEOUT) > { > -