Re: [4/5] dinput: Added device's owner username set by SetActionMap and the respective GetProperty to retrieve it

2011-07-08 Thread Lucas Zawacki
I realized this patch and the next are wrong and don't work, despite the tests passing. No need to bother reading them. 2011/7/8 Lucas Fialho Zawacki : > --- >  dlls/dinput/device.c         |   22 ++ >  dlls/dinput/device_private.h |    1 + >  2 files changed, 23 insertions(+),

Re: wined3d: Introduce quirk for proper RGBA16 support.

2011-07-08 Thread Dan Kegel
On Fri, Jul 8, 2011 at 10:02 PM, Dan Kegel wrote: > It seems to work... but in Mass Effect 2 Demo with the patch, > the initial cinematics (where Shepard is trying to put out > the fire, and you're prompted to answer "There's no time to argue", > are very jerky, and CPU usage is very high. > I did

re: wined3d: Introduce quirk for proper RGBA16 support.

2011-07-08 Thread Dan Kegel
It seems to work... but in Mass Effect 2 Demo with the patch, the initial cinematics (where Shepard is trying to put out the fire, and you're prompted to answer "There's no time to argue", are very jerky, and CPU usage is very high. I didn't have that problem without the patch.

Re: [PATCH 2/9] winmm: Implement waveOut* on top of MMDevAPI

2011-07-08 Thread Alexandre Julliard
Andrew Eikum writes: > +static inline HWAVE WINMM_MakeHWAVE(UINT mmdevice, BOOL is_out, UINT device) > +{ > +return (HWAVE)((1 << 15) | ((!!is_out) << 14) | (mmdevice << 8) | > device); > +} > + > +static inline void WINMM_DecomposeHWAVE(HWAVE hwave, UINT *mmdevice_index, > +BOOL *is

Re: setupapi: Fix SETUPDI_OpenDrvKey

2011-07-08 Thread Alexandre Julliard
Christian Inci writes: > @@ -3728,8 +3728,13 @@ static HKEY SETUPDI_OpenDrvKey(struct DeviceInfo > *devInfo, REGSAM samDesired) > WCHAR devId[10]; > > sprintfW(devId, fmt, devInfo->devId); > -RegOpenKeyExW(classKey, devId, 0, samDesired, &key); > -RegCloseKey(

Re: [PATCH 1/6] shell32/tests: Add tests for SHQueryRecycleBin (try 2)

2011-07-08 Thread Alexandre Julliard
Jay Yang writes: > +static void test_query_recyclebin(void) > +{ > +SHQUERYRBINFO > info1={sizeof(info1),0xdeadbeefdeadbeefLL,0xdeadbeefdeadbeefLL}; > +SHQUERYRBINFO > info2={sizeof(info2),0xdeadbeefdeadbeefLL,0xdeadbeefdeadbeefLL}; You can't use LL constants. -- Alexandre Julliard j