On 07/05/2011 07:20 PM, Austin Lund wrote:
+todo_wine ok( len>= sizeof(UNICODE_STRING) + 88 + sizeof(type_event) +
sizeof(WCHAR), "unexpected len %u\n", len );
What is that magic number "88"? If it's a size of some structure - then
please use it explicitly.
Vitaliy.
On 07/05/2011 06:18 AM, Andrew Nguyen wrote:
---
dlls/dinput/dinput_main.c | 15 -
dlls/dinput/tests/Makefile.in |1 +
dlls/dinput/tests/dinput.c| 69 +
3 files changed, 84 insertions(+), 1 deletions(-)
create mode 100644 dlls
On 5 July 2011 23:45, Travis Athougies wrote:
> Fixes bug 26583.
>
> Allows deadspace 2 to run without native dlls.
This contains no useful information about what issue this is supposed
to fix, unless you expect people to actually debug it themselves
first. And I even went through the trouble to l
I think the point is more that (in general) this kind of patch is
unlikely to be accepted unless you're actively maintaining the code.
Am 05.07.2011 20:33, schrieb Gerald Pfeifer:
On Tue, 5 Jul 2011, Alexandre Julliard wrote:
This does not fix a bug or add a feature, but it makes the coder easier
to follow. Narrower scope tends to be a good thing for variables, both
for human readers and compilers (though modern ones should no
On Tue, Jul 5, 2011 at 2:46 PM, Charles Welton wrote:
> Is there a reason why this patch and it's brother weren't merged in yet?
> This has been sitting for a few days and no comments about it yet.
>
According to
http://source.winehq.org/patches/
#75906
it has yet to be looked at by AJ.
Just
Is there a reason why this patch and it's brother weren't merged in yet?
This has been sitting for a few days and no comments about it yet.
On 06/29/2011 07:08 PM, Charles Welton wrote:
> Since the last patch spent some time without comments and wasn't
> commited, I'm resending.
>
> Try 2 because
On 07/05/2011 11:23 AM, Nikolay Sivov wrote:
On Tue, Jul 5, 2011 at 8:11 PM, Adam Martinson
wrote:
---
dlls/msxml3/nodelist.c | 33 -
dlls/msxml3/selection.c | 34 --
2 files changed, 64 insertions(+), 3 deletions(-)
+
On 07/04/2011 11:28 PM, Michał Ziętek wrote:
+ok(typeof(WScript.BuildVersion) === "number", "typeof(WScript.BuldVersion) = "
+ typeof(WScript.BuldVersion));
Patch is already committed but there is a typo here 'BuldVersion'
instead of 'BuildVersion'.
--
Cheers,
Paul.
On Tue, Jul 5, 2011 at 8:11 PM, Adam Martinson
wrote:
> ---
> dlls/msxml3/nodelist.c | 33 -
> dlls/msxml3/selection.c | 34 --
> 2 files changed, 64 insertions(+), 3 deletions(-)
>
>
+else if ( IsEqualGUID( riid, &IID_IEnu
On Tue, Jul 5, 2011 at 4:23 PM, Alexandre Julliard wrote:
> Damjan Jovanovic writes:
>
>> Changelog:
>> * winedevice: eliminate the driver_name global variable
>>
>> This is part of general refactoring to make the driver loading code reusable.
>
> Have you fixed it since last time or is it the sa
Gerald Pfeifer writes:
> This does not fix a bug or add a feature, but it makes the coder easier
> to follow. Narrower scope tends to be a good thing for variables, both
> for human readers and compilers (though modern ones should not need the
> hint).
Not necessarily, that's a matter of taste
Damjan Jovanovic writes:
> Changelog:
> * winedevice: eliminate the driver_name global variable
>
> This is part of general refactoring to make the driver loading code reusable.
Have you fixed it since last time or is it the same patch? Either way
it's still crashing.
--
Alexandre Julliard
ju
Andrew Eikum writes:
> +static MMRESULT WINMM_SendDeviceThreadMessage(UINT msg, WPARAM wp)
> +{
> +DWORD wait;
> +MMRESULT res;
> +
> +EnterCriticalSection(&g_devthread_lock);
> +
> +if(!PostThreadMessageW(g_devthread_id, msg, wp, (DWORD_PTR)&res)){
> +ERR("PostThreadMessa
On Tue, Jul 5, 2011 at 8:27 AM, Marvin wrote:
> === WXPPROSP3 (32 bit math) ===
> math.c:2275: Test failed: Got , expected 7fff or 7fff for index 18.
0.0f/0.0f = -nan (0xffc0)
-(0.0f/0.0f) = nan (0x7fc0)
msvc complains about dividing by zero. I found the following works
around the er
Hey,
On 07/05/2011 10:49 AM, Charles Davis wrote:
> On 7/5/11 2:23 AM, Damjan Jovanovic wrote:
>> On Tue, Jul 5, 2011 at 10:13 AM, Stefan Dösinger
>> wrote:
>>> Do we need full-fledged support for USB drivers for iTunes? I've been told
>>> in
>>> the past that all we need to do is properly repo
On 4 July 2011 22:32, Matteo Bruni wrote:
> +if ((!texture && old_texture_type != GL_NONE) || (texture &&
> texture->target != old_texture_type))
> +{
Actually, just thought of this now, but I'm not sure you can do this
like that. The way you're using old_texture_type it's context state,
On 4 July 2011 22:32, Matteo Bruni wrote:
> +TRACE("Dummy 2D texture %d given name %d.\n", i,
> device->dummyTextureName[i]);
This is pretty minor, but those are unsigned.
Piotr Caban writes:
> @@ -392,6 +394,15 @@ BOOL WINAPI GdiTransparentBlt( HDC hdcDest, int xDest,
> int yDest, int widthDest,
> hdcWork = CreateCompatibleDC(hdcDest);
> bmpWork = CreateCompatibleBitmap(hdcDest, widthDest, heightDest);
> oldWork = SelectObject(hdcWork, bmpWork);
>
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=12221
Your paranoid android
On 5 July 2011 10:27, Stefan Dösinger wrote:
> -/* TODO: This is not necessary if the framebuffer is the device's
> current framebuffer */
> -context_invalidate_state(context, STATE_FRAMEBUFFER,
> device->StateTable);
But you do need to invalidate if it isn't.
On 07/05/11 13:50, Alexandre Julliard wrote:
> Jacek Caban writes:
>
>> @@ -33,18 +33,16 @@
>> #ifdef INITGUID
>> #ifdef __cplusplus
>> #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8,
>> pid) \
>> -EXTERN_C const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SEL
Jacek Caban writes:
> @@ -33,18 +33,16 @@
> #ifdef INITGUID
> #ifdef __cplusplus
> #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8,
> pid) \
> -EXTERN_C const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY; \
> -EXTERN_C const PROPERTYKEY name =
Perhaps such response is due to my language barrier, but...
* On Mon, 4 Jul 2011, Keith Curtis wrote:
>
> I bring up Linus because he can focus efforts. You don't need Linus. You
> just need the same result -- focused efforts. There is another name for this
> concept -- teams. Maybe WINE needs su
Hello Misha,
Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: a6b40624dbc457ba7b0b4b307b1eb88617c67197
> URL:
> http://source.winehq.org/git/wine.git/?a=commit;h=a6b40624dbc457ba7b0b4b307b1eb88617c67197
>
> Author: Misha Koshelev
> Date: Wed Jun 29 11:16:29 2011 -0400
>
On 7/5/11 2:23 AM, Damjan Jovanovic wrote:
> On Tue, Jul 5, 2011 at 10:13 AM, Stefan Dösinger
> wrote:
>> Do we need full-fledged support for USB drivers for iTunes? I've been told in
>> the past that all we need to do is properly report the new USB drive to
>> iTunes
>> when an iPod is attached
On Tue, Jul 5, 2011 at 10:13 AM, Stefan Dösinger wrote:
> On Tuesday 05 July 2011 06:13:32 Damjan Jovanovic wrote:
>> fix requires device drivers, changes to multiple systems, knowledge of
>> Windows and Wine internals -> W is large
> Do we need full-fledged support for USB drivers for iTunes? I'v
On Tuesday 05 July 2011 06:13:32 Damjan Jovanovic wrote:
> fix requires device drivers, changes to multiple systems, knowledge of
> Windows and Wine internals -> W is large
Do we need full-fledged support for USB drivers for iTunes? I've been told in
the past that all we need to do is properly rep
28 matches
Mail list logo
