Re: urlmon: Fix incorrect pointer arithmetic (too conversative) in map_url_to_zone. (RESEND^2)

2011-06-16 Thread Gerald Pfeifer
A friendly soul pointed out to me that I had missed three(!) responses to my patch which went to wine-devel@. Sorry about that, I'll see to set up some mail filters to prevent that from happening. For the record, somehow I got mislead re the semantics of sizeof, and that after some 25 years of pr

Re: dead link on directdraw wiki to directdrawrenderer

2011-06-16 Thread James Eder
On Thu, Jun 16, 2011 at 11:16 PM, Jarek Czekalski wrote: > There's a dead link on the page http://wiki.winehq.org/DirectDraw pointing > to http://wiki.winehq.org/DirectDrawRenderer as DirectDrawRenderer. Is there > any better place for such reports? > That's just the MoinMoin Wiki software at wor

dead link on directdraw wiki to directdrawrenderer

2011-06-16 Thread Jarek Czekalski
There's a dead link on the page http://wiki.winehq.org/DirectDraw pointing to http://wiki.winehq.org/DirectDrawRenderer as DirectDrawRenderer. Is there any better place for such reports?

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-16 Thread Dylan Smith
On Thu, Jun 16, 2011 at 4:49 AM, Michael Mc Donnell wrote: > > Yeah it turned out to be a lot harder than I had expected to get all > the details correct. I have also added a check for non-zero stream > values that Dylan Smith wanted me to add. > Thanks. Looks good to me too now.

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-16 Thread Michael Mc Donnell
On Tue, Jun 14, 2011 at 1:43 PM, Stefan Dösinger wrote: > On Tuesday 14 June 2011 12:57:35 Michael Mc Donnell wrote: >> I cache the vertex declaration (D3DVERTEXELEMENT9 array) and the size >> of the vertex declaration, so that they can be used by >> GetNumBytesPerVertex and GetDeclaration when an

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-16 Thread Stefan Dösinger
On Thursday 16 June 2011 10:49:19 Michael Mc Donnell wrote: > I've added the test you outlined. It shows you're correct that > GetDeclaration only writes up to D3DDECL_END(). I've changed the > implementation so that it caches the number of elements and only > writes up to D3DDECL_END(). Looks goo

Re: [2/2] imm32: Factor out the message checks from ImmIsUIMessageA/W and fix them

2011-06-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11778 Your paranoid android

Re: [2/2] imm32: Factor out the message checks from ImmIsUIMessageA/W and fix them

2011-06-16 Thread André Hentschel
Am 16.06.2011 23:22, schrieb Marvin: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq

Re: app freezes during WM_KILLFOCUS

2011-06-16 Thread Eric Frias
On 6/16/2011 10:49 AM, Ken Thomases wrote: On Jun 16, 2011, at 9:09 AM, Eric Frias wrote: I've been chasing a bug for a few days, and finally have a good idea of what is going on. When a program brings up a modal dialog box in response to a WM_KILLFOCUS message, the program will freeze. Exc

Re: app freezes during WM_KILLFOCUS

2011-06-16 Thread Ken Thomases
On Jun 16, 2011, at 9:09 AM, Eric Frias wrote: > I've been chasing a bug for a few days, and finally have a good idea of what > is going on. When a program brings up a modal dialog box in response to a > WM_KILLFOCUS message, the program will freeze. Excellent analysis. Please file a bug repo

app freezes during WM_KILLFOCUS

2011-06-16 Thread Eric Frias
I've been chasing a bug for a few days, and finally have a good idea of what is going on. When a program brings up a modal dialog box in response to a WM_KILLFOCUS message, the program will freeze. I've attached a simple test case, all boilerplate except for: case WM_KILLFOCUS:

Re: [PATCH 1/6] server: Add server-side raw input functions definitions

2011-06-16 Thread Vincas Miliūnas
On 06/16/2011 04:26 PM, Vitaliy Margolen wrote: > On 06/15/2011 10:37 PM, Vincas Miliūnas wrote: >> On 06/16/2011 01:00 AM, Vitaliy Margolen wrote: >>> I'm not sure I like your approach and that AJ would like it either. >>> >>> Raw input is an "override" of regular messages caused by mouse/keyboard

Re: [PATCH 1/6] server: Add server-side raw input functions definitions

2011-06-16 Thread Vitaliy Margolen
On 06/15/2011 10:37 PM, Vincas Miliūnas wrote: On 06/16/2011 01:00 AM, Vitaliy Margolen wrote: I'm not sure I like your approach and that AJ would like it either. Raw input is an "override" of regular messages caused by mouse/keyboard input. Wine server already receives these messages from x11d

Re: [3/3] d3dx9/tests: Implemented tests for ID3DXLine_GetDevice.

2011-06-16 Thread Matteo Bruni
2011/6/16 Charles Welton : > > +IDirect3DDevice9_Release(return_device); > +ID3DXLine_Release(line); You could add a couple of ok() checks for the values returned by Release, to ensure nothing strange is happening. Btw, thanks for contributing. :)

Re: [1/3] d3dx9/line: Added device pointer to ID3DXLineImpl and initialize it.

2011-06-16 Thread Matteo Bruni
2011/6/16 Charles Welton : > > @@ -27,6 +27,8 @@ static const struct ID3DXLineVtbl ID3DXLine_Vtbl; > typedef struct ID3DXLineImpl { > ID3DXLine ID3DXLine_iface; > LONG ref; > + > +IDirect3DDevice9 * device; > } ID3DXLineImpl; You also have to Release() the device in ID3DXLineImpl_R

Re: strmbase: Don't use list_count() to check that a list is not empty.

2011-06-16 Thread Michael Stefaniuc
Please ignore this one. I was too excited about this easy task for coccinelle that I missed Joerg's second patch. bye michael On 06/16/2011 01:39 PM, Michael Stefaniuc wrote: --- Thanks to Joerg for the inspiration to this sort coccinelle script: @@ expression E; @@ ( - list_count(E)

Re: [PATCH 2/2] wineboot: Split prefix updating into two parts.

2011-06-16 Thread Alexandre Julliard
David Hedberg writes: > On initial prefix creation, services.exe is started before the > environment is properly set up. This leads to calls to > ExpandEnvironmentStrings failing, in turn breaking at least one > installer. This splits the creation/update process into two parts, and > sets up the