Re: [PATCH 1/6] server: Add server-side raw input functions definitions

2011-06-15 Thread Vincas Miliūnas
On 06/16/2011 01:00 AM, Vitaliy Margolen wrote: > On 06/14/2011 02:45 AM, Vincas Miliūnas wrote: >> This is a partial raw input implementation for mouse and keyboard. >> >> I've read in the IRC chat, that products of tools/make_request should >> not > be included in a patch, so I left them out. >>

Re: [2/3] cmd/tests: Add support for todo_wine constructions (try 3)

2011-06-15 Thread Frédéric Delanoy
On Thu, Jun 16, 2011 at 02:24, Octavian Voicu wrote: > Hello, > > I think Jacek was suggesting something among these lines, which does > look prettier imho (replace quoted text with following): > ... > +        }else { > +            if (!is_todo_wine) > +                ok(!err, "unexpected char

Re: [2/3] cmd/tests: Add support for todo_wine constructions (try 3)

2011-06-15 Thread Octavian Voicu
2011/6/15 Frédéric Delanoy : > +        if(err == out_nl) { > +            if (!is_todo_wine) > +                ok(0, "unexpected end of line %d (got '%.*s', wanted > '%.*s')\n", > +                   line, (int)(out_nl-out_ptr), out_ptr, > (int)(exp_nl-exp_ptr), exp_ptr); > +            else >

Re: [PATCH 1/6] server: Add server-side raw input functions definitions

2011-06-15 Thread Vitaliy Margolen
On 06/14/2011 02:45 AM, Vincas Miliūnas wrote: This is a partial raw input implementation for mouse and keyboard. I've read in the IRC chat, that products of tools/make_request should not be included in a patch, so I left them out. My first attempts were by leeching input events from queue_mo

Re: GSoC: dinput8 Action Mapping

2011-06-15 Thread Vitaliy Margolen
On 06/14/2011 10:57 AM, Lucas Zawacki wrote: keybd_event( key, 0, 0, 0); Have you tried using more meaningful parameters then 0? Yes, I've tried issuing a scan code as the second parameter, it was no use. I tried sending the keybd_event and then sending another one with KEYEVENTF_KEYUP to "emul

Re: GSoC: dinput8 Action Mapping

2011-06-15 Thread Vitaliy Margolen
On 06/14/2011 03:09 PM, Marcus Meissner wrote: On Tue, Jun 14, 2011 at 02:07:32PM -0300, Lucas Zawacki wrote: Also please implement unicode method and call it from ascii. (IDirectInput8AImpl_EnumDevicesBySemantics -> IDirectInput8WImpl_EnumDevicesBySemantics) Sorry if that's a stupid questio

Re: [PATCH 4/5] d3d9/tests: Add some tests for IDirect3DDevice9::UpdateSurface().

2011-06-15 Thread Alexandre Julliard
Henri Verbeet writes: > --- > dlls/d3d9/tests/visual.c | 188 > ++ > 1 files changed, 188 insertions(+), 0 deletions(-) I'm seeing occasional failures with this one: ../../../../wine/tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.ex

Re: [6/7] user32: Test that QS_HOTKEY is properly set and cleared.

2011-06-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11760 Your paranoid android

Re: [PATCH 1/5] shell32: Add IKnownFolderManager::RegisterFolder implementation

2011-06-15 Thread Vincent Povirk
Won't Wine pass the test only the first time it's run? 2011/6/15 Mariusz Pluciński : > To not break currently working applications/tests, I decided to implement > known folders using following schema: >  1. implement infrastructure of known folders without breaking currently > working CSIDL-based

Re: [2/7] server: Post WM_HOTKEY when a hotkey is pressed.

2011-06-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11759 Your paranoid android

Re: [1/7] server: Implement RegisterHotKey/UnregisterHotKey.

2011-06-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11758 Your paranoid android

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-15 Thread Michael Mc Donnell
On Tue, Jun 14, 2011 at 3:42 PM, Dylan Smith wrote: > On Fri, Jun 10, 2011 at 2:08 AM, Dylan Smith wrote: >> D3DXCreateMesh fails when the declaration contains a non-zero Stream >> value. I would expect UpdateSemantics to be as strict as D3DXCreateMesh, >> otherwise a test could validate the diff

Re: [PATCH 3/5] shell32: Add support of registry-registered folders to IKnownFolderManager::GetFolder

2011-06-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11756 Your paranoid android

Re: [PATCH 2/5] shell32: Add IKnownFolderManager::UnregisterFolder implementation

2011-06-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11755 Your paranoid android

Re: [PATCH 1/5] shell32: Add IKnownFolderManager::RegisterFolder implementation

2011-06-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11754 Your paranoid android

Re: [PATCH 2/4] user32/tests: Added client-side raw input functions tests (try 2)

2011-06-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11753 Your paranoid android

Re: [PATCH] winspool.drv: Removed a superflous NULL check (Coverity)

2011-06-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11752 Your paranoid android

Re: Add sub-message to a commit

2011-06-15 Thread Frédéric Delanoy
On Wed, Jun 15, 2011 at 16:28, GOUJON Alexandre wrote: > So writing commit messages with more than one line will add them (all lines > except the first one) as a 'sub' commit message. > I'm using git for another project and being able to comment a bit more a > commit is appreciable. Simply don't

Re: Add sub-message to a commit

2011-06-15 Thread GOUJON Alexandre
On 06/15/2011 04:17 PM, Andrew Eikum wrote: On 06/15/2011 09:09 AM, GOUJON Alexandre wrote: I would like to add a 'sub'-message to a commit like this one http://source.winehq.org/git/wine.git/commitdiff/dbd878639424071e1d4c6cfc9bcc75906a4b2b8a I know that I can specify this text at the begin

Re: Add sub-message to a commit

2011-06-15 Thread Andrew Eikum
On 06/15/2011 09:09 AM, GOUJON Alexandre wrote: I would like to add a 'sub'-message to a commit like this one http://source.winehq.org/git/wine.git/commitdiff/dbd878639424071e1d4c6cfc9bcc75906a4b2b8a I know that I can specify this text at the beginning of a patch I want to send to wine-patches (

Add sub-message to a commit

2011-06-15 Thread GOUJON Alexandre
Hi, I would like to add a 'sub'-message to a commit like this one http://source.winehq.org/git/wine.git/commitdiff/dbd878639424071e1d4c6cfc9bcc75906a4b2b8a I know that I can specify this text at the beginning of a patch I want to send to wine-patches (befor the '---'). But here, I'm interested

Re: [6/7] dxdiagn: Add additional adapter identifier properties for DxDiag_DisplayDevices subcontainers.

2011-06-15 Thread Andrew Nguyen
On 06/15/2011 07:30 AM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.wineh

Re: [6/7] dxdiagn: Add additional adapter identifier properties for DxDiag_DisplayDevices subcontainers.

2011-06-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11745 Your paranoid android

Re: TaskDialog implementation

2011-06-15 Thread Jeff Latimer
On 11/06/11 17:45, Hans Leidekker wrote: > On Fri, 2011-06-10 at 23:29 -0500, Vincent Povirk wrote: >> Well, I think you may be right that changing it to E_NOTIMPL at this >> point would break something and might be a bad idea. Sadly, Hans >> didn't say what the stub was originally for. Hopefully,

Re: dxdiag: Add code for XML information output

2011-06-15 Thread Andrew Nguyen
On 06/14/2011 12:18 PM, Dan Kegel wrote: > Isn't Wine was supposed to avoid non-static struct initializers? > > I think it'll get "warning: initializer element is not computable at > load time" with --std=c89 --pedantic. > > I believe you're right, and I've sent a patch that avoids the construc

Re: [PATCH 3/5] ddraw: Add iface count for IDirectSurfaceImpl.

2011-06-15 Thread Henri Verbeet
2011/6/14 : > +static void ddraw_surface_add_iface(IDirectDrawSurfaceImpl *This) > +{ > +ULONG refCount = InterlockedIncrement(&This->numIfaces); Please use wined3d code style for new code. I.e., This -> surface, refCount -> refcount, numIface -> iface_count, space after control statements, et

Re: [PATCH 2/5] ddraw: Adjust reference counts of created surfaces in ddraw_set_surface_version.

2011-06-15 Thread Henri Verbeet
2011/6/14 : > +switch(version) > +{ > +case 4: > +IDirectDrawSurface4_AddRef(&surface->IDirectDrawSurface4_iface); > +break; > +case 3: > +case 2: > +case 1: > +IDirectDrawSurface_AddRef(&surface->IDirectDrawSurface_iface)

Re: [PATCH 5/5] ddraw: Separate IDirectDrawSurface2 reference count.

2011-06-15 Thread Alexandre Julliard
rbarkaus...@codeweavers.com writes: > @@ -766,6 +766,8 @@ DestroyCallback(IDirectDrawSurface7 *surf, > > /* Destroy the surface */ > while(ref) ref = IDirectDrawSurface7_Release(surf); > +ref = Impl->ref2; > +while(ref) ref = > IDirectDrawSurface2_Release(&Impl->IDirectDrawSur

Re: deadlock in mmdevapi AudioClient_Stop (winealsa.drv/mmdevdrv.c)

2011-06-15 Thread Maarten Lankhorst
Hi Joerg, Op 15-06-11 10:00, joerg-cyril.hoe...@t-systems.com schreef: > Hi, > > please try and convince me that a deadlock cannot happen. > > http://source.winehq.org/source//dlls/winealsa.drv/mmdevdrv.c > > AudioClient_Start calls > CreateTimerQueueTimer >which creates a new thread periodic

deadlock in mmdevapi AudioClient_Stop (winealsa.drv/mmdevdrv.c)

2011-06-15 Thread Joerg-Cyril.Hoehle
Hi, please try and convince me that a deadlock cannot happen. http://source.winehq.org/source//dlls/winealsa.drv/mmdevdrv.c AudioClient_Start calls CreateTimerQueueTimer which creates a new thread periodically invoking the timer callback. The callback invokes alsa_push_buffer_data() which