Re: [4/6] winex11.drv: Grab registered hotkeys in the X server.

2011-06-14 Thread Ken Thomases
On Jun 14, 2011, at 12:40 AM, Vincent Povirk wrote: >> Is it necessary to test QS_HOTKEY in dlls/winex11.drv/event.c:filter_event, >> where QS_KEY is currently tested? If somebody calls >> MsgWaitForMultipleObjectsEx with QS_HOTKEY but not QS_KEY, shouldn't >> KeyPress events be accepted? >>

Re: [PATCH 1/6] server: Add server-side raw input functions definitions

2011-06-14 Thread Austin English
2011/6/14 Vincas Miliūnas : > This is a partial raw input implementation for mouse and keyboard. > > I've read in the IRC chat, that products of tools/make_request should not be > included in a patch, so I left them out. > > My first attempts were by leeching input events from queue_mouse_message

Re: [PATCH 6/6] user32/tests: Add client-side raw input functions tests

2011-06-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11737 Your paranoid android

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-14 Thread Michael Mc Donnell
I have added more tests and changed the UpdateSemantics implementation quite a bit. Dylan Smith made me aware that GetNumBytesPerVertex and GetDeclaration work with an invalid declaration, so I've added tests for that and changed the implementation to do the same. I cache the vertex declaration (D

Re: GSoC: dinput8 Action Mapping

2011-06-14 Thread Marcus Meissner
On Tue, Jun 14, 2011 at 02:07:32PM -0300, Lucas Zawacki wrote: > > Also please implement unicode method and call it from ascii. > > (IDirectInput8AImpl_EnumDevicesBySemantics -> > > IDirectInput8WImpl_EnumDevicesBySemantics) > Sorry if that's a stupid question, but what should I do with the > str

Re: wined3d performance patches

2011-06-14 Thread Stefan Dösinger
On Tuesday 14 June 2011 16:15:35 Henri Verbeet wrote: > Yes, but I think that by now GF7 GPUs are marginal enough that it's > not worth keeping the code around for. The Steam HW survey for example > reports over 90% D3D10+ cards. Even if it does regress something, I > think it makes more sense to t

re: dxdiag: Add code for XML information output

2011-06-14 Thread Dan Kegel
Andrew Nguyan's commit, http://www.winehq.org/pipermail/wine-cvs/2011-June/078592.html used the construct static BOOL output_xml_information(struct dxdiag_information *dxdiag_info, const WCHAR *filename) { const struct information_block { const WCHAR *tag_name; struct inf

Re: GSoC: dinput8 Action Mapping

2011-06-14 Thread Lucas Zawacki
> Also please implement unicode method and call it from ascii. > (IDirectInput8AImpl_EnumDevicesBySemantics -> > IDirectInput8WImpl_EnumDevicesBySemantics) Sorry if that's a stupid question, but what should I do with the string parameters? Is it ok to call a W function with the A parameters? >>

Re: GSoC: dinput8 Action Mapping

2011-06-14 Thread Lucas Zawacki
> keybd_event( key, 0, 0, 0); > Have you tried using more meaningful parameters then 0? Yes, I've tried issuing a scan code as the second parameter, it was no use. I tried sending the keybd_event and then sending another one with KEYEVENTF_KEYUP to "emulate" a key press and a release and still no

Re: [2/3] cmd/tests: Add support for todo_wine constructions (try 2)

2011-06-14 Thread Jacek Caban
On 6/14/11 4:48 PM, Frédéric Delanoy wrote: 2011/6/14 Jacek Caban: On 6/14/11 3:04 PM, Frédéric Delanoy wrote: 2011/6/14 Jacek Caban: On 6/14/11 10:55 AM, Frédéric Delanoy wrote: 011/6/14 Jacek Caban: Hi Frédéric, On 6/13/11 10:19 PM, Frédéric Delanoy wrote: +}else if(err) { +

Re: [2/3] cmd/tests: Add support for todo_wine constructions (try 2)

2011-06-14 Thread Frédéric Delanoy
2011/6/14 Jacek Caban : > On 6/14/11 3:04 PM, Frédéric Delanoy wrote: >> >> 2011/6/14 Jacek Caban: >>> >>> On 6/14/11 10:55 AM, Frédéric Delanoy wrote: 011/6/14 Jacek Caban: > > Hi Frédéric, > > On 6/13/11 10:19 PM, Frédéric Delanoy wrote: >> >> +        }else if(e

Re: [2/3] cmd/tests: Add support for todo_wine constructions (try 2)

2011-06-14 Thread Jacek Caban
On 6/14/11 3:04 PM, Frédéric Delanoy wrote: 2011/6/14 Jacek Caban: On 6/14/11 10:55 AM, Frédéric Delanoy wrote: 011/6/14 Jacek Caban: Hi Frédéric, On 6/13/11 10:19 PM, Frédéric Delanoy wrote: +}else if(err) { +if (!is_todo_wine) +ok(0, "unexpected char 0x%

Re: wined3d performance patches

2011-06-14 Thread Henri Verbeet
On 14 June 2011 15:26, Stefan Dösinger wrote: >> As far as I'm concerned you can just submit this. I was going to do >> this myself, looks like you got there first. > Still didn't get around to test this on geforce 7 GPUs. It's possible that the > bug this was supposed to fix is still around. > Ye

Re: [PATCH 2/2] d3dx9: Return E_FAIL for unsupported ascii effects.

2011-06-14 Thread Alexandre Julliard
Rico Schüller writes: > --- > dlls/d3dx9_36/effect.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so effect.c && touch effect.ok effect.c:52: Test failed: Got result 800040

Re: GSoC: dinput8 Action Mapping

2011-06-14 Thread Vitaliy Margolen
On 06/13/2011 04:17 PM, Lucas Zawacki wrote: > OK, so here is my second try at some patches. These mostly implement > keyboard action mapping and there's plenty of tests to go together > with it. I believe the keyboard part is pretty much done, as is > SetActionMap. Of course I'm ignoring the usern

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-14 Thread Dylan Smith
On Fri, Jun 10, 2011 at 2:08 AM, Dylan Smith wrote: > D3DXCreateMesh fails when the declaration contains a non-zero Stream > value. I would expect UpdateSemantics to be as strict as D3DXCreateMesh, > otherwise a test could validate the different behaviour. Seems like you missed this comment I mad

Re: GSoC: dinput8 Action Mapping

2011-06-14 Thread Vitaliy Margolen
On 06/12/2011 07:45 PM, Lucas Zawacki wrote: I'm having some issues with test that inject input. For instance this code ( http://pastebin.com/gan0Niqj ) works as expected under wine and wine with dinput8.dll , but fails in every windows version... I tried a version with SendInput and had the same

Re: wined3d performance patches

2011-06-14 Thread Stefan Dösinger
Hi, Thanks for the comments, I've some replies inlined below. The bigger concern I have is that the patches don't improvement by a lot yet, about 1% on AMD GPUs and 1.5% to 2.5% on Nvidia GPUs(in real apps, my benchmarks are a different issue). Because of that my plan is to do more testing and

Re: [2/3] cmd/tests: Add support for todo_wine constructions (try 2)

2011-06-14 Thread Frédéric Delanoy
2011/6/14 Jacek Caban : > On 6/14/11 10:55 AM, Frédéric Delanoy wrote: >> >> 011/6/14 Jacek Caban: >>> >>> Hi Frédéric, >>> >>> On 6/13/11 10:19 PM, Frédéric Delanoy wrote: +        }else if(err) { +            if (!is_todo_wine) +                ok(0, "unexpected char 0x%x posi

Re: wined3d performance patches

2011-06-14 Thread Henri Verbeet
I only looked over about half of this, doesn't look too crazy. You do have trailing spaces in a couple of places though. Here are some comments: > Subject: [PATCH 04/14] wined3d: Don't set FBO attachment filtering to > GL_NEAREST As far as I'm concerned you can just submit this. I was going to do

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-14 Thread Stefan Dösinger
On Tuesday 14 June 2011 12:57:35 Michael Mc Donnell wrote: > I cache the vertex declaration (D3DVERTEXELEMENT9 array) and the size > of the vertex declaration, so that they can be used by > GetNumBytesPerVertex and GetDeclaration when an invalid declaration > has been passed. In GetDeclaration: >

Re: winex11.drv: Only set MWM hints if they have not been modified

2011-06-14 Thread Alexandre Julliard
Scott Talbert writes: > Hello, > > The below patch resolves an issue (BZ# 27473) where the window manager > removes window decorations and Wine restores them. The code in the > patch checks to see whether the window decorations have been modified > and if so, > it does not modify them further.

Re: GSoC: dinput8 Action Mapping

2011-06-14 Thread Marcus Meissner
On Mon, Jun 13, 2011 at 07:17:04PM -0300, Lucas Zawacki wrote: > OK, so here is my second try at some patches. These mostly implement > keyboard action mapping and there's plenty of tests to go together > with it. I believe the keyboard part is pretty much done, as is > SetActionMap. Of course I'm

Re: [1/3] wined3d: Add GL_ARB_draw_elements_base_vertex

2011-06-14 Thread Henri Verbeet
On 13 June 2011 22:59, Stefan Dösinger wrote: > +typedef void (WINE_GLAPI *PGLFNDRAWELEMENTSBASEVERTEX)(GLenum mode, GLsizei > count, GLenum type, > +const GLvoid *indices, GLint basevertex); With the usual naming convention this would be called "PGLFNDRAWELEMENTSBASEVERTEXPROC".

Re: [2/3] cmd/tests: Add support for todo_wine constructions (try 2)

2011-06-14 Thread Jacek Caban
On 6/14/11 10:55 AM, Frédéric Delanoy wrote: 011/6/14 Jacek Caban: Hi Frédéric, On 6/13/11 10:19 PM, Frédéric Delanoy wrote: +}else if(err) { +if (!is_todo_wine) +ok(0, "unexpected char 0x%x position %d in line %d (got '%.*s', wanted '%.*s')\n", +

Re: [2/3] cmd/tests: Add support for todo_wine constructions (try 2)

2011-06-14 Thread Frédéric Delanoy
011/6/14 Jacek Caban : > Hi Frédéric, > > On 6/13/11 10:19 PM, Frédéric Delanoy wrote: >> >> +        }else if(err) { >> +            if (!is_todo_wine) >> +                ok(0, "unexpected char 0x%x position %d in line %d (got >> '%.*s', wanted '%.*s')\n", >> +                   *err, (int)(err-o

Re: GSoC: dinput8 Action Mapping

2011-06-14 Thread Lucas Zawacki
OK, so here is my second try at some patches. These mostly implement keyboard action mapping and there's plenty of tests to go together with it. I believe the keyboard part is pretty much done, as is SetActionMap. Of course I'm ignoring the username strings and all the device ownership part, I'll l