Hi Frédéric,
On 6/13/11 10:19 PM, Frédéric Delanoy wrote:
+}else if(err) {
+if (!is_todo_wine)
+ok(0, "unexpected char 0x%x position %d in line %d (got '%.*s',
wanted '%.*s')\n",
+ *err, (int)(err-out_ptr), line, (int)(out_nl-out_ptr),
+
On Jun 13, 2011, at 2:07 PM, Vincent Povirk wrote:
> <0005-winex11.drv-Grab-registered-hotkeys-in-the-X-server.txt>
Is it necessary to test QS_HOTKEY in dlls/winex11.drv/event.c:filter_event,
where QS_KEY is currently tested? If somebody calls
MsgWaitForMultipleObjectsEx with QS_HOTKEY but not
Ah, you're right. I did look at the make_requests script, but not close
enough I guess. Sorry for the noise :D
Octavian
On Tue, Jun 14, 2011 at 12:16 AM, Vincent Povirk wrote:
> As I understand it, that's done by tools/make_requests, the effect of
> which I'm not meant to include in my patches.
As I understand it, that's done by tools/make_requests, the effect of
which I'm not meant to include in my patches.
On Mon, Jun 13, 2011 at 5:06 PM, Octavian Voicu
wrote:
> Hello,
> Shouldn't you also increment SERVER_PROTOCOL_VERSION
> in include/wine/server_protocol.h?
> Octavian
>
>
>
>
Hello,
Shouldn't you also increment SERVER_PROTOCOL_VERSION
in include/wine/server_protocol.h?
Octavian
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11709
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11706
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11707
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11708
Your paranoid android
2011/6/13 Frédéric Delanoy :
>> I'd like to see the code that implements @todo_wine@ submitted
>> in the same patch as the first test that uses it.
>
> I'll probably send them in a patch series; should be good enough, no?
Yes, that's fine.
2011/6/13 Dan Kegel :
>
> In the meantime, please either send a separate patch
> that removes todo_space, or just leave todo_space alone for now.
>
>>> To avoid adding dead code, it might be nice to
>>> see a test that actually uses your new keyword.
>>
>> I've made several mkdir tests with it, and
2011/6/13 André Hentschel :
> Am 13.06.2011 00:09, schrieb Patrick Gauthier:
>> - As a result of the previous comment, there would be no point to
>> generate the manifest as a file, as it could be loaded from a
>> resource (CreateActCtx supports this), that would seem cleaner to me
>> than ge
2011/6/13 Frédéric Delanoy :
> But OK an array seemed odd to me as well... it was probably done so
> that sizeof(foo_cmd) could be used in memcp(expected_ptr, foo_cmd,
> sizeof(foo_cmd)).
Nah, looking at the code, it was so that sizeof() would not include
the trailing NUL.
But compare_string is j
On 06/13/11 06:54, André Hentschel wrote:
> IIRC the reason for the temporary file is that we can easily turn the v6
> features on and off and AFAIK we can't if we have it "hardcoded" in a
> resource.
I did not mean to hardcode as a resource of type RT_MANIFEST id 1, but
rather some random id, th
Adam Martinson writes:
> ---
> programs/wineboot/wineboot.c | 15 +--
> 1 files changed, 9 insertions(+), 6 deletions(-)
That's not going to do anything useful.
--
Alexandre Julliard
julli...@winehq.org
"Vincent Povirk" writes:
> @@ -1606,6 +1607,12 @@ LRESULT NC_HandleSysCommand( HWND hwnd, WPARAM wParam,
> LPARAM lParam )
> FreeLibrary( hmodule );
> }
> }
> +else
> +{
> +const char *argv[3] = { "xdg-screensaver", "activate", N
Mariusz Pluciński writes:
> +StringFromGUID2(folderid, sGuid, sizeof(sGuid)/sizeof(sGuid[0]));
> +hr = IKnownFolderManager_GetFolder(mgr, folderid, &folder);
> +ok(hr==S_OK, "cannot get folder (id: %s, hr: 0x%08x)\n",
> wine_dbgstr_w(sGuid), hr);
> +
> +#define CHECK_KNOWN_FOLDER(id,
Andrew Nguyen writes:
> ---
> programs/dxdiag/Makefile.in |3 +-
> programs/dxdiag/main.c | 39 +++---
> programs/dxdiag/output.c| 54
> +++
> programs/dxdiag/output.h| 49
> What does keybd_event() do?
It seems to send WM_KEY and WM_KEYDOWN events to a window
http://msdn.microsoft.com/en-us/library/ms646304%28VS.85%29.aspx
> I suspect that Windows might not hooking the keyboard for DirectInput
> usage, but attaches to some lower layer in the input stack.
I'm not f
On 06/13/11 14:02, Frédéric Delanoy wrote:
> On Mon, Jun 13, 2011 at 13:48, Jacek Caban wrote:
>> Hi Frédéric,
>>
>> On 06/12/11 23:01, Frédéric Delanoy wrote:
>>> -
>>> +is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl);
>>> +
>> There is no need to add such logic directly to test_output,
On Mon, Jun 13, 2011 at 13:48, Jacek Caban wrote:
> Hi Frédéric,
>
> On 06/12/11 23:01, Frédéric Delanoy wrote:
>> -
>> + is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl);
>> +
>
> There is no need to add such logic directly to test_output, this can be
> returned from comare_line.
Do you
Hi Frédéric,
On 06/12/11 23:01, Frédéric Delanoy wrote:
> -
> +is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl);
> +
There is no need to add such logic directly to test_output, this can be
returned from comare_line.
Jacek
On Sun, Jun 12, 2011 at 10:45:38PM -0300, Lucas Zawacki wrote:
> I'm having some issues with test that inject input. For instance this
> code ( http://pastebin.com/gan0Niqj ) works as expected under wine and
> wine with dinput8.dll , but fails in every windows version... I tried
> a version with Se
Am 13.06.2011 00:09, schrieb Patrick Gauthier:
> - As a result of the previous comment, there would be no point to
> generate the manifest as a file, as it could be loaded from a
> resource (CreateActCtx supports this), that would seem cleaner to me
> than generating temporary files.
IIRC th
2011/6/13 Dan Kegel :
> I agree @todo_space@ should go; it's never used, so it's dead code now.
> Tempting to say that removing it should be a separate patch,
> rather than combining that with adding a new feature.
Well, maybe but I didn't see its usefulness when @todo_wine@ is
introduced. It coul
25 matches
Mail list logo
