Re: comctl32/tests: Added first TaskDialog test.

2011-06-12 Thread Nikolay Sivov
On Mon, Jun 13, 2011 at 2:09 AM, Patrick Gauthier wrote: >> Hey, Patrick. >> >> Look at tests/listview.c for example to see how I load version 6 with >> activation context API. It doesn't work for some reason for XP SP3 (a >> glitch I don't understand), but works fine for everything else. All >> y

re: cmd: add support for todo_wine constructions in testing infrastructure

2011-06-12 Thread Dan Kegel
I agree @todo_space@ should go; it's never used, so it's dead code now. Tempting to say that removing it should be a separate patch, rather than combining that with adding a new feature. Since all the @keywords@ are poorly documented, I'm glad to see an unused one go. Your generic @todo_wine@ keyw

Re: d3dx9: Implement GetImageInfoFromResource(A/W) for bitmaps.

2011-06-12 Thread Charles Welton
On 06/13/2011 01:03 AM, Vincent Povirk wrote: > > You should probably call D3DXGetImageInfoFromFileInMemory for the real work. That is optimal, except I see no clear way to read the entire resource file(I'm quite new to winapi developing). LoadResource does read the file but it doesn't include th

Re: d3dx9: Implement GetImageInfoFromResource(A/W) for bitmaps.

2011-06-12 Thread Vincent Povirk
You should probably call D3DXGetImageInfoFromFileInMemory for the real work. On Sun, Jun 12, 2011 at 10:32 PM, Charles Welton wrote: > The code works except it doesn't try to detect the bitmap format. > Kindly ask for review and how to properly implement this. Should > GetDIBits be used? > > -- >

Re: GSoC: dinput8 Action Mapping

2011-06-12 Thread Lucas Zawacki
I'm having some issues with test that inject input. For instance this code ( http://pastebin.com/gan0Niqj ) works as expected under wine and wine with dinput8.dll , but fails in every windows version... I tried a version with SendInput and had the same results... Anyone has some insight on this?

Re: comctl32/tests: Added first TaskDialog test. (try 2)

2011-06-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11662 Your paranoid android

Re: comctl32/tests: Added first TaskDialog test.

2011-06-12 Thread Patrick Gauthier
> Hey, Patrick. > > Look at tests/listview.c for example to see how I load version 6 with > activation context API. It doesn't work for some reason for XP SP3 (a > glitch I don't understand), but works fine for everything else. All > you need is v6util.h. > > Without version 6 activation this tes

Re: About building test suite for Windows

2011-06-12 Thread Alexandre Julliard
Patrick Gauthier writes: > Now I am wondering if it's my system which is at fault for being badly > configured or if I should just modify winebuild so that it is more > lenient in its parsing of the target? You should fix your mingw package. We need a cpu name to know which architecture is suppo

Re: About building test suite for Windows

2011-06-12 Thread Patrick Gauthier
On 06/12/11 07:03, André Hentschel wrote: > Hi, > i had a look in my config.log and found in my 32-bit tree: > ... > configure:7022: checking for i686-mingw32msvc-gcc > configure:7052: result: no > configure:7022: checking for i586-mingw32msvc-gcc > configure:7038: found /usr/bin/i586-mingw32msvc-g

Re: About building test suite for Windows

2011-06-12 Thread Nicolas Le Cam
2011/6/12 Patrick Gauthier : > Hi, > > As I was writing my task dialog test I ran into a few problems trying to > test on Windows... > > First, I tried building it using make crosstest but I keep getting this: > > $ gmake crosstest > crosstest is not supported (mingw not installed?) > gmake: *** [c

Re: About building test suite for Windows

2011-06-12 Thread André Hentschel
Am 12.06.2011 07:54, schrieb Patrick Gauthier: > Hi, > > As I was writing my task dialog test I ran into a few problems trying to > test on Windows... > > First, I tried building it using make crosstest but I keep getting this: > > $ gmake crosstest > crosstest is not supported (mingw not instal

Re: winealsa.drv/midi.c: Adds the midi MTC Quarter Frame messages support.

2011-06-12 Thread BACRI Stephane
Hi Maarten. Thx for your answer. Joerg's comment was on the code surrounding the patch, not on the patch. That's why I did not understand that I had to correct this code. Shall I propose a new patch with these correction? Or an additional one? Or may the maintainer of winealsa.drv do so? Regards. S

Re: winealsa.drv/midi.c: Adds the midi MTC Quarter Frame messages support.

2011-06-12 Thread Maarten Lankhorst
Hey Stephane, Op 12-06-11 10:26, BACRI Stephane schreef: > Hi Maarten. > Thx for your answer. Joerg's comment was on the code surrounding the patch, > not on the patch. That's why I did not understand that I had to correct this > code. > Shall I propose a new patch with these correction? Or an add

Re: About building test suite for Windows

2011-06-12 Thread Maarten Lankhorst
Op 12-06-11 07:54, Patrick Gauthier schreef: > Hi, > > As I was writing my task dialog test I ran into a few problems trying to > test on Windows... > > First, I tried building it using make crosstest but I keep getting this: > > $ gmake crosstest > crosstest is not supported (mingw not installed?)