Lucas asked:
> Should I correct the tabs and align the
> parameters in the function prototype when I implement them?
If you do a significant rewrite of a function,
or are implementing it for the first time, I think it's
ok to use more standard code style in your new code,
or to update the style of
Just a simple doubt. Should I correct the tabs and align the
parameters in the function prototype when I implement them? For
instance SetActionMap and BuildActionMap have a lot of them.
Thanks
Am 05.06.2011 02:47, schrieb Stefan Dösinger:
> On Saturday 04 June 2011 18:24:39 André Hentschel wrote:
>
>> +case 8:
>> +STRETCH_ROW(DWORD64);
>> +break;
> 64 bit formats can be floating point formats too
On 06/06/2011 11:22 AM, Andrew Nguyen wrote:
On 06/06/2011 11:03 AM, Adam Martinson wrote:
+/* Only check this once */
+if (!cache_lastchecked)
+{
+HMODULE hadvapi32 = LoadLibraryA("advapi32.dll");
+#define ADVAPI32_GET_PROC(func) typeof(func) * p ## func =
(void*)GetProcAdd
2011/6/6 Stefan Dösinger :
...
> Furthermore, Matteo says that not calling context_apply_draw_buffers every
> time framebuffer() is run is a noticeable performance improvement too. Matteo,
> did you test this with just patch 0005, or both 0005 and 0006?
>
Actually that was with your FBO dirty pat
On 06/06/2011 10:58 AM, Michael Stefaniuc wrote:
Hello Adam,
Adam Martinson wrote:
This is to work around apps which break COM rules by not implementing
you need to follow the Wine COM guidelines:
http://wiki.winehq.org/COMGuideline
IDropTarget::QueryInterface(). Windows doesn't expose this
On 06/06/2011 11:03 AM, Adam Martinson wrote:
> +/* Only check this once */
> +if (!cache_lastchecked)
> +{
> +HMODULE hadvapi32 = LoadLibraryA("advapi32.dll");
> +#define ADVAPI32_GET_PROC(func) typeof(func) * p ## func =
> (void*)GetProcAddress(hadvapi32, #func)
> +AD
> GetVersionEx() is used in GlobalMemoryStatus() also, after these are in I'll
> pull it out and make it static, and then just do it once and use it for
> both.
Okay, thanks.
Unrelated nit on patch 3/3:
+lpmemex->ullTotalVirtual =
min((ULONG_PTR)si.lpMaximumApplicationAddress-(ULONG_PTR)si.l
On 06/06/2011 11:02 AM, Juan Lang wrote:
Ha! Quite right, thanks!
If that's what you want, then an easier check is to use GetVersion()
rather than GetVersionEx. (GetVersion()& 0x8000) is true under
Win9x, false under any NT version. See many checks like this in e.g.
kernel32.
--Juan
GetV
> Ha! Quite right, thanks!
If that's what you want, then an easier check is to use GetVersion()
rather than GetVersionEx. (GetVersion() & 0x8000) is true under
Win9x, false under any NT version. See many checks like this in e.g.
kernel32.
--Juan
On 06/06/2011 10:50 AM, Juan Lang wrote:
In NT4 mode:
(osver.dwMajorVersion>= 5) is FALSE.
(osver.dwPlatformId != VER_PLATFORM_WIN32_WINDOWS) is TRUE.
(osver.dwMajorVersion>= 5 || osver.dwPlatformId !=
VER_PLATFORM_WIN32_WINDOWS) is TRUE.
Right?
Ah, right. Wrong with this comment, sorry about t
Hello Adam,
Adam Martinson wrote:
> This is to work around apps which break COM rules by not implementing
you need to follow the Wine COM guidelines:
http://wiki.winehq.org/COMGuideline
> IDropTarget::QueryInterface(). Windows doesn't expose this because it
> doesn't call CoMarshallInterface() i
Hi,
This is intended mostly for the other d3d developers, but since we have quite
a number of them now so individual CCs are a lot of work :-)
I attached the patches I currently have in my tree to give an update on what
I've been working on recently. The main aim of those patches is to reduce dr
> In NT4 mode:
> (osver.dwMajorVersion>= 5) is FALSE.
> (osver.dwPlatformId != VER_PLATFORM_WIN32_WINDOWS) is TRUE.
> (osver.dwMajorVersion>= 5 || osver.dwPlatformId !=
> VER_PLATFORM_WIN32_WINDOWS) is TRUE.
> Right?
Ah, right. Wrong with this comment, sorry about that. But my
original comment r
On 06/06/2011 10:45 AM, Juan Lang wrote:
I'm removing part of the comment because it no longer applies. We're not
just using the XP behavior for everything anymore, now we're using the 9x
behavior when it's appropriate.
When is it appropriate, and when not? I don't know, and your patch
doesn't
> I'm removing part of the comment because it no longer applies. We're not
> just using the XP behavior for everything anymore, now we're using the 9x
> behavior when it's appropriate.
When is it appropriate, and when not? I don't know, and your patch
doesn't explain that. See below for more on
On 06/06/2011 10:23 AM, Juan Lang wrote:
Hi Adam,
perhaps I'm just being obtuse, but I don't see how Dmitry's comment
has been addressed for this patch. I'm confused by the commit comment
("Emulate Win9x if appropriate") and the change itself:
/* Win98 returns only the swapsize in ullTota
Hi Adam,
perhaps I'm just being obtuse, but I don't see how Dmitry's comment
has been addressed for this patch. I'm confused by the commit comment
("Emulate Win9x if appropriate") and the change itself:
/* Win98 returns only the swapsize in ullTotalPageFile/ullAvailPageFile,
WinXP re
On 06/03/2011 03:29 PM, Adam Martinson wrote:
On 06/03/2011 03:06 PM, Alexandre Julliard wrote:
Adam Martinson writes:
On 06/03/2011 01:33 PM, Dmitry Timoshkov wrote:
Adam Martinson wrote:
The issue is that Dragon NaturallySpeaking 7 setup doesn't have the
IMAGE_FILE_LARGE_ADDRESS_AWARE
2011/6/6 Ričardas Barkauskas :
> This patch is quite big, but unfortunately I again have no idea how I
> could split this properly. Suggestions are welcome.
>
> Ričardas Barkauskas
> REalm
>
>
I don't know how to make it any more straight forward than this. We
need to split out IDirectDrawSurface4
On 6 June 2011 10:18, Stefan Dösinger wrote:
>> We may need it for D3DUSAGE_DONOTCLIP vertex buffers, so I kept the
>> extension for the moment.
> OK. Do you have a test for this or plan to write one? Otherwise I can do that
> the next time I boot Windows.
>
I was going to wait for an actual appl
Hi,
>* nBlockAlign is wrong since data is counted in frames, not bytes.
I forgot to comment that I introduced the 10x multiplicator to
convince myself that GetData accepts buffer sizes larger than the
default 10ms chunk returned by GetDevicePeriod. That is reasonable, but
not guaranteed when I re
Hi,
perhaps I should turn this into a bug report, but I'm hoping for a quick fix.
Using wine-1.3.21 on Mac OS X 10.5.8, I observed that winecfg reported
a data DVD as "network drive" and a data CD-ROM as "floppy disk". An
audio CD was correctly reported.
This is probably caused by the recent ch
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 06.06.2011 um 09:40 schrieb Henri Verbeet:
> We may need it for D3DUSAGE_DONOTCLIP vertex buffers, so I kept the
> extension for the moment.
OK. Do you have a test for this or plan to write one? Otherwise I can do that
the next time I boot Windows
On 6 June 2011 09:11, Stefan Dösinger wrote:
>> Since we report D3DPMISCCAPS_CLIPTLVERTS.
> Do we still need GL_ARB_depth_clamp after this change?
>
We may need it for D3DUSAGE_DONOTCLIP vertex buffers, so I kept the
extension for the moment.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 05.06.2011 um 22:48 schrieb Henri Verbeet:
> Since we report D3DPMISCCAPS_CLIPTLVERTS.
Do we still need GL_ARB_depth_clamp after this change?
-BEGIN PGP SIGNATURE-
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
iQIcBAEBAgAGBQJN7H3AAAoJEN0/YqbE
26 matches
Mail list logo
