Re: dinput: Added a check for NULL callback in EnumDevices.

2011-06-03 Thread Vitaliy Margolen
On 06/03/2011 04:19 PM, Lucas Fialho Zawacki wrote: In the absence of this check apps passing a NULL pointer as callback to EnumDevices segfault under Wine. Do you have an example of such application? And the bug in bugzilla? Vitaliy.

Re: [2/2] explorer: add a navbar to explorer

2011-06-03 Thread Juan Lang
Hi Jay, +static const WCHAR ForwardButtonName[] = {'F','o','w','a','r','d','\0'}; Misspelled. --Juan

Re: [1/2] explorer: implement the explorer using IExplorerBrowser

2011-06-03 Thread Juan Lang
Hi Jay, +static void MakeExplorerWindow(IShellFolder* startFolder, HINSTANCE hInstance) I know the general rule of thumb when modifying an existing file is to keep its style, but we also tend to stay away from this style of function naming. It looks too much like the functions could be Win32 API

Re: [PATCH 1/4] winealsa.drv: Partially implement IAudioSessionManager2

2011-06-03 Thread Andrew Eikum
On 06/03/2011 05:10 PM, Joris Huizer wrote: I'm sorry if I'm wrong, but it seems to me in this and following patches, the AudioSessionManager_Release() function is incomplete - I think the dealing with ref == 0 is missing. Shoot, you're right. That's what I get for sending patches late on a Fr

Re : Re : ddraw: Add tests for Setcooperativelevel

2011-06-03 Thread paulo lesgaz
Any reason it was not commited yet? A+ David De : paulo lesgaz À : Stefan Dösinger ; wine-devel@winehq.org Envoyé le : Mer 1 juin 2011, 20h 37min 36s Objet : Re : ddraw: Add tests for Setcooperativelevel De : Stefan Dös

Re: [PATCH 1/4] winealsa.drv: Partially implement IAudioSessionManager2

2011-06-03 Thread Joris Huizer
I'm sorry if I'm wrong, but it seems to me in this and following patches, the AudioSessionManager_Release() function is incomplete - I think the dealing with ref == 0 is missing. HTH, Joris

WineConf 2011 - Minneapolis, MN - October 1,2

2011-06-03 Thread Jeremy White
Hi Folks, We have made arrangements for this year's WineConf to happen in Minneapolis, MN on Saturday October 1 and Sunday October 2. Minneapolis is the little known other city of the Twin Cities across the river from our home town, St. Paul. I've put some preliminary information up on the Wiki:

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-03 Thread Adam Martinson
On 06/03/2011 03:06 PM, Alexandre Julliard wrote: Adam Martinson writes: On 06/03/2011 01:33 PM, Dmitry Timoshkov wrote: Adam Martinson wrote: The issue is that Dragon NaturallySpeaking 7 setup doesn't have the IMAGE_FILE_LARGE_ADDRESS_AWARE flag set, but it uses InstallShield 6 as a chil

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-03 Thread Adam Martinson
On 06/03/2011 02:36 PM, Dmitry Timoshkov wrote: Adam Martinson wrote: The issue is that Dragon NaturallySpeaking 7 setup doesn't have the IMAGE_FILE_LARGE_ADDRESS_AWARE flag set, but it uses InstallShield 6 as a child process, which does have it set. IS6 calls GlobalMemoryStatus() and passes

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-03 Thread Alexandre Julliard
Adam Martinson writes: > On 06/03/2011 01:33 PM, Dmitry Timoshkov wrote: >> Adam Martinson wrote: >> >>> The issue is that Dragon NaturallySpeaking 7 setup doesn't have the >>> IMAGE_FILE_LARGE_ADDRESS_AWARE flag set, but it uses InstallShield 6 as >>> a child process, which does have it set. I

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-03 Thread Dmitry Timoshkov
Adam Martinson wrote: > >> The issue is that Dragon NaturallySpeaking 7 setup doesn't have the > >> IMAGE_FILE_LARGE_ADDRESS_AWARE flag set, but it uses InstallShield 6 as > >> a child process, which does have it set. IS6 calls GlobalMemoryStatus() > >> and passes the data back to DNS7 setup, an

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-03 Thread Adam Martinson
On 06/03/2011 01:33 PM, Dmitry Timoshkov wrote: Adam Martinson wrote: The issue is that Dragon NaturallySpeaking 7 setup doesn't have the IMAGE_FILE_LARGE_ADDRESS_AWARE flag set, but it uses InstallShield 6 as a child process, which does have it set. IS6 calls GlobalMemoryStatus() and passes

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-03 Thread Dmitry Timoshkov
Adam Martinson wrote: > The issue is that Dragon NaturallySpeaking 7 setup doesn't have the > IMAGE_FILE_LARGE_ADDRESS_AWARE flag set, but it uses InstallShield 6 as > a child process, which does have it set. IS6 calls GlobalMemoryStatus() > and passes the data back to DNS7 setup, and if you

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-03 Thread Adam Martinson
On 06/03/2011 09:14 AM, Adam Martinson wrote: On 06/03/2011 03:41 AM, Dmitry Timoshkov wrote: Adam Martinson wrote: Your previous quesion: > How do the processes running in separate address spaces have anything to do with that? I thought I addressed that with this version of the patch, bu

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-03 Thread Adam Martinson
On 06/03/2011 03:41 AM, Dmitry Timoshkov wrote: Adam Martinson wrote: Your previous quesion: > How do the processes running in separate address spaces have anything to do with that? I thought I addressed that with this version of the patch, but if I'm not checking address space correctly,

Re: [1/3] kernel32/heap: Emulate Win9x if appropriate in GlobalMemoryStatusEx(). (resend)

2011-06-03 Thread Adam Martinson
On 06/03/2011 03:37 AM, Dmitry Timoshkov wrote: Adam Martinson wrote: The stuff in that block is for win2k+ mode only. Win9x doesn't add [Total|Avail]Phys to [Total|Avail]PageFile. If wine is in win9x mode it should behave like win9x, or it confuses old apps. This is needed for the 2nd patc

Re: [PATCH 3/3] msvcrt: Improved tolower_l and toupper_l implementation

2011-06-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11457 Your paranoid android

Re: [4/4] ws2_32: Avoid a crash with an optional pointer in WSAAsyncGetServByName.

2011-06-03 Thread Andrew Nguyen
On 06/01/2011 11:09 AM, Alexandre Julliard wrote: > Andrew Nguyen writes: > >> On 06/01/2011 07:39 AM, Marvin wrote: >>> === WXPPROSP3 (32 bit sock) === >>> sock.c:501: Test failed: oob_server (218): unexpectedly at the OOB mark: 0 >>> sock.c:511: Test failed: oob_server (218): unexpectedly at th

mmdevapi buffering

2011-06-03 Thread Joerg-Cyril.Hoehle
Hi, Andrew Eikum wrote: >Then, GetCurrentPadding() returns "write - read" and GetBufferSize() returns >the queue size limit. >As far as I can tell, this is entirely consistent with how Windows behaves. I added some lines to mmdevapi/tests/render.c to find out more about mmdevapi with the help of

Re: [1/5] wined3d: Add support for GL_ARB_timer_query.

2011-06-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'd recommend to wait for Henri to return from vacation before applying these Am 02.06.2011 um 19:25 schrieb Adam Martinson: > --- > dlls/wined3d/directx.c|1 + > dlls/wined3d/wined3d_gl.h | 19 +++ > 2 files changed, 20 inser

winealsa.drv:mmdevapi input validation

2011-06-03 Thread Joerg-Cyril.Hoehle
Andrew Eikum wrote: >Frankly, I see little reason to spend time implementing special handling >of exclusive mode unless we find an app that does something that requires it. Actually, I don't know whether any of the apps I own can use mmdevapi. I've been looking at it because I believe you are goi

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-03 Thread Dmitry Timoshkov
Adam Martinson wrote: > Your previous quesion: > > How do the processes running in separate address spaces have anything > to do with that? > > I thought I addressed that with this version of the patch, but if I'm > not checking address space correctly, please tell me the correct way. > PEB

Re: [1/3] kernel32/heap: Emulate Win9x if appropriate in GlobalMemoryStatusEx(). (resend)

2011-06-03 Thread Dmitry Timoshkov
Adam Martinson wrote: > The stuff in that block is for win2k+ mode only. Win9x doesn't add > [Total|Avail]Phys to [Total|Avail]PageFile. If wine is in win9x mode it > should behave like win9x, or it confuses old apps. This is needed for > the 2nd patch, IIRC removing the photoshop 4 hack in