A request about the release notes

2011-06-01 Thread Scott Ritchie
When 1.3.19 came out it changed the build requirements for OSS support -- OSS 3 was no longer supported and OSS 4 dev libraries were required at build time. This was the changelog: New sound driver architecture for MMDevAPI. Better support for relative mouse events in DInput. Debugger

Re : ddraw: Add tests for Setcooperativelevel

2011-06-01 Thread paulo lesgaz
De : Stefan Dösinger À : wine-devel@winehq.org Cc : paulo lesgaz Envoyé le : Mer 1 juin 2011, 15h 11min 25s Objet : Re: ddraw: Add tests for Setcooperativelevel On Wednesday 01 June 2011 08:01:57 paulo lesgaz wrote: >> Hi, >> >> any problem with the patch >

Re: wined3d: Set container of swapchain surfaces to WINED3D_CONTAINER_NONE in swapchain_init() error path.

2011-06-01 Thread Stefan Dösinger
On Wednesday 01 June 2011 01:38:24 Piotr Pawłow wrote: > Since commit fadfdf21c055caf833a137ffc269c2073dc87fd6 surface refcounts are > forwarded to the container. We need to break this forwarding in > swapchain_init() error path, otherwise the swapchain refcount goes down to > zero and swapchain_cl

Re: Added unbound sampler test for pixel shaders.

2011-06-01 Thread Alexandre Julliard
Sean Sube writes: > --- > dlls/d3d9/tests/visual.c | 80 > ++ > 1 files changed, 80 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visua

Re: [4/4] ws2_32: Avoid a crash with an optional pointer in WSAAsyncGetServByName.

2011-06-01 Thread Alexandre Julliard
Andrew Nguyen writes: > On 06/01/2011 07:39 AM, Marvin wrote: >> === WXPPROSP3 (32 bit sock) === >> sock.c:501: Test failed: oob_server (218): unexpectedly at the OOB mark: 0 >> sock.c:511: Test failed: oob_server (218): unexpectedly at the OOB mark: 0 > > The test failure is not related to my ch

Re: RFC: d3d9: Increment the reference count of the IDirect3D9 instance when creating a device.

2011-06-01 Thread Stefan Dösinger
On Tuesday 31 May 2011 13:55:21 Andrew Nguyen wrote: > The Pathologic demo in bug 21552 expects that the reference count of a > IDirect3D9 instance is incremented after a successful call to > CreateDevice with the instance. > > Does my proposed fix for d3d8 and d3d9 manage the reference count of t

Re: mmdevapi buffering

2011-06-01 Thread Andrew Eikum
On 06/01/2011 07:33 AM, joerg-cyril.hoe...@t-systems.com wrote: The problematic situation is when avail is small, as the following sleep for half a buffer size in MSDN's example will inevitably produce an xrun. So what actually is the buffer size and how does GetCurrentPadding behave? I don't e

Re: winealsa.drv:mmdevapi input validation

2011-06-01 Thread Andrew Eikum
Hi Joerg, On 06/01/2011 07:00 AM, joerg-cyril.hoe...@t-systems.com wrote: because of bug #27087, I had a look at the emerging mmdevapi code. Actually, it's the first time I read its documentation on MSDN. Here are a few comments of mine while reading the code. Thanks for the careful review!

Re: ddraw: Add tests for Setcooperativelevel

2011-06-01 Thread Stefan Dösinger
On Wednesday 01 June 2011 08:01:57 paulo lesgaz wrote: > Hi, > > any problem with the patch > > http://source.winehq.org/patches/data/74702 I guess Alexandre was waiting for a reply from me or Henri. The tests themselves look ok, but I wonder what your ultimate goal is - is there a game that ha

Re: [4/4] ws2_32: Avoid a crash with an optional pointer in WSAAsyncGetServByName.

2011-06-01 Thread Andrew Nguyen
On 06/01/2011 07:39 AM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.wineh

Re: [4/4] ws2_32: Avoid a crash with an optional pointer in WSAAsyncGetServByName.

2011-06-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11362 Your paranoid android

mmdevapi buffering

2011-06-01 Thread Joerg-Cyril.Hoehle
Hi, I have one big concern about MSDN's "Rendering a stream" (shared mode) example w.r.t wrap-around of buffer pointers and how Wine implements it. The example is at http://msdn.microsoft.com/en-us/library/dd316756(v=vs.85).aspx Suppose the write pointer is near the end of the buffer and the app

winealsa.drv:mmdevapi input validation

2011-06-01 Thread Joerg-Cyril.Hoehle
Hi, because of bug #27087, I had a look at the emerging mmdevapi code. Actually, it's the first time I read its documentation on MSDN. Here are a few comments of mine while reading the code. The handling of duration (-> buffer size) in winealsa.drv/mmdevdrv.c:AudioClient_Initialize does not perfo

Re: infosoft/tests: COM cleanup in infosoft.c.

2011-06-01 Thread Michael Stefaniuc
Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=11350 Thi

Re: [4/5] ddraw: Extend the lifetime of the IDirect3D7::EnumDevices strings beyond function scope.

2011-06-01 Thread Stefan Dösinger
Am 31.05.2011 um 18:00 schrieb Andrew Nguyen: > No, I simply defined the structure there to be consistent with the role > of the unused structure definitions I removed earlier. I can certainly > move the definition to ddraw.c. Yes, please. And yeah, the existing code could use some improvement in