Re: bug in GetUserNameW error return values

2011-05-30 Thread James McKenzie
On 5/30/11 11:52 AM, Kevin Hendricks wrote: Hi, There is a small bug in the wine implementation of GetUserNameW (and the same fix is needed in GetUserNameA). From: dlls/advapi32/advapi.c starting at line 92 if (len> *lpSize) { SetLastError(ERROR_MORE_DATA); *lpSize = le

bug in GetUserNameW error return values

2011-05-30 Thread Kevin Hendricks
Hi, There is a small bug in the wine implementation of GetUserNameW (and the same fix is needed in GetUserNameA). From: dlls/advapi32/advapi.c starting at line 92 if (len > *lpSize) { SetLastError(ERROR_MORE_DATA); *lpSize = len; return FALSE; } It seems the actu

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-30 Thread Matteo Bruni
2011/5/30 Michael Mc Donnell : > Thanks for the comments Matteo! I have a few questions below. > > On Mon, May 30, 2011 at 2:45 PM, Matteo Bruni > wrote: >> 2011/5/29 Michael Mc Donnell : >>> On Sat, May 28, 2011 at 10:08 PM, Stefan Dösinger >>> wrote: On Saturday 28 May 2011 19:55:55 you w

Re: [1/2] README: Update Linux requirements

2011-05-30 Thread Wolfram Sang
I also thought about moving 2.4.x in one context with 2.2.x, but at least no one else did so i didn't. Please do. Despite the question if it is "good enough", 2.4 is for sure not considered "current" anymore.

GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-30 Thread Michael Mc Donnell
Thanks for the comments Matteo! I have a few questions below. On Mon, May 30, 2011 at 2:45 PM, Matteo Bruni wrote: > 2011/5/29 Michael Mc Donnell : >> On Sat, May 28, 2011 at 10:08 PM, Stefan Dösinger >> wrote: >>> On Saturday 28 May 2011 19:55:55 you wrote: >>> It was implemented by settin

Re: [1/2] README: Update Linux requirements

2011-05-30 Thread André Hentschel
Am 30.05.2011 20:51, schrieb Michael Stefaniuc: > Hello André, > > On 05/30/2011 08:09 PM, André Hentschel wrote: >> now that it's official >> --- >> README |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/README b/README >> index baa6ab3..51a080b 100644 >> --- a/

Re: [1/2] README: Update Linux requirements

2011-05-30 Thread Michael Stefaniuc
Hello André, On 05/30/2011 08:09 PM, André Hentschel wrote: > now that it's official > --- > README |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/README b/README > index baa6ab3..51a080b 100644 > --- a/README > +++ b/README > @@ -41,7 +41,7 @@ support kernel thre

Re: GSoC: dinput8 Action Mapping

2011-05-30 Thread Vitaliy Margolen
On 05/29/2011 04:18 PM, Lucas Zawacki wrote: I'm sending a series of patches so everyone can take a look before I try commiting them. Please note that these contain a partial implementation of EnumDevicesBySemantics, BuildActionMap and SetActionMap, and also they're only the A versions. In genera

RE: Tahoma Font License

2011-05-30 Thread Mark Page
> Date: Wed, 25 May 2011 16:39:04 -0700 > From: sc...@open-vote.org > To: wine-devel@winehq.org > Subject: Re: Tahoma Font License > > On 05/25/2011 09:27 AM, Maarten Lankhorst wrote: > > Hi mark, > > > > 2011/5/25 Mark Page : > >> > >> I am a bit confuse

Re: GSoC: dinput8 Action Mapping

2011-05-30 Thread Marcus Meissner
On Sun, May 29, 2011 at 07:18:03PM -0300, Lucas Zawacki wrote: > Hey guys. So last week I finally got a good understanding of dinput as > a whole and nailed some trivial cases of action mapping, the ones with > the keyboard. I'm sending a series of patches so everyone can take a > look before I try

Re: [3/8] d3d8: Use D3DRESOURCETYPE -> WINED3DRESOURCETYPE enum conversion function instead of implicit conversion (clang)

2011-05-30 Thread Stefan Dösinger
On Monday 30 May 2011 13:34:25 Frédéric Delanoy wrote: > In a similar vein, there's also > +case WINED3DMULTISAMPLE_NONE: return D3DMULTISAMPLE_NONE; > +case WINED3DMULTISAMPLE_NONMASKABLE: return (D3DMULTISAMPLE_TYPE) > type; > > Does this also need to be moved to device.c? Yes, t

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-30 Thread Matteo Bruni
2011/5/29 Michael Mc Donnell : > On Sat, May 28, 2011 at 10:08 PM, Stefan Dösinger > wrote: >> On Saturday 28 May 2011 19:55:55 you wrote: >> >>> It was implemented by setting the vertex declaration to null when the >>> declaration is invalid. That seems to match what happens on Windows, >>> becau

Re: [3/8] d3d8: Use D3DRESOURCETYPE -> WINED3DRESOURCETYPE enum conversion function instead of implicit conversion (clang)

2011-05-30 Thread Frédéric Delanoy
On Mon, May 30, 2011 at 12:42, Stefan Dösinger wrote: > On Sunday 29 May 2011 09:46:06 Frédéric Delanoy wrote: > >> +static inline D3DRESOURCETYPE >> d3dresourcetype_from_wined3dresourcetype(WINED3DRESOURCETYPE type) +{ >> ... >> +        case WINED3DRTYPE_BUFFER: return D3DRTYPE_VERTEXBUFFER; >>

Re: crypt32: Add BCryptEnumAlgorithms stub.

2011-05-30 Thread David Hedberg
On Mon, May 30, 2011 at 12:45, David Hedberg wrote: > --- Sorry, the commit message should of course say bcrypt, not crypt32.

Re: [3/8] d3d8: Use D3DRESOURCETYPE -> WINED3DRESOURCETYPE enum conversion function instead of implicit conversion (clang)

2011-05-30 Thread Stefan Dösinger
On Sunday 29 May 2011 09:46:06 Frédéric Delanoy wrote: > +static inline D3DRESOURCETYPE > d3dresourcetype_from_wined3dresourcetype(WINED3DRESOURCETYPE type) +{ > ... > +case WINED3DRTYPE_BUFFER: return D3DRTYPE_VERTEXBUFFER; > ... > +static inline WINED3DRESOURCETYPE > wined3dresourcetype_

Re: [8/8] d3d8: Use D3DPRIMITIVETYPE -> WINED3DPRIMITIVETYPE enum conversion function instead of implicit conversion (clang)

2011-05-30 Thread Stefan Dösinger
On Monday 30 May 2011 11:29:26 Frédéric Delanoy wrote: > Yeah right, I changed/adapted the title in [7/8] since the conv > function wasn't needed anymore and thought that if I used a [7/8] with > another subject and (try 2) it wouldn't be noticed straightforwardly. Nah, Alexandre's scripts work ve

Re: [8/8] d3d8: Use D3DPRIMITIVETYPE -> WINED3DPRIMITIVETYPE enum conversion function instead of implicit conversion (clang)

2011-05-30 Thread Frédéric Delanoy
On Mon, May 30, 2011 at 10:58, Stefan Dösinger wrote: > > Am 29.05.2011 um 19:35 schrieb Frédéric Delanoy: > >> Please skip this patch; it needs adaptation to avoid rebasing/merge >> conflicts due to changes to be done in patch " [7/8] d3d8: Use >> D3DRENDERSTATETYPE -> WINED3DRENDERSTATETYPE enum

Re: [8/8] d3d8: Use D3DPRIMITIVETYPE -> WINED3DPRIMITIVETYPE enum conversion function instead of implicit conversion (clang)

2011-05-30 Thread Stefan Dösinger
Am 29.05.2011 um 19:35 schrieb Frédéric Delanoy: > Please skip this patch; it needs adaptation to avoid rebasing/merge > conflicts due to changes to be done in patch " [7/8] d3d8: Use > D3DRENDERSTATETYPE -> WINED3DRENDERSTATETYPE enum conversion function > instead of implicit conversion (clang).