Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-26 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 26.05.2011 um 16:27 schrieb Michael Mc Donnell: > Yeah I'd prefer it too to be 100% compatible. However, I think it is > highly unlikely that any programs depend on an exception being thrown > by EndScene in a drawing method. What EndScene method i

Re: [3/3]usp10: add Devanagari script

2011-05-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11215 Your paranoid android

Re: [PATCH 5/7] comdlg32: Implement support for custom control subitems.

2011-05-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11214 Your paranoid android

Re: [PATCH 4/7] comdlg32: Implement some functions for modifying custom controls.

2011-05-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11212 Your paranoid android

Re: [PATCH 1/7] comdlg32: Add a container for custom controls.

2011-05-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11209 Your paranoid android

Re: winscard: Implement some functions of winscard.dll

2011-05-26 Thread Alexandre Julliard
Sergey Stepanov writes: > @@ -33,6 +35,24 @@ const SCARD_IO_REQUEST g_rgSCardT0Pci = { > SCARD_PROTOCOL_T0, 8 }; > const SCARD_IO_REQUEST g_rgSCardT1Pci = { SCARD_PROTOCOL_T1, 8 }; > const SCARD_IO_REQUEST g_rgSCardRawPci = { SCARD_PROTOCOL_RAW, 8 }; > > +#define MAKE_FUNCPTR(f) static typeo

Re: USB Device Support

2011-05-26 Thread Juan Lang
Hi Scott, >        I've been working through my Dell Inspiron 1545 with Linux/Ubuntu > 10.04 LTS experiences with ongoing reviews.  I'd like to provide some help > to others considering making the transition from Windows to Linux.  I'm > trying to get my Garmin GPS to talk to its Mapsource (runnin

kernel32/heap: Fix GlobalMemoryStatus()/GlobalMemoryStatusEx()

2011-05-26 Thread Adam Martinson
There are a bunch of old apps which are known to be buggy with this, the ones I tested were: Dragon NaturallySpeaking 7 Adobe Illustrator 8 Need for Speed 2 SE (demo) Adobe Photoshop 4 Photoshop 4 has a hack in GlobalMemoryStatus() that's causing problems for some of the others. The 2nd patch

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-26 Thread Michael Mc Donnell
On Thu, May 26, 2011 at 1:14 PM, Joris Huizer wrote: > On 05/26/2011 10:33 AM, Michael Mc Donnell wrote: >> I've added some more tests to see if I could make it fail. Microsoft's >> UpdateSemantics is not very picky. I can't get it to return anything >> but D3D_OK except for when I pass a null poi

Re: kernel32/toolhelp: PROCESSENTRY32::szExeFile is the full path in Win9x.

2011-05-26 Thread Adam Martinson
On 05/26/2011 06:38 AM, Saulius Krasuckas wrote: WRT doesn't test win9x any longer, so what's the point of putting such check in the test? Ye, I noticed that when I was looking through Marvin's results, the reason I sent this one was to have the testbot check it xD

Re: ole32/ole2: Don't call IDropTarget::QueryInterface() in RegisterDragDrop(). [whitespace fixed]

2011-05-26 Thread Adam Martinson
On 05/26/2011 06:56 AM, Huw Davies wrote: On Thu, May 26, 2011 at 06:51:13AM -0500, Adam Martinson wrote: On 05/26/2011 06:47 AM, Huw Davies wrote: On Wed, May 25, 2011 at 12:45:15PM -0500, Adam Martinson wrote: On 05/25/2011 12:36 PM, Adam Martinson wrote: The AddRef is done in WrapDropTarge

Re: ole32/ole2: Don't call IDropTarget::QueryInterface() in RegisterDragDrop(). [whitespace fixed]

2011-05-26 Thread Huw Davies
On Thu, May 26, 2011 at 06:51:13AM -0500, Adam Martinson wrote: > On 05/26/2011 06:47 AM, Huw Davies wrote: > >On Wed, May 25, 2011 at 12:45:15PM -0500, Adam Martinson wrote: > >>On 05/25/2011 12:36 PM, Adam Martinson wrote: > >>>The AddRef is done in WrapDropTarget(), seems like the appropriate >

Re: ole32/ole2: Don't call IDropTarget::QueryInterface() in RegisterDragDrop(). [whitespace fixed]

2011-05-26 Thread Adam Martinson
On 05/26/2011 06:47 AM, Huw Davies wrote: On Wed, May 25, 2011 at 12:45:15PM -0500, Adam Martinson wrote: On 05/25/2011 12:36 PM, Adam Martinson wrote: The AddRef is done in WrapDropTarget(), seems like the appropriate place for it. Quite right on the rest though, thanks. Oops no, the window

Re: ole32/ole2: Don't call IDropTarget::QueryInterface() in RegisterDragDrop(). [whitespace fixed]

2011-05-26 Thread Huw Davies
On Wed, May 25, 2011 at 12:45:15PM -0500, Adam Martinson wrote: > On 05/25/2011 12:36 PM, Adam Martinson wrote: > >The AddRef is done in WrapDropTarget(), seems like the appropriate > >place for it. Quite right on the rest though, thanks. > > Oops no, the window prop should be pDropTarget, not th

Re: kernel32/toolhelp: PROCESSENTRY32::szExeFile is the full path in Win9x.

2011-05-26 Thread Saulius Krasuckas
* On Wed, 25 May 2011, Adam Martinson wrote: > > Dragon NaturallySpeaking 7 expects this in Win98 mode. > --- > dlls/kernel32/tests/toolhelp.c | 19 +++- > dlls/kernel32/toolhelp.c | 48 +-- > 2 files changed, 53 insertions(+), 14 deletion

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-26 Thread Joris Huizer
On 05/26/2011 10:33 AM, Michael Mc Donnell wrote: I've added some more tests to see if I could make it fail. Microsoft's UpdateSemantics is not very picky. I can't get it to return anything but D3D_OK except for when I pass a null pointer. My implementation follows this behavior except for two c

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-26 Thread Michael Mc Donnell
On Wed, May 25, 2011 at 9:53 AM, Michael Mc Donnell wrote: > On Tue, May 24, 2011 at 8:32 PM, Stefan Dösinger > wrote: >> On Tuesday 24 May 2011 19:56:06 Michael Mc Donnell wrote: >>> > *) In your first test you forgot to check the HeapAlloc result. >>> >>> Ok, I'll return E_OUTOFMEMORY in that