Re: [PATCH] dinput: Mark internal symbols as hidden visibility

2011-05-16 Thread Marcus Meissner
On Mon, May 16, 2011 at 08:26:08PM -0600, Vitaliy Margolen wrote: > On 05/13/2011 08:51 AM, Marcus Meissner wrote: > >-const DIDATAFORMAT c_dfDIJoystick = { > >+DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIJoystick = { > > >-const DIDATAFORMAT c_dfDIJoystick2 = { > >+DECLSPEC_HIDDEN const DIDATAFORMAT

Re: Trailing white space and other pedantry.

2011-05-16 Thread max
On 05/16/2011 09:39 PM, Ken Thomases wrote: On May 16, 2011, at 7:42 PM, max wrote: On 05/16/2011 01:00 PM, André Hentschel wrote: I understand that white space only patches will not be applied. Will they be applied if they accompany other corrections? If one would otherwise have modified a l

Re: [PATCH] dinput: Mark internal symbols as hidden visibility

2011-05-16 Thread Vitaliy Margolen
On 05/13/2011 08:51 AM, Marcus Meissner wrote: -const DIDATAFORMAT c_dfDIJoystick = { +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIJoystick = { -const DIDATAFORMAT c_dfDIJoystick2 = { +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIJoystick2 = { -const DIDATAFORMAT c_dfDIMouse = { +DECLSPEC_HIDDEN c

Re: Trailing white space and other pedantry.

2011-05-16 Thread Ken Thomases
On May 16, 2011, at 7:42 PM, max wrote: > On 05/16/2011 01:00 PM, André Hentschel wrote: >> Am 16.05.2011 18:34, schrieb m...@mtew.isa-geek.net: >>> From: Max TenEyck Woodbury >>> >>> I have been working on the documentation extraction problem and code >>> analysis problem. >>> >>> I have made s

Re: Trailing white space and other pedantry.

2011-05-16 Thread max
On 05/16/2011 01:00 PM, André Hentschel wrote: Am 16.05.2011 18:34, schrieb m...@mtew.isa-geek.net: From: Max TenEyck Woodbury I have been working on the documentation extraction problem and code analysis problem. I have made some progress with the program I am writing to do this. It reads th

Re: Regression in ioctl

2011-05-16 Thread André Hentschel
Am 16.05.2011 22:49, schrieb Susan Cragin: > This popped up today, and prevented me from opening my program. > > susan@ubuntu:~/.wine/drive_c/Program > Files/Nuance/NaturallySpeaking10/Program$ wine natspeak > fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for > IOCTL_VOLUME_GET_VOL

Regression in ioctl

2011-05-16 Thread Susan Cragin
This popped up today, and prevented me from opening my program. susan@ubuntu:~/.wine/drive_c/Program Files/Nuance/NaturallySpeaking10/Program$ wine natspeak fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS fixme:mountmgr:harddisk_ioctl unsuppor

Re: Trailing white space and other pedantry.

2011-05-16 Thread André Hentschel
Am 16.05.2011 18:34, schrieb m...@mtew.isa-geek.net: > From: Max TenEyck Woodbury > > I have been working on the documentation extraction problem and code > analysis problem. > > I have made some progress with the program I am writing to do this. It > reads the same files as c2man.pl does, but d

Trailing white space and other pedantry.

2011-05-16 Thread max
From: Max TenEyck Woodbury I have been working on the documentation extraction problem and code analysis problem. I have made some progress with the program I am writing to do this. It reads the same files as c2man.pl does, but does a more detailed parse of the code. In fact, it even reads and

Re: [5/5] comctl32/treeview: Don't send TVN_ITEMEXPANDING when item has no children

2011-05-16 Thread Nikolay Sivov
On Mon, May 16, 2011 at 2:11 PM, Alexandre Julliard wrote: > Nikolay Sivov writes: > >> Fix for http://bugs.winehq.org/show_bug.cgi?id=23591 >> >> From 3bb38e13558c6e06efbb33b7e24cc36c4ae5973f Mon Sep 17 00:00:00 2001 >> From: Nikolay Sivov >> Date: Sat, 14 May 2011 20:03:40 +0400 >> Subject: [P

Re: d3d: avoid implicit conversion warnings from identical enumeration types D3DPOOL and WINED3DPOOL (Clang)

2011-05-16 Thread Henri Verbeet
2011/5/16 Frédéric Delanoy : > Is there in that case no point in getting rid of those warnings by > adding conversion functions between those related-but-not-identical > enums? > Well, in case of something like IDirect3DCubeTexture9Impl_GetType() there's no point in asking wined3d at all, the imple

Re: d3d: avoid implicit conversion warnings from identical enumeration types D3DPOOL and WINED3DPOOL (Clang)

2011-05-16 Thread Frédéric Delanoy
2011/5/16 Henri Verbeet : > 2011/5/16 Frédéric Delanoy : >> Indeed. I'm checking a couple of other automatic non-checked enum >> conversions, and those can be problematic; e.g. D3DRESOURCETYPE and >> WINED3DRESOURCETYPE are not identical but are autoconverted without >> any kind of check. >> > The

Re: d3d: avoid implicit conversion warnings from identical enumeration types D3DPOOL and WINED3DPOOL (Clang)

2011-05-16 Thread Henri Verbeet
2011/5/16 Frédéric Delanoy : > Indeed. I'm checking a couple of other automatic non-checked enum > conversions, and those can be problematic; e.g. D3DRESOURCETYPE and > WINED3DRESOURCETYPE are not identical but are autoconverted without > any kind of check. > The resource type handling in e.g. d3d9

Re: [5/5] comctl32/treeview: Don't send TVN_ITEMEXPANDING when item has no children

2011-05-16 Thread Alexandre Julliard
Nikolay Sivov writes: > Fix for http://bugs.winehq.org/show_bug.cgi?id=23591 > > From 3bb38e13558c6e06efbb33b7e24cc36c4ae5973f Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov > Date: Sat, 14 May 2011 20:03:40 +0400 > Subject: [PATCH 5/5] Don't send TVN_ITEMEXPANDING when item has no children It

Re: d3d: avoid implicit conversion warnings from identical enumeration types D3DPOOL and WINED3DPOOL (Clang)

2011-05-16 Thread Frédéric Delanoy
2011/5/16 Stefan Dösinger : > I'm not quite sure about that patch. I sent a bunch of patches to add float<- >>integer casts myself to silence some msvc warnings. WINED3DPOOL in the way it > currently is will go away sooner or later when we transition to a d3d10-style > resource model. Well there's