Re: d3d: avoid implicit conversion warnings from identical enumeration types D3DPOOL and WINED3DPOOL (Clang)

2011-05-15 Thread Stefan Dösinger
On Friday 13 May 2011 15:03:35 Frédéric Delanoy wrote: > Adding d3dpool_from_wined3dpool and wined3dpool_from_d3dpool conversion > functions instead of direct casts seems overkill for such straightforward > conversions. I'm not quite sure about that patch. I sent a bunch of patches to add float<- >

Re: [Bug 27178] advapi32: CryptEnumProvidersW may don't free resources

2011-05-15 Thread Juan Lang
You need to include your full name when sending a patch, patches from anonymous authors are not accepted. --Juan

winscard: Implement some functions of winscard.dll

2011-05-15 Thread Juan Lang
Hi Sergey, #include "config.h" +#include #include This change will cause compile failures on systems without this header. You need to add a configure check for the header, and include it conditionally. Thanks, --Juan

Re: [4/5] comctl32/treeview: Properly update image state index when TVS_CHECKBOXES is switched on

2011-05-15 Thread Nikolay Sivov
On 5/15/2011 23:47, Nikolay Sivov wrote: Naming is just ugly, especially since data structure got some binary compatibility with native one (so it's not so wine* only now). I'm sorry, duplicating subjects was unintentional. Please use 'Get rid of wine* prefixed names' as patch comment (as git

Re: ddraw/tests: Fix compilation on systems that don't support nameless unions.

2011-05-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10944 Your paranoid android

Re: usp10/tests: Add a '\n' to an ok() call.

2011-05-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10945 Your paranoid android