Re: [1/2] mmsystem.dll16: fix MCI_STATUS mapping for digitalvideo

2011-05-11 Thread Damjan Jovanovic
On Mon, May 9, 2011 at 6:35 PM, wrote: > Any of these steps means much more code than the simple^Histic > approach which has worked surprisingly well for the last 10 years: "if > flag 0002 is set in OPEN, it must be MCI_*_OPEN_PARENT, as none of > the other 4 standard drivers (wave, MIDI, av

configure looking for prelink

2011-05-11 Thread Claudio Fontana
Hello all, I noticed that wine's configure script looks for prelink using AC_PATH_PROG(PRELINK, prelink, false, [/sbin /usr/sbin $PATH]) I'd suggest changing it to AC_PATH_PROG(PRELINK, prelink, false, [/sbin /usr/sbin /usr/local/sbin $PATH]) to cover the case where the prelink package is buil

Re: dsound: return success in IDirectSoundBufferImpl_AcquireResources

2011-05-11 Thread Chris Robinson
On Wednesday, May 11, 2011 6:40:42 AM joerg-cyril.hoe...@t-systems.com wrote: > Several bugs were fixed by returning the success value that apps would get > on native, instead of returning the value that would be consistent with > the specification and implementation state in Wine, e.g. NOTSUPPORTE

winealsa.drv/midi.c: Adds the midi MTC Quarter Frame messages support.

2011-05-11 Thread Joerg-Cyril.Hoehle
Hi, well, I know little about MIDI and have no MIDI HW, yet what I read about the F1 code is that it is indeed a quarter time "tick" and takes 2 bytes, so the 2nd part of Stéphane Bacri's patch from last month looks good to me. The first half + toSend = ((ev->data.control.value &

dsound: return success in IDirectSoundBufferImpl_AcquireResources

2011-05-11 Thread Joerg-Cyril.Hoehle
Austin English wrote: - FIXME("(%p,%08u,%u,%p): stub\n",This,dwFlags,dwEffectsCount,pdwResultCodes); + FIXME("(%p,%08u,%u,%p): stub, faking success!\n",This,dwFlags,dwEffectsCount,pdwResultCodes); This is superfluous :-) "stub" is generally synonym with faking success. One lesson a

Re: msvcrt: Don't pass NULL as __ms_va_list in printf implementation

2011-05-11 Thread Eric Pouech
> > You could va_copy() it to a second va_list if you need to do it twice. > va_copy is C99. Are we ready to say that is now dependant to C89 ?. A+ -- Eric Pouech

Re: [PATCH] riched20: Fixed some lParams with keycodes (Coverity)

2011-05-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10861 Your paranoid android

Re: msvcrt: Don't pass NULL as __ms_va_list in printf implementation

2011-05-11 Thread Marcus Meissner
On Wed, May 11, 2011 at 12:20:51PM +0200, Piotr Caban wrote: > --- > dlls/msvcrt/printf.h |2 +- > dlls/msvcrt/wcs.c|4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > > diff --git a/dlls/msvcrt/printf.h b/dlls/msvcrt/printf.h > index 64d159e..53f35bc 100644 > --- a/dlls

Re: msvcrt: Don't pass NULL as __ms_va_list in printf implementation

2011-05-11 Thread Marcus Meissner
On Wed, May 11, 2011 at 12:20:51PM +0200, Piotr Caban wrote: > --- > dlls/msvcrt/printf.h |2 +- > dlls/msvcrt/wcs.c|4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > > diff --git a/dlls/msvcrt/printf.h b/dlls/msvcrt/printf.h > index 64d159e..53f35bc 100644 > --- a/dlls

Re: urlmon: Code clean up and make tests a bit stricker

2011-05-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10855 Your paranoid android

Re: [PATCH 1/3] gdi32/tests: Test for font selection by full name.

2011-05-11 Thread Grazvydas Ignotas
On Wed, May 11, 2011 at 12:08 AM, Grazvydas Ignotas wrote: > To ensure correct font is selected, look in font name table directly. > --- >  dlls/gdi32/tests/font.c |  143 > +++ >  1 files changed, 143 insertions(+), 0 deletions(-) I unintentionally sen

Re: ddraw: Fix filtering of enumerated display modes (try 3)

2011-05-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10851 Your paranoid android