Re: __ms_va_list and NULL

2011-05-10 Thread Alexandre Julliard
Piotr Caban writes: > On 05/10/11 20:02, André Hentschel wrote: >> Hi Piotr and folks, >> Most ARM crosscompilers (can't test with a native ARM one right now) don't >> like using NULL for a va_list and i'm not the only one seeing this issue. >> Piotr, i think that's your code, so maybe you can t

Re: __ms_va_list and NULL

2011-05-10 Thread Piotr Caban
On 05/10/11 20:02, André Hentschel wrote: Hi Piotr and folks, Most ARM crosscompilers (can't test with a native ARM one right now) don't like using NULL for a va_list and i'm not the only one seeing this issue. Piotr, i think that's your code, so maybe you can tell if it needs to be tuned or if

Re: [2/2] usp10/tests: test ScriptItemizeOpenType

2011-05-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10831 Your paranoid android

__ms_va_list and NULL

2011-05-10 Thread André Hentschel
Hi Piotr and folks, Most ARM crosscompilers (can't test with a native ARM one right now) don't like using NULL for a va_list and i'm not the only one seeing this issue. Piotr, i think that's your code, so maybe you can tell if it needs to be tuned or if that is a bug in the compiler (as the norma

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 6)

2011-05-10 Thread Alexandre Julliard
Charles Davis writes: >> Now it's not setting DeviceName at all here. > As far as I can tell, this is a limitation of the way mountmgr works. It > only assigns a device name when a disk is in the drive. I take it you > want me to fix that? Ultimately we'll want to create the devices even without

Re: [3/5] d3dx9: Implement D3DXMESHOPT_ATTRSORT|D3DXMESHOPT_IGNOREVERTS. (try 2)

2011-05-10 Thread Alexandre Julliard
Dylan Smith writes: > static HRESULT WINAPI ID3DXMeshImpl_OptimizeInplace(ID3DXMesh *iface, DWORD > flags, CONST DWORD *adjacency_in, DWORD *adjacency_out, > DWORD *face_remap_out, > LPD3DXBUFFER *vertex_remap_out) > { That function clearl

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 6)

2011-05-10 Thread Charles Davis
On 5/10/11 11:11 AM, Alexandre Julliard wrote: > Charles Davis writes: > >> Try 6: Fix some problems noticed by Vitaliy Margolen. >> Try 5: Get the value of "DeviceName" from mountmgr instead of making one up. >> Try 4: Fix unused variable warning. >> Try 3: Add support for IDE drives. >> Try 2:

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 6)

2011-05-10 Thread Alexandre Julliard
Charles Davis writes: > Try 6: Fix some problems noticed by Vitaliy Margolen. > Try 5: Get the value of "DeviceName" from mountmgr instead of making one up. > Try 4: Fix unused variable warning. > Try 3: Add support for IDE drives. > Try 2: Don't depend on the SCSI generic driver on Linux. > > --

Re: gdi32: Handle pre-Unicode symbol TTFs with symbols at U+00XX.

2011-05-10 Thread Alexandre Julliard
"Konstantin L. Metlov" writes: > Commit 834378183ad2dffa84fab63b080c31241ac33cba handles the case when glyph > is in the U+F0XX range differently > from the original patch. The commit (as I've just tested) does not fix the > problem with special symbols in > KOMPAS 3D CAD, which original patc

Re: [PATCH try6] wininet: Added support for persistent HTTP connections

2011-05-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10825 Your paranoid android

Re: ddraw: Fix filtering of enumerated display modes by bits per pixel

2011-05-10 Thread Stefan Dösinger
>> Please add an additional test that passes in non-null flags that >don't match >> standard R5G6B5. > >I'm not exactly sure what you mean with this. The other test has mask >of >R5G5B5. The one that's missing is R5G6B5, but I don't think it's >needed. E.g. a red mask of 0xf0f0, green 0x0f00 and

Re: comctl32/listview: Make edit box handle available from LVN_ENDLABELEDIT notification

2011-05-10 Thread Alexandre Julliard
Vitaliy Margolen writes: > I'm guessing AJ doesn't care much about such details. So NVM. > > Anyone want's to remove any requirements to wine tests? As long as > they compile and pass on AJ's pc, is seems to be the only requirement. The tests are supposed to succeed. Writing fancy failure messag

Re: ddraw: Fix filtering of enumerated display modes by bits per pixel

2011-05-10 Thread Ričardas Barkauskas
On 05/09/2011 10:11 PM, Stefan Dösinger wrote: > On Monday 09 May 2011 20:55:21 Ričardas Barkauskas wrote: >> +modes16bpp_cnt = 0; >> +U2(ddsd.ddpfPixelFormat).dwRBitMask = 0x; >> +U3(ddsd.ddpfPixelFormat).dwGBitMask = 0x; >> +U4(ddsd.ddpfPixelFormat).dwBBitMask = 0x; >