Re: [PATCH] Add undocumented function to unify MultiByteToWideChar conversation

2011-04-27 Thread Nikolay Sivov
On 4/28/2011 10:45, Alexey Fisher wrote: MultiByteToWideChar are called directly only from one function. All other colls in comctl32 go thrue this function. It was recovered with from dissassambled code. This is not allowed in Wine development. All you can use is tests, but after this patch y

[PATCH] Add undocumented function to unify MultiByteToWideChar conversation

2011-04-27 Thread Alexey Fisher
MultiByteToWideChar are called directly only from one function. All other colls in comctl32 go thrue this function. It was recovered with from dissassambled code. Signed-off-by: Alexey Fisher --- dlls/comctl32/comctl32undoc.c | 41 + 1 files changed, 41

Re: comctl32/tests: Remove practically unused parameters from test functions

2011-04-27 Thread Vitaliy Margolen
On 04/27/2011 09:47 AM, Nikolay Sivov wrote: On 4/27/2011 17:53, Vitaliy Margolen wrote: On 04/27/2011 01:14 AM, Nikolay Sivov wrote: Remove practically unused parameters from test functions So how is global variable any better then local variable passed as function parameter? Because there

Re: infosoft/tests: COM cleanup in infosoft.c.

2011-04-27 Thread Michael Stefaniuc
Alexandre, please ignore this patch as my script seems to have missed two places to change. bye michael On 04/28/2011 12:52 AM, Marvin wrote: While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I

Re: infosoft/tests: COM cleanup in infosoft.c.

2011-04-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10605 Your paranoid android

Re: Question on Conformance Test

2011-04-27 Thread Stefan Dösinger
On Wednesday 27 April 2011 18:05:59 Austin English wrote: > Normal practice is to try to match the XP+ behavior, and mark NT as > broken if it differs. In d3d we prefer results that some applications depend on. E.g. Windows XP has pretty relaxed or no error checking on IDirect3DVertexBuffer9::Lock

Re: wined3d: Track when the FBO is dirty. (try 4)

2011-04-27 Thread Adam Martinson
On Tuesday 26 April 18:16:27 Henri Verbeet wrote: > This is mostly the same as the previous version. Yes, it's just rebased. I'm happy to change it however you see fit, but I need to know what you'd like changed and how.

Re: winealsa.drv: Add mmdevapi driver.

2011-04-27 Thread Reece Dunn
On 27 April 2011 15:48, wrote: > Andrew Eikum wrote: > >>>Does CoTaskMemFree match HeapAlloc? >>would anyone more familiar with CoTaskMem* want to comment? CoTaskMemFree should be used on memory allocated with CoTaskMalloc (just like malloc/free, HeapAlloc/HeapFree, etc.). It is typically used f

D3D performance debugging report

2011-04-27 Thread Stefan Dösinger
Hi, I spent a few hours debugging wined3d performance today. No, I found no magic fix for the slowness, just some semi-usable data. First I wrote a hacky patch to avoid redundant FBO applications. This gave a tiny, tiny performance increase, see http://www.winehq.org/pipermail/wine- devel/2011-

Re: wined3d: Track when the FBO is dirty. (try 4)

2011-04-27 Thread Stefan Dösinger
On Wednesday 27 April 2011 18:26:08 Adam Martinson wrote: > Will do, but this is for http://source.winehq.org/patches/data/73534 not > http://source.winehq.org/patches/data/73533. Yep, I accidentally replied to the wrong mail(and wrote another mail to mention that) signature.asc Description: Th

Re: wined3d: Track when the FBO is dirty. (try 4)

2011-04-27 Thread Adam Martinson
On Wednesday 27 Apr 2011 01:19:51 Stefan Dösinger wrote: On Tuesday 26 April 2011 19:35:06 Adam Martinson wrote: > -FIXME("Unrecognized D3DZBUFFERTYPE value %#x.\n", > +WARN("treating unrecognized D3DZBUFFERTYPE value %#x as WINED3DZB_TRUE.\n", >

Re: Question on Conformance Test

2011-04-27 Thread Austin English
On Tue, Apr 26, 2011 at 22:50, James McKenzie wrote: > All: > > I am writing a conformance test for the richedit function EM_FINDWORDBREAK. >  I realize that WindowsNT 4.0 is our base configuration and most of the > values process the same.  However, a couple of values process differently > for Wi

Re: comctl32/tests: Remove practically unused parameters from test functions

2011-04-27 Thread Nikolay Sivov
On 4/27/2011 17:53, Vitaliy Margolen wrote: On 04/27/2011 01:14 AM, Nikolay Sivov wrote: Remove practically unused parameters from test functions So how is global variable any better then local variable passed as function parameter? Because there's no need to have different parent windows fo

winealsa.drv: Add mmdevapi driver.

2011-04-27 Thread Joerg-Cyril.Hoehle
Andrew Eikum wrote: >>Does CoTaskMemFree match HeapAlloc? >would anyone more familiar with CoTaskMem* want to comment? [cbSize slot present?] >Hm, to my surprise it seems MS no longer does this check as of Win7. Well, it's consistent with the documentation. So it's only the winmm API that has t

Re: comctl32/tests: Remove practically unused parameters from test functions

2011-04-27 Thread Vitaliy Margolen
On 04/27/2011 01:14 AM, Nikolay Sivov wrote: Remove practically unused parameters from test functions So how is global variable any better then local variable passed as function parameter? IMHO this is s wrong thing to do - to move everything as global variables just to move it back whenev

Re: wined3d: Track when the FBO is dirty. (try 4)

2011-04-27 Thread Stefan Dösinger
On Wednesday 27 April 2011 01:16:27 Henri Verbeet wrote: > This is mostly the same as the previous version. I'll add my 2 cents and one crappy patch to this discussion. It is fairly similar to Adam's patch, but attempts to avoid redundant FBO work at a higher level. The patch is pretty quick and

Question on Conformance Test

2011-04-27 Thread Joerg-Cyril.Hoehle
Hi, James McKenzie wrote: >I realize that WindowsNT 4.0 is our base configuration IMHO that doesn't matter. Winecfg's default changed from w95 to w2k to xp while I was looking. >What would be the BEST method of annotating this: >ok ( GetLastError() == WINXP_ERROR || GetLastError() == WINNT40_ER

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-04-27 Thread Michael Mc Donnell
On Tue, Apr 26, 2011 at 10:30 PM, Dylan Smith wrote: > On Tue, Apr 26, 2011 at 4:15 PM, Michael Mc Donnell > wrote: >> >> > Completely unimplemented: >> > - ConvertPointRepsToAdjacency >> > - ConvertAdjacencyToPointReps >> > - UpdateSemantics >> >> Ok so I can still work on ConvertPointRepsToAdja