Creating tests for rasapi32.dll

2011-04-21 Thread Gerold Jens Wucherpfennig
Hi, I want to try to create some tests for rasapi32.dll. May I just create some tests and do the implementation later? For the time being that will mean that RASAPI32 tests will fail, because of missing code in rasapi.c. Is that OK? I haven't created DLL-tests yet... Regards Gerold

Re: [PATCH 5/5] ddraw: Destroy the ddraw surface after the wined3d texture is destroyed.

2011-04-21 Thread Stefan Dösinger
Hi, I guess the obvious next step is to let wined3d manage the surface creation by getting rid of the CreateAdditionalSurface mess and let IWineD3DDeviceParent::CreateSurface handle this. I guess we should also get rid of the complex_array attachment list and handle those attachment by querying

Managing word agreements in PO translations?

2011-04-21 Thread Frédéric Delanoy
Hi, In various languages, there are multiple forms/agreements for a pronoun/adjective. In French, for instance masculine and feminine forms exist; in other languages (like German IIRC) there's even a neutral form (other languages may also be more complicated) while agreements in English are limit

Re: [PATCH 1/3] d3dx9: Implement ID3DXBaseEffect::GetParameterByName().

2011-04-21 Thread Henri Verbeet
2011/4/20 Rico Schüller : > +inline LPSTR get_partial_string(LPCSTR name, char initial, char final) That should probably be static instead of inline. Also, get_parameter_by_name() looks like it could be split up, and you can probably avoid the copy in get_partial_string().

Re: [PATCH 1/4] msvcp90: Added basic_string::append(size_t, char) implementation.

2011-04-21 Thread Vincas Miliūnas
Hi, >It's probably not allowed to use %lc format. Both %c and %lc produce the same trace output: trace:msvcp90:MSVCP_basic_string_wchar_assign_cstr_len 0x32fc20 L"abc" 3 trace:msvcp90:MSVCP_basic_string_wchar_append_len_wchar 0x32fc20 0 z trace:msvcp90:MSVCP_basic_string_wchar_c_str 0x32fc20 trac

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

2011-04-21 Thread Charles Davis
On 4/21/11 4:21 AM, Alexandre Julliard wrote: > Charles Davis writes: > >> On 4/20/11 9:43 AM, Alexandre Julliard wrote: >>> It doesn't seem to work here, I don't get any devices. >> Funny. It works fine on both my 32-bit and 64-bit VMs. Clearly my setup >> is broken :). >> >> By any chance, do y

Re: winex11.drv: Ignore the zero-size owners used by Delphi apps when deciding whether to add NET_WM_STATE_SKIP_TASKBAR.

2011-04-21 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This patch reverts a part of 61e50e15ba45ad54655f98619f5ef33917033165 and > fixes the regression reported in the bug 26670. This will cause spurious task bar entries in many apps. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

2011-04-21 Thread Alexandre Julliard
Charles Davis writes: > On 4/20/11 9:43 AM, Alexandre Julliard wrote: >> It doesn't seem to work here, I don't get any devices. > Funny. It works fine on both my 32-bit and 64-bit VMs. Clearly my setup > is broken :). > > By any chance, do you not have any SCSI generic (sg) files in /dev/? I don