Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

2011-04-20 Thread Charles Davis
On 4/20/11 9:43 AM, Alexandre Julliard wrote: > Charles Davis writes: > >> --- >> dlls/kernel32/Makefile.in|1 - >> dlls/kernel32/oldconfig.c| 404 >> -- >> dlls/kernel32/process.c |3 - >> dlls/mountmgr.sys/hal.c | 116 +++

Re: d3dxof/tests: Make expected value in string and comparison match.

2011-04-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10525 Your paranoid android

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

2011-04-20 Thread Alexandre Julliard
Charles Davis writes: > --- > dlls/kernel32/Makefile.in|1 - > dlls/kernel32/oldconfig.c| 404 > -- > dlls/kernel32/process.c |3 - > dlls/mountmgr.sys/hal.c | 116 > dlls/mountmgr.sys/mountmgr.c | 138 +++

Re: [PATCH 1/4] msvcp90: Added basic_string::append(size_t, char) implementation.

2011-04-20 Thread Piotr Caban
Hi, On 04/18/11 23:53, Vincas Miliūnas wrote: My remark: (The method is implemented by reusing existing code) this->size+countsize is the same as count< 0 and throwing a "string too long" exception in that case is not semantic. count is an unsigned variable so it cannot be smaller then 0. My

Re: serial: Fix race for IOCTL_SERIAL_WAIT_ON_MASK

2011-04-20 Thread Wolfgang Walter
Am Dienstag, 19. April 2011 schrieb Alexandre Julliard: > Wolfgang Walter writes: > > So this is my theorie: > > > > * wait_on() is called. > > > > * wait_on() calls RtlQueueWorkItem(wait_for_event, commio, 0 /* FIXME */) > > and returns with STATUS_PENDING > > > > * wait_for_event() finishes an

Re: serial: Fix race for IOCTL_SERIAL_WAIT_ON_MASK

2011-04-20 Thread Wolfgang Walter
Am Dienstag, 19. April 2011 schrieb Alexandre Julliard: > Wolfgang Walter writes: > > set status field of piosb to STATUS_PENDING before calling wait_on(). If > > wait_on returns with STATUS_PENDING don't touch piosb. > > > > Reason: if wait_on returns with STATUS_PENDING it started a thread which

Re: msvcrt: Added _resetstkoflw implementation

2011-04-20 Thread Alexandre Julliard
Piotr Caban writes: > StackLimit is updated by virtual_handle_stack_fault before > _resetstkoflw exits. Should I update it explicitly in _resetstkoflw > function? I suppose you can assume you'll get a stack fault at that point. A comment to that effect would be a good idea. -- Alexandre Jullia

Re: msvcrt: Added _resetstkoflw implementation

2011-04-20 Thread Piotr Caban
On 04/19/11 18:04, Alexandre Julliard wrote: This doesn't make sense to me, why do you need a VirtualAlloc in there? It's not needed. And what about the limits in the TEB? StackLimit is updated by virtual_handle_stack_fault before _resetstkoflw exits. Should I update it explicitly in _resetst