Re: include: Add rmxftmpl.h with contents generated from rmxftmpl.x.

2011-04-19 Thread Dylan Smith
On Tue, Apr 19, 2011 at 8:32 AM, Alexandre Julliard wrote: > > Dylan Smith writes: > > > +#ifndef __WINE_RMXFTMPL_H > > +#define __WINE_RMXFTMPL_H > > + > > +/* sizeof(D3DRM_XTEMPLATES) */ > > +#define D3DRM_XTEMPLATE_BYTES 3278 > > + > > +/* Contents of D3DRM_XTEMPLATES generated using: > > + *

Re: [PATCH 03/10] msvcrt: Use callback based printf in fprintf functions family (try2)

2011-04-19 Thread Alexandre Julliard
Piotr Caban writes: > --- > dlls/msvcrt/file.c | 118 > ++-- > 1 files changed, 22 insertions(+), 96 deletions(-) This one is causing console apps to output null characters. You'll have to spend more time on this patch series, it doesn't seem qui

Re: msvcrt: Added _resetstkoflw implementation

2011-04-19 Thread Alexandre Julliard
Piotr Caban writes: > +/* > + * _resetstkoflw (MSVCRT.@) > + */ > +int CDECL _resetstkoflw(void) > +{ > +MEMORY_BASIC_INFORMATION mbi; > +SYSTEM_INFO info; > +DWORD prot; > +void *alloc; > + > +GetSystemInfo(&

Re: serial: Fix race for IOCTL_SERIAL_WAIT_ON_MASK

2011-04-19 Thread Alexandre Julliard
Wolfgang Walter writes: > So this is my theorie: > > * wait_on() is called. > > * wait_on() calls RtlQueueWorkItem(wait_for_event, commio, 0 /* FIXME */) > and returns with STATUS_PENDING > > * wait_for_event() finishes and sets iosb before io_control() continues > > * io_control sets iosb to S

Re: Cairo Graphics

2011-04-19 Thread Alexandre Julliard
Jaime Rave writes: > So i would like to know your thoughts, if Cairo could improve some > stuff or if is not related or useless to the project It's essentially useless. Cairo is based on compositing operators, but we need binary rops. -- Alexandre Julliard julli...@winehq.org

Re: include: Add rmxftmpl.h with contents generated from rmxftmpl.x.

2011-04-19 Thread Alexandre Julliard
Dylan Smith writes: > +#ifndef __WINE_RMXFTMPL_H > +#define __WINE_RMXFTMPL_H > + > +/* sizeof(D3DRM_XTEMPLATES) */ > +#define D3DRM_XTEMPLATE_BYTES 3278 > + > +/* Contents of D3DRM_XTEMPLATES generated using: > + * ../tools/binencxftmpl rmxftmpl.x | xxd -i > + */ You should generate the whole f

Re: [PATCH 06/10] msvcrt: Added sprintf_p_l implementation (try2)

2011-04-19 Thread Alexandre Julliard
Piotr Caban writes: > @@ -552,6 +552,74 @@ int FUNC_NAME(pf_printf)(FUNC_NAME(puts_clbk) pf_puts, > void *puts_ctx, const API > return written; > } > > +#ifndef PRINTF_WIDE > +/* This functions stores sizes of arguments. It uses args[0] > + * internally (in the following way): > + * 0x1

Re: serial: Fix race for IOCTL_SERIAL_WAIT_ON_MASK

2011-04-19 Thread Alexandre Julliard
Wolfgang Walter writes: > set status field of piosb to STATUS_PENDING before calling wait_on(). If > wait_on > returns with STATUS_PENDING don't touch piosb. > > Reason: if wait_on returns with STATUS_PENDING it started a thread which > itself modifies the status field. In general the iosb is n

Re: [PATCH] Fix SystemProcessorPerformanceInformation to include DPC and Interrupt times

2011-04-19 Thread Alexandre Julliard
"Ray Hinchliffe (RH)" writes: > 1) When possible report DPC and Interrupt times > > 2)Fix _APPLE_ to return times in 100ns units and zero the unset members > > 3)Change the failure code to return 100ns values > > 4)Expunge unnecessary use of RtlAllocateHeap() etc.. Separate chang

Re: psapi: Forward EmptyWorkingSet implementation to kernel32

2011-04-19 Thread Jacek Caban
On 4/19/11 2:14 PM, Dmitry Timoshkov wrote: Jacek Caban wrote: +BOOL WINAPI K32EmptyWorkingSet(HANDLE hProcess) +{ +return SetProcessWorkingSetSize(hProcess, (SIZE_T)-1, (SIZE_T)-1); +} You need to export it from kernel32. Right, I've missed that part, thanks. Also using ~0 instead

Re: psapi: Forward EmptyWorkingSet implementation to kernel32

2011-04-19 Thread Dmitry Timoshkov
Jacek Caban wrote: > +BOOL WINAPI K32EmptyWorkingSet(HANDLE hProcess) > +{ > +return SetProcessWorkingSetSize(hProcess, (SIZE_T)-1, (SIZE_T)-1); > +} You need to export it from kernel32. Also using ~0 instead of casting -1 would be better IMHO. -- Dmitry.

re: Cairo Graphics

2011-04-19 Thread Dan Kegel
Wrappers like Cairo Graphics, Phonon, and OpenAL sound nice, but can get in the way of reliably reproducing win32 behavior.