Re: [2/2] comctl32/tab: Use dpa to store item data

2011-04-11 Thread Nikolay Sivov
On Mon, Apr 11, 2011 at 11:14 PM, Henri Verbeet wrote: > On 10 April 2011 07:56, Nikolay Sivov wrote: >> Use dpa to store item data >> > This seems to break text on winecfg tabs for me. > Sorry for that, I didn't check how it looks visually. The problem is that I won't be able to patch anything

Re: [PATCH 4/4] d3d9: COM cleanup for the IDirect3DSwapChain9 iface.

2011-04-11 Thread Michael Stefaniuc
Please ignore this patch for now as it conflicts with Henri's patch. bye michael On 04/12/2011 10:23 AM, Michael Stefaniuc wrote: --- dlls/d3d9/d3d9_private.h |7 ++--- dlls/d3d9/device.c |8 +++--- dlls/d3d9/swapchain.c| 61 ++

Re: [3/3] wined3d: only acquire a context in buffer::PreLoad if we have to

2011-04-11 Thread Henri Verbeet
You can't just resend this unmodified if you're leaving buffer creation in.

Re: wined3d: Track when the FBO is dirty. (try 3)

2011-04-11 Thread Henri Verbeet
Actually, I took a look at the benchmark you said this is supposed to help. It doesn't seem to use offscreen rendering at all.

Re: [2/2] comctl32/tab: Use dpa to store item data

2011-04-11 Thread Stefan Dösinger
On Monday 11 April 2011 21:14:38 Henri Verbeet wrote: > On 10 April 2011 07:56, Nikolay Sivov wrote: > > Use dpa to store item data > > This seems to break text on winecfg tabs for me. They work for me, but when I exit winecfg I get these ERRs: err:heap:GlobalFree (0x375d0): Page fault occurred

Re: wined3d: Track when the FBO is dirty. (try 3)

2011-04-11 Thread Adam Martinson
On 04/08/2011 08:50 AM, Henri Verbeet wrote: On 7 April 2011 18:51, Adam Martinson wrote: -context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); + +if (rt_count == device->adapter->gl_info.limits.buffers&& +

Re: [2/2] comctl32/tab: Use dpa to store item data

2011-04-11 Thread Henri Verbeet
On 10 April 2011 07:56, Nikolay Sivov wrote: > Use dpa to store item data > This seems to break text on winecfg tabs for me.

Re: dbghelp: get rid of a couple unused variables (try 2)

2011-04-11 Thread Eric Pouech
Le 11/04/2011 19:07, Austin English a écrit : IMO, you should keep the variable names in comment so that we know what we're talking about: /* version = */ dwarf2_parse_u2(&ctx); or dwarf2_parse_u2(&ctx); /* version */ A+ -- Eric Pouech "The problem with designing something completely f

Re: dbghelp: get rid of a couple unused variables

2011-04-11 Thread Austin English
On Mon, Apr 11, 2011 at 01:08, Andrew Nguyen wrote: > On 04/11/2011 12:41 AM, Austin English wrote: >> > > This ignores the side effects of the dwarf2_parse_u2 function. Nice catch, thanks. I'll send a fixed version. -- -Austin

Re: gdi32/dibdrv: The dib debug channel is unused so remove it.

2011-04-11 Thread Huw Davies
On Sun, Apr 10, 2011 at 06:45:51PM +0200, Francois Gouget wrote: > It might get used soon but then it's easy to add back anyway. Very soon in fact - it gets used in the PatBlt patch I just sent ;-)