Re: [2/4] wined3d: Track when the FBO is dirty.

2011-04-07 Thread Adam Martinson
On 03/27/2011 06:45 AM, Henri Verbeet wrote: On 21 March 2011 21:57, Adam Martinson wrote: @@ -2102,6 +2121,7 @@ BOOL context_apply_clear_state(struct wined3d_context *context, IWineD3DDeviceIm if (rt_count< context->gl_info->limits.buffers) memset(context->bli

Re: [2/4] wined3d: Track when the FBO is dirty.

2011-04-07 Thread Adam Martinson
On 04/07/2011 10:54 AM, Henri Verbeet wrote: On 7 April 2011 17:40, Adam Martinson wrote: I think I've addressed all of these... attached try #2. It doesn't compile. Heh... someone changed a variable name on me, sorry. >From d0ead7dd57d17d7ea0a590e66bea4e42cba873da Mon Sep 17 00:00:00 2001 F

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.

2011-04-07 Thread Austin Lund
On 8 April 2011 08:09, Charles Davis wrote: > > I don't know if this will help but... > > Both Clang and (recent) GCC have direct support for > __attribute__((thiscall)) (and I would know about Clang, I added it to > the LLVM side). We could potentially take advantage of this and not have > to dec

Re: Google Summer of Code project

2011-04-07 Thread Jacek Caban
Hi Michał, On 4/8/11 12:28 AM, Michał Ziętek wrote: Hello, My name is Michal Zietek, I am studying Computer Science at Wroclaw University of Technology. I would like to take part at Google Summer of Code. Lately I saw Jacek Caban presenting Wine at the university and he said there could be a

Re: Google Summer of Code project

2011-04-07 Thread Charles Davis
On 4/7/11 4:28 PM, Michał Ziętek wrote: > Do you consider putting this project into Google Summer of Code? You can propose whatever you want for GSoC (as long as it's relevant to Wine, or whatever organization you're proposing to). That page is just a list of ideas to get you started. In fact, I p

Re: Google Summer of Code project

2011-04-07 Thread Austin English
On Thu, Apr 7, 2011 at 15:28, Michał Ziętek wrote: > Hello, > > My name is Michal Zietek, I am studying Computer Science at Wroclaw > University of Technology. I would like to take part at Google Summer of > Code. Lately I saw Jacek Caban presenting Wine at the university and he said > there could

Google Summer of Code project

2011-04-07 Thread Michał Ziętek
Hello, My name is Michal Zietek, I am studying Computer Science at Wroclaw University of Technology. I would like to take part at Google Summer of Code. Lately I saw Jacek Caban presenting Wine at the university and he said there could be a possibility to start in Google Summer of Code and wo

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.

2011-04-07 Thread Charles Davis
On 4/7/11 3:28 PM, Michael Stefaniuc wrote: > On 04/07/2011 07:04 PM, Dylan Smith wrote: >> On Thu, Apr 7, 2011 at 1:00 PM, Dylan Smith >> wrote: >>> >>> The rest of the richedit code needs to call the ITextHost interface >>> using the thiscall calling convention, so on i386 it calls a thunk in >>

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.

2011-04-07 Thread Michael Stefaniuc
On 04/07/2011 07:04 PM, Dylan Smith wrote: On Thu, Apr 7, 2011 at 1:00 PM, Dylan Smith wrote: The rest of the richedit code needs to call the ITextHost interface using the thiscall calling convention, so on i386 it calls a thunk in itextHostStdcallVtbl which are defined using the stdcall calli

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.

2011-04-07 Thread Dylan Smith
On Thu, Apr 7, 2011 at 1:00 PM, Dylan Smith wrote: > > The rest of the richedit code needs to call the ITextHost interface > using the thiscall calling convention, so on i386 it calls a thunk in > itextHostStdcallVtbl which are defined using the stdcall calling > convention, and perform stdcall->t

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.

2011-04-07 Thread Dylan Smith
On Thu, Apr 7, 2011 at 12:17 PM, Michael Stefaniuc wrote: > > Dylan Smith wrote: > > On Thu, Apr 7, 2011 at 5:30 AM, Michael Stefaniuc wrote: > > > >> The COM methods are already __stdcall. > >> --- > >>  dlls/riched20/txthost.c |  128 > >> ++ > >>  1 fi

Re: [2/4] wined3d: Track when the FBO is dirty.

2011-04-07 Thread Henri Verbeet
On 7 April 2011 18:55, Adam Martinson wrote: > Heh... someone changed a variable name on me, sorry. > Well yeah, things change. But how did you run the tests if the patch didn't compile?

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.

2011-04-07 Thread Michael Stefaniuc
Dylan Smith wrote: > On Thu, Apr 7, 2011 at 5:30 AM, Michael Stefaniuc wrote: > >> The COM methods are already __stdcall. >> --- >> dlls/riched20/txthost.c | 128 >> ++ >> 1 files changed, 39 insertions(+), 89 deletions(-) >> >> COM methods are suppose

Re: [2/4] wined3d: Track when the FBO is dirty.

2011-04-07 Thread Henri Verbeet
On 7 April 2011 17:40, Adam Martinson wrote: > I think I've addressed all of these... attached try #2. > It doesn't compile.

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.

2011-04-07 Thread Dylan Smith
On Thu, Apr 7, 2011 at 5:30 AM, Michael Stefaniuc wrote: > The COM methods are already __stdcall. > --- > dlls/riched20/txthost.c | 128 > ++ > 1 files changed, 39 insertions(+), 89 deletions(-) > > COM methods are supposed to use the stdcall calling c

__CxxFrameHandler unsupported on wine64?

2011-04-07 Thread Peter Urbanec
I have an application that requires MFC80.DLL. When I install only the MFC80.DLL file from the vcredist package, I end up with the following errors: wine: Call from 0x7fd606a3148b to unimplemented function MSVCR80.dll.__CxxFrameHandler, aborting So, I had a quick look at the wine source and

Re: [PATCH 2/6] winmm: DriverCallback ignores a 0 CALLBACK_WINDOW.

2011-04-07 Thread Alexandre Julliard
writes: > - I thought about merging patches 2+3+5 into one or two. After all, > they all change the one tiny DriverCallback function. > E.g. patch 2 fixes the corner case where Wine delivers a spurious > message to the thread message queue, while patch 5 generalizes > the behaviour that MS me

[PATCH 2/6] winmm: DriverCallback ignores a 0 CALLBACK_WINDOW.

2011-04-07 Thread Joerg-Cyril.Hoehle
Hi, any feedback on winmm:DriverCallback patches 2-6? - Although I superseded patch 1/6, the others are unchanged, hence I did not resend them. - I thought about merging patches 2+3+5 into one or two. After all, they all change the one tiny DriverCallback function. E.g. patch 2 fixes the corn

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking

2011-04-07 Thread Alexandre Julliard
Piotr Caban writes: > It happens when native _resetstkoflw is called when there's little > memory left on the stack. I don't know if there's any real application > that is calling it in that case. I thought that it's incorrect to grow > the stack size above stack limit anyway. No, the stack limi

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking

2011-04-07 Thread Piotr Caban
On 04/07/11 11:22, Alexandre Julliard wrote: Piotr Caban writes: Without this patch there's following condition for stack growing: if ((char *)page + page_size == NtCurrentTeb()->Tib.StackLimit) NtCurrentTeb()->Tib.StackLimit = page; If after growing the stack application protects the

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking

2011-04-07 Thread Alexandre Julliard
Piotr Caban writes: > Without this patch there's following condition for stack growing: > if ((char *)page + page_size == NtCurrentTeb()->Tib.StackLimit) > NtCurrentTeb()->Tib.StackLimit = page; > If after growing the stack application protects the memory between > StackLimit and StackLimit

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking

2011-04-07 Thread Piotr Caban
On 04/07/11 11:00, Alexandre Julliard wrote: Piotr Caban writes: It's not needed (I thought it may be not valid for whole stack). I'll send fixed version. There also should be "growing" instead of "shrinking" in commit message. It was meant to point that it's possible to change StackLimit mor

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking

2011-04-07 Thread Alexandre Julliard
Piotr Caban writes: > It's not needed (I thought it may be not valid for whole stack). I'll > send fixed version. > > There also should be "growing" instead of "shrinking" in commit > message. It was meant to point that it's possible to change StackLimit > more then once without this patch. I'm

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking

2011-04-07 Thread Piotr Caban
On 04/07/11 10:24, Alexandre Julliard wrote: Piotr Caban writes: @@ -1617,9 +1617,18 @@ BOOL virtual_handle_stack_fault( void *addr ) BYTE vprot = view->prot[((const char *)page - (const char *)view->base)>> page_shift]; if (vprot& VPROT_GUARD) { +s

Re: gsoc theming

2011-04-07 Thread Andrew Green
Thank you so much for your assistance and patience. The thing that confuses me is you want only one dll for comctl32 Though the only way i can think of to do this is to to have an xml parser inside the dll and then trying to load the correct manifest file. To check if the manifest exists or asks

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking

2011-04-07 Thread Alexandre Julliard
Piotr Caban writes: > @@ -1617,9 +1617,18 @@ BOOL virtual_handle_stack_fault( void *addr ) > BYTE vprot = view->prot[((const char *)page - (const char > *)view->base) >> page_shift]; > if (vprot & VPROT_GUARD) > { > +struct _TEB *teb = NtCurrentTeb(); >