Fwd: [PATCH 2/5] d3dx9_36: Implemented ID3DXConstantTable_SetIntArray and ID3DXConstantTable_SetInt (Try 5)

2011-03-29 Thread Travis Athougies
>> Ints and floats are represented differently and so, if we want to put >> an integer array into floating point registers, we need to have casts. >> If you were to simply call SetFloatArray, you would get nonsense >> values in the floating point registers. > > Even using casts will fall foul of th

Re: [RFC] dinput: Length can actually be 0.

2011-03-29 Thread Daniel Remenak
On Tue, Mar 29, 2011 at 1:57 PM, Vincent Pelletier wrote: > (Sorry for sending to wine-patches initially, it was intended for wnie-devel.) > > This fixes force feedback devices slamming for 10ms at full strength, as > attack is an absolute value, not a factor of effect level. > > Daniel Remenak to

Re: today's git failed to build for me

2011-03-29 Thread Francois Gouget
On Tue, 29 Mar 2011, Susan Cragin wrote: > I just downloaded today's git and tried to build it. The following are > the make errors in the terminal output. Below that, separated by a > line, are the installation errors. > > make[1]: Entering directory `/home/susan/wine/dlls/winejack.drv' > gcc

Re: today's git failed to build for me

2011-03-29 Thread Austin English
On Wed, Mar 30, 2011 at 01:16, Susan Cragin wrote: > I just downloaded today's git and tried to build it. The following are the > make errors in the terminal output. Below that, separated by a line, are the > installation errors. > > make[1]: Entering directory `/home/susan/wine/dlls/winejack.dr

today's git failed to build for me

2011-03-29 Thread Susan Cragin
I just downloaded today's git and tried to build it. The following are the make errors in the terminal output. Below that, separated by a line, are the installation errors. make[1]: Entering directory `/home/susan/wine/dlls/winejack.drv' gcc -m32 -c -I. -I. -I../../include -I../../include -D__

Re: [PATCH] kernel32: Populate HKLM\HARDWARE\DEVICEMAP\Scsi on Mac OS.

2011-03-29 Thread Charles Davis
On 3/29/11 4:34 AM, Alexandre Julliard wrote: > Charles Davis writes: > >> From: Charles Davis >> >> --- >> dlls/kernel32/Makefile.in |2 +- >> dlls/kernel32/oldconfig.c | 157 >> +++- >> 2 files changed, 154 insertions(+), 5 deletions(-) > > This

[RFC] dinput: Length can actually be 0.

2011-03-29 Thread Vincent Pelletier
(Sorry for sending to wine-patches initially, it was intended for wnie-devel.) This fixes force feedback devices slamming for 10ms at full strength, as attack is an absolute value, not a factor of effect level. Daniel Remenak told me that 0-length envelopes (attack and/or fade, not sure which co

Re: [2/3] winex11.drv: Don't modify current state if glXMakeCurrent fails.

2011-03-29 Thread Roderick Colenbrander
The first part of the patch was fine, the only concern is the error code. Since there is no WGL standard, the error codes thrown by different drivers can be inconsistent :( I'm not sure if it is better to set an error code at all or not. I'm not sure what I would prefer... Roderick On Tue, Mar 29

Re: [3/3] winex11.drv: Make wglMakeCurrent return the correct error when the drawable is invalid.

2011-03-29 Thread Roderick Colenbrander
On Tue, Mar 29, 2011 at 5:58 PM, Matteo Bruni wrote: > 2011/3/29 Roderick Colenbrander : >> The fact that a pixel format is not set on the physDev doesn't >> necessarily mean it is invalid, it just means SetPixelFormat wasn't >> called on it. Though slightly earlier in wglMakeCurrent we already >>

Re: [3/3] winex11.drv: Make wglMakeCurrent return the correct error when the drawable is invalid.

2011-03-29 Thread Matteo Bruni
2011/3/29 Roderick Colenbrander : > The fact that a pixel format is not set on the physDev doesn't > necessarily mean it is invalid, it just means SetPixelFormat wasn't > called on it. Though slightly earlier in wglMakeCurrent we already > catch that situation when compare the pixel format of the c

Re: [2/3] winex11.drv: Don't modify current state if glXMakeCurrent fails.

2011-03-29 Thread Matteo Bruni
2011/3/29 Roderick Colenbrander : > I'm not sure if the only value error wglMakeCurrent should return is > INVALID_HANDLE. What if glXMakeCurrent fails because of an invalid > context? The return value may be similar, but don't remember for sure. > > Roderick Practically speaking it seems to be ve

Re: [3/3] winex11.drv: Make wglMakeCurrent return the correct error when the drawable is invalid.

2011-03-29 Thread Roderick Colenbrander
The fact that a pixel format is not set on the physDev doesn't necessarily mean it is invalid, it just means SetPixelFormat wasn't called on it. Though slightly earlier in wglMakeCurrent we already catch that situation when compare the pixel format of the context and the hdc. Is there not somethin

Re: [2/3] winex11.drv: Don't modify current state if glXMakeCurrent fails.

2011-03-29 Thread Roderick Colenbrander
I'm not sure if the only value error wglMakeCurrent should return is INVALID_HANDLE. What if glXMakeCurrent fails because of an invalid context? The return value may be similar, but don't remember for sure. Roderick On Tue, Mar 29, 2011 at 7:42 AM, Matteo Bruni wrote: > > > > >

Re: wldap32: Accept a NULL value in ldap_set_option.

2011-03-29 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10187 Your paranoid android

Re: mshtml: Fixed node leak in HTMLEventObj

2011-03-29 Thread Alexandre Julliard
Jacek Caban writes: > --- > dlls/mshtml/htmlevent.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) This causes the mshtml:events test to hang for me. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] kernel32: Populate HKLM\HARDWARE\DEVICEMAP\Scsi on Mac OS.

2011-03-29 Thread Alexandre Julliard
Charles Davis writes: > From: Charles Davis > > --- > dlls/kernel32/Makefile.in |2 +- > dlls/kernel32/oldconfig.c | 157 +++- > 2 files changed, 154 insertions(+), 5 deletions(-) This code needs to be moved to the mountmgr first. -- Alexandre Jul

Re: [PATCH 3/4] comdlg32: Add implementation of DllRegisterServer/DllUnregisterServer. (resend)

2011-03-29 Thread Alexandre Julliard
David Hedberg writes: > @@ -274,3 +277,82 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID > riid, void **ppv) > > return CLASS_E_CLASSNOTAVAILABLE; > } > + > +/*** > + * Register/Unregister DLL, base